unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Dmitry Gutov <dgutov@yandex.ru>, 18195@debbugs.gnu.org
Subject: bug#18195: 24.3.92; window-screen-lines is not accurate
Date: Tue, 05 Aug 2014 14:20:58 +0200	[thread overview]
Message-ID: <53E0CC2A.7040801@gmx.at> (raw)
In-Reply-To: <53E0B0FB.3080203@yandex.ru>

 > It won't help to determine how much space is left below the current line if the current line is the last in the buffer but not in the window, right?

You have to calculate the height of the text from window start till the
end of the buffer and subtract the result from the window's text height.

 >  > `window-text-height' with PIXELWISE t should give you the overall
 >  > height of the window.
 >
 > `count-screen-lines' already helps with "space above the current line", and we can find out the total height of the window in pixels. So if I'm going to do the arithmetics myself, the one thing missing is the accurate value of the height of a line in the buffer.

`count-screen-lines' doesn't return a pixel value.  How do you get that
with lines of different heights and line spacing?

 > How do I obtain it (let's consider it mostly-constant)?
 >
 >> If things like line spacing are involved you really should calculate
 >> pixelwise.
 >
 > The docstring of `window-screen-lines' seems to claim that it's suitable. The implementation looks kinda right, too, but the result it returns is not accurate.

It again just returns a line value.  IIRC someone has set the font size
to 1 pixel to make this return something reasonable.  But why do all
these acrobatics?  `window-text-pixel-size' should give you everything
you need in a uniform way.  And if something's missing we can easily add
it.

martin





  reply	other threads:[~2014-08-05 12:20 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05  2:00 bug#18195: 24.3.92; window-screen-lines is not accurate Dmitry
2014-08-05  8:38 ` martin rudalics
2014-08-05 10:03   ` Dmitry Gutov
2014-08-05 10:16     ` martin rudalics
2014-08-05 10:24       ` Dmitry Gutov
2014-08-05 12:20         ` martin rudalics [this message]
2014-08-05 13:05           ` Dmitry Gutov
2014-08-05 13:50             ` martin rudalics
2014-08-05 14:06               ` Eli Zaretskii
2014-08-06 11:55               ` Dmitry Gutov
2014-08-06 16:13                 ` martin rudalics
2014-08-05 14:01             ` Eli Zaretskii
2014-08-05 13:58           ` Eli Zaretskii
2014-08-05 14:08             ` martin rudalics
2014-08-05 14:13               ` Eli Zaretskii
2014-08-05 13:57         ` Eli Zaretskii
2014-08-05 13:51       ` Eli Zaretskii
2014-08-05 13:57         ` martin rudalics
2014-08-05 14:09           ` Eli Zaretskii
2014-08-05 14:12             ` martin rudalics
2014-08-05 14:23               ` Eli Zaretskii
2014-08-05 14:38                 ` martin rudalics
2014-08-05 15:08                   ` Eli Zaretskii
2014-08-05 15:45                     ` martin rudalics
2014-08-05 17:57                       ` Eli Zaretskii
2014-08-06  9:41                         ` martin rudalics
2014-08-06 14:39                           ` Eli Zaretskii
2014-08-06 14:41                             ` Dmitry Gutov
2014-08-06 16:23                               ` Eli Zaretskii
2014-08-06 16:26                                 ` Dmitry Gutov
2014-08-06 17:24                                   ` Eli Zaretskii
2014-08-06 18:02                                     ` Dmitry Gutov
2014-08-06 18:36                                       ` Eli Zaretskii
2014-08-06 21:09                                         ` Dmitry Gutov
2014-08-06 16:15                             ` martin rudalics
2014-08-06 16:30                               ` Eli Zaretskii
2014-08-06 17:46                                 ` martin rudalics
2014-08-06 18:03                                   ` Eli Zaretskii
2014-08-07 15:08                                     ` martin rudalics
2014-08-07 15:35                                       ` Eli Zaretskii
2014-08-07 15:39                                         ` martin rudalics
2014-08-07 16:36                                           ` Eli Zaretskii
2014-08-08  8:41                                             ` martin rudalics
2014-08-08  9:16                                               ` Eli Zaretskii
2014-08-08 10:10                                                 ` martin rudalics
2014-08-08 10:25                                                   ` Eli Zaretskii
2014-08-05 13:46     ` Eli Zaretskii
2014-08-05 21:21       ` Dmitry Gutov
2014-08-06  2:52         ` Eli Zaretskii
2014-08-06 12:09           ` Dmitry Gutov
2014-08-06 14:45             ` Eli Zaretskii
2014-08-06 15:07               ` Dmitry Gutov
2014-08-06 16:25                 ` Eli Zaretskii
2014-08-06 16:37                   ` Dmitry Gutov
2014-08-06 17:26                     ` Eli Zaretskii
2014-08-05 13:35 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E0CC2A.7040801@gmx.at \
    --to=rudalics@gmx.at \
    --cc=18195@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).