unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Antipov <dmantipov@yandex.ru>
To: Mat Smiglarski <penthief@SDF.ORG>
Cc: 18180@debbugs.gnu.org
Subject: bug#18180: 24.3.92; Segfault in mark_object
Date: Mon, 04 Aug 2014 13:15:32 +0400	[thread overview]
Message-ID: <53DF4F34.4070504@yandex.ru> (raw)
In-Reply-To: <cb9b883e58451ac6754e83dc88cbde02@SDF.ORG>

On 08/04/2014 10:46 AM, Mat Smiglarski wrote:

> I have not been able to reproduce this by automating the calls to stress-speed-read.

Reproduced with (dotimes (i 100) (stress-speed-read (current-buffer)))).

Ugh, it seems that we never initialize undo-list of indirect buffer.  You can use
this trivial fix just to avoid crash:

=== modified file 'src/buffer.c'
--- src/buffer.c	2014-07-27 13:21:30 +0000
+++ src/buffer.c	2014-08-04 09:06:08 +0000
@@ -825,6 +825,7 @@
    name = Fcopy_sequence (name);
    set_string_intervals (name, NULL);
    bset_name (b, name);
+  bset_undo_list (b, BVAR (b->base_buffer, undo_list));

    reset_buffer (b);
    reset_buffer_local_variables (b, 1);

But this bug raises an interesting question: should an indirect buffer's undo list
be always the same as the one of its base buffer?

Dmitry






  reply	other threads:[~2014-08-04  9:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-03 15:03 bug#18180: 24.3.92; Segfault in mark_object Mat Smiglarski
     [not found] ` <handler.18180.B.140707825027898.ack@debbugs.gnu.org>
2014-08-03 21:08   ` bug#18180: Acknowledgement (24.3.92; Segfault in mark_object) Mat Smiglarski
2014-08-04  4:22 ` bug#18180: 24.3.92; Segfault in mark_object Dmitry Antipov
2014-08-04  6:46   ` Mat Smiglarski
2014-08-04  9:15     ` Dmitry Antipov [this message]
2014-08-06 17:29       ` Stefan Monnier
2014-08-04  4:39 ` Dmitry Antipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DF4F34.4070504@yandex.ru \
    --to=dmantipov@yandex.ru \
    --cc=18180@debbugs.gnu.org \
    --cc=penthief@SDF.ORG \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).