unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: 18176-done@debbugs.gnu.org
Subject: bug#18176: 24.4.50; Errors on dates far in the future in url.el
Date: Sun, 03 Aug 2014 08:50:35 -0700	[thread overview]
Message-ID: <53DE5A4B.5070803@cs.ucla.edu> (raw)
In-Reply-To: <m3tx5ueazr.fsf@stories.gnus.org>

That "4038" started out as a "2038" (the year 32-bit signed time_t's 
will roll around) and then someone added 2000 seemingly at random.  We 
might as well bump it to most-positive-fixnum.

However, this won't work on hosts with 32-bit time_t, because the 
low-level primitives can't go past 2038.  (Even on 64-bit hosts it won't 
work for time stamps in the very far future.)  So url-cookie-expired-p 
needs to take greater care here.

Fixing this uncovered a couple of other problems.  First, date-to-time 
shouldn't fall back on timezone-make-date-arpa-standard if encode-time 
says the date is out of range.  Second, the low-level primitives don't 
consistently call time_overflow when there's a time overflow.

This particular use case suggests that url-cookie-expired-p should treat 
out-of-range expiration dates as being infinite.

I installed a patch to do all the above, as trunk bzr 117637.  I suppose 
we could get fancier by distinguishing negative from positive time 
overflow, and/or by creating error symbols for time overflow flavors, 
but this patch should be enough to fix the current bug.





  parent reply	other threads:[~2014-08-03 15:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-02 23:18 bug#18176: 24.4.50; Errors on dates far in the future in url.el Lars Magne Ingebrigtsen
2014-08-03  2:22 ` Glenn Morris
2014-08-03  3:31 ` Glenn Morris
2014-08-03 15:50 ` Paul Eggert [this message]
     [not found] ` <handler.18176.D18176.1407081050570.notifdone@debbugs.gnu.org>
2014-08-03 15:58   ` bug#18176: closed (Re: 24.4.50; Errors on dates far in the future in url.el) Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DE5A4B.5070803@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=18176-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).