unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mvoteiza@udel.edu, 18136@debbugs.gnu.org
Subject: bug#18136: 24.4.50; crash in redisplay when calling load-theme
Date: Wed, 30 Jul 2014 19:36:00 +0200	[thread overview]
Message-ID: <53D92D00.7070600@gmx.at> (raw)
In-Reply-To: <8361ieu5nr.fsf@gnu.org>

 >>   > No, we resize the frame and then redistribute the frame dimensions
 >>   > between its windows.  When change_frame_size_1 is called with the same
 >>   > dimensions as the current frame's dimensions, it simply does nothing
 >>   > and returns.
 >>
 >> change_frame_size_1 _always_ calls adjust_frame_size now.  And the later
 >> does (almost) nothing only if the following condition holds:
 >>
 >>     if (new_text_width == old_text_width
 >>         && new_text_height == old_text_height
 >>         && new_windows_width == old_windows_width
 >>         && new_windows_height == old_windows_height
 >>         && new_pixel_width == old_pixel_width
 >>         && new_pixel_height == old_pixel_height)
 >>       /* No change.  Sanitize window sizes and return.  */
 >
 > OK, but that's the moral equivalent of what I described (based on what
 > the code did previously).  Right?

I'm not good in morals but if I remove the menubar and the "frame
dimensions" remain the same, the above conjunct does not hold because the
new text height is larger than the old one and the new windows height too.

martin





  reply	other threads:[~2014-07-30 17:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29  0:36 bug#18136: 24.4.50; crash in redisplay when calling load-theme Mark Oteiza
2014-07-29  9:05 ` Eli Zaretskii
2014-07-29 10:44   ` martin rudalics
2014-07-29 12:12     ` Eli Zaretskii
2014-07-29 14:02       ` martin rudalics
2014-07-29 14:47         ` Eli Zaretskii
2014-07-29 15:41           ` martin rudalics
2014-07-29 16:31             ` Eli Zaretskii
2014-07-29 18:23               ` martin rudalics
2014-07-29 18:29                 ` Eli Zaretskii
2014-07-30 16:45                   ` martin rudalics
2014-07-30 17:18                     ` Eli Zaretskii
2014-07-30 17:36                       ` martin rudalics [this message]
2014-07-30 17:52                         ` Eli Zaretskii
2014-07-31  8:49                           ` martin rudalics
2014-07-31 10:52                             ` Eli Zaretskii
2014-07-31 16:53                               ` martin rudalics
2014-07-31 17:55                                 ` Eli Zaretskii
2014-08-01  8:57                                   ` martin rudalics
2014-08-01 12:55                                     ` Eli Zaretskii
2014-08-04 17:23                                       ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D92D00.7070600@gmx.at \
    --to=rudalics@gmx.at \
    --cc=18136@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mvoteiza@udel.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).