bug#18122: make error when configure --without-x

bug#18122: make error when configure --without-x

[Alexey]

Hello.

I want to have latest emacs-nox.
If I try to execute `make` or `make bootstrap` after `./configure 
--without-x`, I get the following error:
/home/alukardd/git/emacs/src/frame.c:2829: undefined reference to 
`FRAME_HAS_HORIZONTAL_SCROLL_BARS'
frame.o: In function `frame_inhibit_resize':
/home/alukardd/git/emacs/src/frame.c:221: undefined reference to 
`get_frame_param'
frame.o: In function `adjust_frame_size':
/home/alukardd/git/emacs/src/frame.c:486: undefined reference to 
`FRAME_HAS_HORIZONTAL_SCROLL_BARS'
/home/alukardd/git/emacs/src/frame.c:578: undefined reference to 
`FRAME_HAS_HORIZONTAL_SCROLL_BARS'
/home/alukardd/git/emacs/src/frame.c:479: undefined reference to 
`FRAME_HAS_HORIZONTAL_SCROLL_BARS'
/home/alukardd/git/emacs/src/frame.c:479: undefined reference to 
`FRAME_HAS_HORIZONTAL_SCROLL_BARS'
frame.o: In function `make_frame':
/home/alukardd/git/emacs/src/frame.c:674: undefined reference to 
`FRAME_HAS_HORIZONTAL_SCROLL_BARS'
frame.o:/home/alukardd/git/emacs/src/frame.c:676: more undefined 
references to `FRAME_HAS_HORIZONTAL_SCROLL_BARS' follow
collect2: error: ld returned 1 exit status

How can I compile emacs without X support?

My system is:
Debian 7.6
SMP Debian 3.2.57-3+deb7u2 x86_64 GNU/Linux
gcc (Debian 4.7.2-5) 4.7.2

I install all dependencies as suggested at wiki 
(http://www.emacswiki.org/emacs/EmacsSnapshotAndDebian).

bug#18122: make error when configure --without-x

[Dmitry Antipov]

Moreover, it's just broken with --enable-gcc-warnings:

../../trunk/src/frame.c:371:1: error: no previous prototype for ‘frame_windows_min_size’ [-Werror=missing-prototypes]
  frame_windows_min_size (Lisp_Object frame, Lisp_Object horizontal, Lisp_Object pixelwise)
  ^
../../trunk/src/frame.c:413:1: error: no previous prototype for ‘adjust_frame_size’ [-Werror=missing-prototypes]
  adjust_frame_size (struct frame *f, int new_width, int new_height, int inhibit, bool pretend)
  ^
../../trunk/src/frame.c: In function ‘adjust_frame_size’:
../../trunk/src/frame.c:479:9: error: implicit declaration of function ‘FRAME_HAS_HORIZONTAL_SCROLL_BARS’ [-Werror=implicit-function-declaration]
          : max (FRAME_TEXT_TO_PIXEL_HEIGHT (f, new_text_height),
          ^
cc1: all warnings being treated as errors

And:

../../trunk/src/dispnew.c: In function ‘change_frame_size_1’:
../../trunk/src/dispnew.c:5509:7: error: implicit declaration of function ‘adjust_frame_size’ [-Werror=implicit-function-declaration]
        adjust_frame_size (f, new_width, new_height, 5, pretend);
        ^
cc1: all warnings being treated as errors

GCC 4.8.3.

Dmitry

bug#18122: bug#1812[24]: make error when configure --without-x

[Dmitry Antipov]

Issues with --without-x should be fixed in r117598.

Dmitry

bug#18122: make error when configure --without-x

[martin rudalics]

> Moreover, it's just broken with --enable-gcc-warnings:
>
> ../../trunk/src/frame.c:371:1: error: no previous prototype for ‘frame_windows_min_size’ [-Werror=missing-prototypes]
>   frame_windows_min_size (Lisp_Object frame, Lisp_Object horizontal, Lisp_Object pixelwise)
>   ^
> ../../trunk/src/frame.c:413:1: error: no previous prototype for ‘adjust_frame_size’ [-Werror=missing-prototypes]
>   adjust_frame_size (struct frame *f, int new_width, int new_height, int inhibit, bool pretend)
>   ^
> ../../trunk/src/frame.c: In function ‘adjust_frame_size’:
> ../../trunk/src/frame.c:479:9: error: implicit declaration of function ‘FRAME_HAS_HORIZONTAL_SCROLL_BARS’ [-Werror=implicit-function-declaration]
>           : max (FRAME_TEXT_TO_PIXEL_HEIGHT (f, new_text_height),
>           ^
> cc1: all warnings being treated as errors
>
> And:
>
> ../../trunk/src/dispnew.c: In function ‘change_frame_size_1’:
> ../../trunk/src/dispnew.c:5509:7: error: implicit declaration of function ‘adjust_frame_size’ [-Werror=implicit-function-declaration]
>         adjust_frame_size (f, new_width, new_height, 5, pretend);
>         ^
> cc1: all warnings being treated as errors

Thanks for fixing this (I was about to check in a similar fix but
trunk was already locked by you).

martin