From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18006-done@debbugs.gnu.org
Subject: bug#18006: Simplify via set_binary_mode
Date: Tue, 15 Jul 2014 12:39:36 -0700 [thread overview]
Message-ID: <53C58378.2000405@cs.ucla.edu> (raw)
In-Reply-To: <83egxm8z7v.fsf@gnu.org>
Eli Zaretskii wrote:
> The lib-src part looks OK to me.
Thanks, I installed that.
> This part doesn't look right. If we don't use "rt", then when
> emacs_fopen calls emacs_open
Ah, sorry, that part was a false alarm. I forgot that emacs_fopen
doesn't pass the mode string to fopen, which means there's no
portability bug there after all. If we were going to make a change I'd
prefer your (a) to your (b) as it keeps the mainline code simpler, but
doing nothing at all is simpler yet, so I'll close the bug.
prev parent reply other threads:[~2014-07-15 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 20:52 bug#18006: Simplify via set_binary_mode Paul Eggert
2014-07-13 4:20 ` Eli Zaretskii
2014-07-13 5:28 ` Paul Eggert
2014-07-13 15:02 ` Eli Zaretskii
2014-07-14 2:11 ` Paul Eggert
2014-07-14 15:21 ` Eli Zaretskii
2014-07-14 20:16 ` Paul Eggert
2014-07-15 14:37 ` Eli Zaretskii
2014-07-15 19:39 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C58378.2000405@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=18006-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).