From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Date: Wed, 11 Jun 2014 09:15:06 +0200 Message-ID: <539801FA.2040400@gmx.at> References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> <5396A087.6090606@gmx.at> <874mzs8jad.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1402470989 5534 80.91.229.3 (11 Jun 2014 07:16:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Jun 2014 07:16:29 +0000 (UTC) Cc: 17554@debbugs.gnu.org, Roland Winkler To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 11 09:16:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wuclh-0001yx-0L for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Jun 2014 09:16:21 +0200 Original-Received: from localhost ([::1]:43992 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wuclg-0006Hn-Fy for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Jun 2014 03:16:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuclV-0006GZ-Ob for bug-gnu-emacs@gnu.org; Wed, 11 Jun 2014 03:16:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuclO-0000Ur-4s for bug-gnu-emacs@gnu.org; Wed, 11 Jun 2014 03:16:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuclO-0000Ul-2B for bug-gnu-emacs@gnu.org; Wed, 11 Jun 2014 03:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WuclN-0003ML-MY for bug-gnu-emacs@gnu.org; Wed, 11 Jun 2014 03:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Jun 2014 07:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17554-submit@debbugs.gnu.org id=B17554.140247092812851 (code B ref 17554); Wed, 11 Jun 2014 07:16:01 +0000 Original-Received: (at 17554) by debbugs.gnu.org; 11 Jun 2014 07:15:28 +0000 Original-Received: from localhost ([127.0.0.1]:43482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wuckp-0003LC-Dv for submit@debbugs.gnu.org; Wed, 11 Jun 2014 03:15:27 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:53601) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wuckm-0003Ky-RU for 17554@debbugs.gnu.org; Wed, 11 Jun 2014 03:15:26 -0400 Original-Received: from [194.118.137.29] ([194.118.137.29]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0Lk81O-1WJv9k1kzK-00c7pt; Wed, 11 Jun 2014 09:15:14 +0200 In-Reply-To: <874mzs8jad.fsf@mail.jurta.org> X-Provags-ID: V03:K0:rh7ciG+PD+VVmnFRWnzF3eXX34m/v/l97hdICTV2TeyX8ZNG46o enA4zO97Gxpna0Uv3JxK4X/S6HmCmFiuUgxUuUyMLiG/uAAIlqi2Dj2+g2zHXPGjMM58nPQ aDbmVV9afoa3Gd5pMDBwWvP6H8CGntZdFPvBJuDGsCSkSyNWcrq9+CDFfOwS0c3NMQFbSAB gUUTnb9fosMPQ+Sj97/3Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90237 Archived-At: > The standard terminal size is 80x25. 80*2 = 160 which is a good > default width for `split-width-threshold'. Correspondingly, 25*2 = 50 > would be a better default height for `split-height-threshold' > to be changed in the trunk. (Another good change for the trunk > is to use `display-buffer-at-bottom' for *Completions*). What does it use currently? > For the emacs-24 branch `split-window-preferred-function' won't help > if the window height is smaller than `split-height-threshold', We'd have to write our own `split-window-preferred-function' which would set `split-height-threshold' accordingly. This is not entirely clean though since we'd bind a user variable. A user could override it via `display-buffer-alist' but this is not entirely obvious. Usually, the right choice would be to pass appropriate functions via the ACTION argument. Unfortunately, the `display-buffer' call issued for *Completions* is virtually nested in the call for *Marked Files* which makes things more complicated than expected. (1) I wouldn't want to change the general behavior of how *Completions* are presented just in order to fix the problem at hand. (2) Changing the ACTION argument for the `display-buffer' call used to show *Completions* such as to check whether a *Marked Files* buffer is currently shown and avoid using that or the original dired window is no viable alternative either. (3) Marking any of the dired or *Marked Files* windows as dedicated is somewhat dangerous (even when done softly) when the user quits the *Completions* window in some non-standard, non-modal way. (4) Using `display-buffer-overriding-action' is clearly to harsh. > and *Completions* still will be displayed in the small window > of *Marked Files*. This could be fixed only by displaying > *Completions* in the window containing the Dired buffer > (without using split-window) like it was in previous releases. > This is why I tried to mark *Marked Files* as dedicated. But the 24.3 code handles Roland's scenario by displaying *Completions* in a third window. At least it does so here. What do you get? martin