From: "Jan D." <jan.h.d@swipnet.se>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: 17486@debbugs.gnu.org, Christian Lynbech <christian@defun.dk>
Subject: bug#17486: 24.4.50; set-face-font problem on OSX
Date: Mon, 19 May 2014 08:05:15 +0200 [thread overview]
Message-ID: <53799F1B.6020504@swipnet.se> (raw)
In-Reply-To: <53797CCB.6000204@yandex.ru>
Hello.
Dmitry Antipov skrev 2014-05-19 05:38:
> On 05/18/2014 10:33 PM, Jan Djärv wrote:
>
>>> Hm... so font_matching_entity sometimes returns [#<font-entity>]
>>> instead of #<font-entity>.
>>> Something may be wrong with font cache or with font driver-specific
>>> match routine.
>>
>> How can code (driver-specific) that has not changed suddenly become
>> wrong?
>
> It may return something which doesn't match font cache data structures
> any more
> because the latter was changed (mostly to avoid glitches in
> compact_font_caches).
>
> There was a slight confusion between font_list_entities (which operates
> on vectors of font entities) and font_matching_entity (which should operate
> on font entities). Hopefully the fix is almost obvious.
>
This fixes it. Please check it in if there are no bad effects on other
ports.
Jan D.
next prev parent reply other threads:[~2014-05-19 6:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 18:21 bug#17486: 24.4.50; set-face-font problem on OSX Christian Lynbech
2014-05-16 5:06 ` Jan Djärv
2014-05-16 13:33 ` Jan D.
2014-05-16 14:53 ` Dmitry Antipov
2014-05-16 15:13 ` Jan Djärv
2014-05-16 15:46 ` Dmitry Antipov
2014-05-17 6:46 ` Jan Djärv
2014-05-18 5:43 ` Dmitry Antipov
2014-05-18 7:19 ` Jan Djärv
2014-05-18 16:17 ` Dmitry Antipov
2014-05-18 18:33 ` Jan Djärv
2014-05-19 3:38 ` Dmitry Antipov
2014-05-19 6:05 ` Jan D. [this message]
2014-05-21 15:13 ` bug#17486: Done Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53799F1B.6020504@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=17486@debbugs.gnu.org \
--cc=christian@defun.dk \
--cc=dmantipov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).