unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Antipov <dmantipov@yandex.ru>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: 17486@debbugs.gnu.org, Christian Lynbech <christian@defun.dk>
Subject: bug#17486: 24.4.50; set-face-font problem on OSX
Date: Sun, 18 May 2014 09:43:32 +0400	[thread overview]
Message-ID: <53784884.6040704@yandex.ru> (raw)
In-Reply-To: <18DD744E-FCBD-4613-A4F0-E74404B662F3@swipnet.se>

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

On 05/17/2014 10:46 AM, Jan Djärv wrote:

> I'll keep the session for a while if you need more.

Could you please check whether set-face-font hits one of the following extra easserts?

Dmitry



[-- Attachment #2: bug17486_extra_easserts.patch --]
[-- Type: text/x-patch, Size: 667 bytes --]

=== modified file 'src/font.c'
--- src/font.c	2014-04-05 19:30:36 +0000
+++ src/font.c	2014-05-18 05:37:43 +0000
@@ -3299,6 +3299,7 @@
   Lisp_Object entity, name;
 
   entity = font_find_for_lface (f, attrs, spec, -1);
+  eassert (NILP (entity) || FONT_ENTITY_P (entity));  
   if (NILP (entity))
     {
       /* No font is listed for SPEC, but each font-backend may have
@@ -3307,6 +3308,7 @@
       if (NILP (entity))
 	return Qnil;
     }
+  eassert (NILP (entity) || FONT_ENTITY_P (entity));
   /* Don't lose the original name that was put in initially.  We need
      it to re-apply the font when font parameters (like hinting or dpi) have
      changed.  */


  reply	other threads:[~2014-05-18  5:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 18:21 bug#17486: 24.4.50; set-face-font problem on OSX Christian Lynbech
2014-05-16  5:06 ` Jan Djärv
2014-05-16 13:33   ` Jan D.
2014-05-16 14:53     ` Dmitry Antipov
2014-05-16 15:13       ` Jan Djärv
2014-05-16 15:46         ` Dmitry Antipov
2014-05-17  6:46           ` Jan Djärv
2014-05-18  5:43             ` Dmitry Antipov [this message]
2014-05-18  7:19               ` Jan Djärv
2014-05-18 16:17                 ` Dmitry Antipov
2014-05-18 18:33                   ` Jan Djärv
2014-05-19  3:38                     ` Dmitry Antipov
2014-05-19  6:05                       ` Jan D.
2014-05-21 15:13 ` bug#17486: Done Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53784884.6040704@yandex.ru \
    --to=dmantipov@yandex.ru \
    --cc=17486@debbugs.gnu.org \
    --cc=christian@defun.dk \
    --cc=jan.h.d@swipnet.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).