From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jarek Czekalski Newsgroups: gmane.emacs.bugs Subject: bug#17430: 24.4.50; minibuffer history forgets the first entry Date: Wed, 07 May 2014 13:07:31 +0200 Message-ID: <536A13F3.4090902@poczta.onet.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010204050603000908020909" X-Trace: ger.gmane.org 1399461114 7457 80.91.229.3 (7 May 2014 11:11:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 May 2014 11:11:54 +0000 (UTC) To: 17430@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 07 13:11:48 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WhzlL-0004rs-2M for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 May 2014 13:11:47 +0200 Original-Received: from localhost ([::1]:40491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhzlK-00065I-JG for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 May 2014 07:11:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whzim-0002nH-OE for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 07:09:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Whzih-0003Jc-BE for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 07:09:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whzih-0003JY-8e for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 07:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Whzig-0004u4-M4 for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 07:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jarek Czekalski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 May 2014 11:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17430 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.139946088218753 (code B ref -1); Wed, 07 May 2014 11:09:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 May 2014 11:08:02 +0000 Original-Received: from localhost ([127.0.0.1]:53624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Whzhh-0004sE-KC for submit@debbugs.gnu.org; Wed, 07 May 2014 07:08:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56426) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Whzhd-0004rs-Pa for submit@debbugs.gnu.org; Wed, 07 May 2014 07:07:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhzhT-000381-3h for submit@debbugs.gnu.org; Wed, 07 May 2014 07:07:52 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:48442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhzhT-00037x-1B for submit@debbugs.gnu.org; Wed, 07 May 2014 07:07:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhzhN-0000DI-UN for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 07:07:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhzhI-00036S-T1 for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 07:07:41 -0400 Original-Received: from smtpo09.poczta.onet.pl ([213.180.142.140]:58593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhzhI-00035v-9T for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 07:07:36 -0400 Original-Received: from [192.168.17.9] (cj.e-siemianowice.pl [95.215.234.30]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jarekczek@poczta.onet.pl) by smtp.poczta.onet.pl (Onet) with ESMTPSA id 3gNw4h1LNnz9ttbT for ; Wed, 7 May 2014 13:07:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poczta.onet.pl; s=2011; t=1399460852; bh=oxG0bfnEVSYIxfZbhpeuIA3dBMAagsA8TmnI07vFo+w=; h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type; b=j7gCaN4J8QzLuqvPT/aC6qhbdqsninyOIhjJXpmniIDbrb6hU+LVug0aXlOOP7YQB mX27zCikZHEneZ+iUqdVY3Ve8pBcvskzlP2p9AMWIN0X9Kn4SAYnrDQmJTyPas/eiF GNOGzAP+MPIvDo07W2amuiHWSVG0msZt/NvsNEgw= User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88726 Archived-At: This is a multi-part message in MIME format. --------------010204050603000908020909 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Steps: 1. (read-from-minibuffer "pro: " nil nil nil 'hist) 2. type sth 3. check hist: M-S-: hist Expected: sth, Actual: nil The history value is not properly initialized. Seems like r87775 introduced a regression, because histval is not set to nil in minibuf.c. During some more tests I noticed another faulty behaviour. With empty history (unbound) I get an error message "variable void", when trying to get this history (arrow up in minibuffer). Let's move the initialization of the history a bit earlier, to prevent this error and receive expected message "Beginning of history". Previously this initialization was at "add new entry" stage, so history browsing was failing. Finally the patch contains a fix for the regression and additionally a further improvement. Stefan, could you review the patch? If I am to commit this, to which branch? emacs-24? In GNU Emacs 24.4.50.1 (i686-pc-mingw32) of 2014-05-07 on BONSOFTW7 Repository revision: 117068 eggert@cs.ucla.edu-20140506211337-crc6ozt8y6967wq3 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=d:/program_files/emacs-master' Configured features: PNG NOTIFY ACL GNUTLS LIBXML2 ZLIB Important settings: value of $LANG: pl locale-coding-system: cp1250 Major mode: Text Minor modes in effect: diff-auto-refine-mode: t global-hl-line-mode: t recentf-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x C-f j : / l a n g / g n u / e m / h i 1 C-x C-f C-SPC M-w M-x r e p o r t Recent messages: [yas] Loading compiled snippets from c:/Users/Jarek/AppData/Roaming/.emacs.d/snippets/sql-mode [yas] Loading compiled snippets from c:/Users/Jarek/AppData/Roaming/.emacs.d/snippets/text-mode Loading c:/Users/Jarek/AppData/Roaming/.emacs.d/snippets/text-mode/.yas-compiled-snippets.el (source)...done [yas] Loading snippet files from c:/Users/Jarek/AppData/Roaming/.emacs.d/snippets/text-mode [yas] Loaded ~/.emacs.d/snippets [yas] Reloaded everything.... Loading hl-line...done Loading whitespace...done Loading grep...done For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils diff-mode grep compile comint ansi-color ring whitespace hl-line cus-start cus-load xml-parse yasnippet derived easy-mmode edmacro kmacro help-mode folding-isearch folding cl-macs advice help-fns cl gv bookmark pp recentf tree-widget wid-edit cl-loaddefs cl-lib easymenu server time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process w32notify w32 multi-tty emacs) Memory information: ((conses 8 150932 5821) (symbols 24 22859 0) (miscs 20 102 150) (strings 16 24546 3867) (string-bytes 1 712166) (vectors 8 13203) (vector-slots 4 417745 4112) (floats 8 134 272) (intervals 28 363 32) (buffers 508 15)) --------------010204050603000908020909 Content-Type: text/plain; charset=windows-1250; name="history_1_01.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="history_1_01.patch" PT09IG1vZGlmaWVkIGZpbGUgJ3NyYy9DaGFuZ2VMb2cnCi0tLSBzcmMvQ2hhbmdlTG9nCTIw MTQtMDUtMDYgMjE6MTM6MzcgKzAwMDAKKysrIHNyYy9DaGFuZ2VMb2cJMjAxNC0wNS0wNyAx MDoxMTozMSArMDAwMApAQCAtMSwzICsxLDkgQEAKKzIwMTQtMDUtMDcgIEphcmVrIEN6ZWth bHNraSAgPGphcmVrY3pla0Bwb2N6dGEub25ldC5wbD4KKworCUZpeCBpbml0aWFsaXphdGlv biBvZiBtaW5pYnVmZmVyIGhpc3RvcnkgdmFyaWFibGUgKEJ1ZyN4eHh4eCkuCisJKiBtaW5p YnVmLmMgKHJlYWRfbWluaWJ1Zik6IEluaXRpYWxpemUgaGlzdHZhbCB0byBRbmlsIGlmIHVu Ym91bmQuCisJTW92ZSB0aGUgaW5pdGlhbGl6YXRpb24gdXAgdG8gcHJldmVudCBhbnkgInZh bHVlIHZvaWQiIG1lc3NhZ2UuCisKIDIwMTQtMDUtMDYgIFBhdWwgRWdnZXJ0ICA8ZWdnZXJ0 QGNzLnVjbGEuZWR1PgogCiAJKiBpbWFnZS5jOiBEbyBub3QgdXNlIGxpYnBuZyBpZiBIQVZF X05TLCBhcyBOUyBkb2VzIGl0cyBvd24gdGhpbmcuCgo9PT0gbW9kaWZpZWQgZmlsZSAnc3Jj L21pbmlidWYuYycKLS0tIHNyYy9taW5pYnVmLmMJMjAxNC0wMy0yMSAxNzowNDo1MCArMDAw MAorKysgc3JjL21pbmlidWYuYwkyMDE0LTA1LTA3IDEwOjA5OjUwICswMDAwCkBAIC0zODQs NiArMzg0LDcgQEAKICAgRU1BQ1NfSU5UIHBvcyA9IDA7CiAgIC8qIFN0cmluZyB0byBhZGQg dG8gdGhlIGhpc3RvcnkuICAqLwogICBMaXNwX09iamVjdCBoaXN0c3RyaW5nOworICBMaXNw X09iamVjdCBoaXN0dmFsOwogCiAgIExpc3BfT2JqZWN0IGVtcHR5X21pbmlidWY7CiAgIExp c3BfT2JqZWN0IGR1bW15LCBmcmFtZTsKQEAgLTUzNSw2ICs1MzYsMTMgQEAKICAgaWYgKCFO SUxQIChWbWluaWJ1ZmZlcl9jb21wbGV0aW5nX2ZpbGVfbmFtZSkpCiAgICAgVm1pbmlidWZm ZXJfY29tcGxldGluZ19maWxlX25hbWUgPSBRbGFtYmRhOwogCisgIC8qIElmIHZhcmlhYmxl IGlzIHVuYm91bmQsIG1ha2UgaXQgbmlsLiAgKi8KKyAgaGlzdHZhbCA9IGZpbmRfc3ltYm9s X3ZhbHVlIChWbWluaWJ1ZmZlcl9oaXN0b3J5X3ZhcmlhYmxlKTsKKyAgaWYgKEVRIChoaXN0 dmFsLCBRdW5ib3VuZCkpIHsKKyAgICBGc2V0IChWbWluaWJ1ZmZlcl9oaXN0b3J5X3Zhcmlh YmxlLCBRbmlsKTsKKyAgICBoaXN0dmFsID0gUW5pbDsKKyAgfQorCiAgIGlmIChpbmhlcml0 X2lucHV0X21ldGhvZCkKICAgICB7CiAgICAgICAvKiBgY3VycmVudC1pbnB1dC1tZXRob2Qn IGlzIGJ1ZmZlciBsb2NhbC4gIFNvLCByZW1lbWJlciBpdCBpbgpAQCAtNzAzLDEzICs3MTEs NiBAQAogICAgIHsKICAgICAgIC8qIElmIHRoZSBjYWxsZXIgd2FudGVkIHRvIHNhdmUgdGhl IHZhbHVlIHJlYWQgb24gYSBoaXN0b3J5IGxpc3QsCiAJIHRoZW4gZG8gc28gaWYgdGhlIHZh bHVlIGlzIG5vdCBhbHJlYWR5IHRoZSBmcm9udCBvZiB0aGUgbGlzdC4gICovCi0gICAgICBM aXNwX09iamVjdCBoaXN0dmFsOwotCi0gICAgICAvKiBJZiB2YXJpYWJsZSBpcyB1bmJvdW5k LCBtYWtlIGl0IG5pbC4gICovCi0KLSAgICAgIGhpc3R2YWwgPSBmaW5kX3N5bWJvbF92YWx1 ZSAoVm1pbmlidWZmZXJfaGlzdG9yeV92YXJpYWJsZSk7Ci0gICAgICBpZiAoRVEgKGhpc3R2 YWwsIFF1bmJvdW5kKSkKLQlGc2V0IChWbWluaWJ1ZmZlcl9oaXN0b3J5X3ZhcmlhYmxlLCBR bmlsKTsKIAogICAgICAgLyogVGhlIHZhbHVlIG9mIHRoZSBoaXN0b3J5IHZhcmlhYmxlIG11 c3QgYmUgYSBjb25zIG9yIG5pbC4gIE90aGVyCiAJIHZhbHVlcyBhcmUgdW5hY2NlcHRhYmxl LiAgV2Ugc2lsZW50bHkgaWdub3JlIHRoZXNlIHZhbHVlcy4gICovCgo= --------------010204050603000908020909--