unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#17334: 24.3; Crash in cmdproxy.exe
@ 2014-04-24  3:58 Sohail Somani
  2014-04-26  7:08 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Sohail Somani @ 2014-04-24  3:58 UTC (permalink / raw)
  To: 17334

There is a "bug" in cmdproxy.exe which should never happen, but does
anyway. In make_absolute, there is the following code:

   strncpy(dir, path, p - path);
   dir[p - path] = '\0';

If p-path > sizeof(dir), a buffer overrun occurs.

I came across this problem because I accidentally used ':' as a
separator when constructing the PATH variable in Emacs.

Thanks,

Sohail





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#17334: 24.3; Crash in cmdproxy.exe
  2014-04-24  3:58 bug#17334: 24.3; Crash in cmdproxy.exe Sohail Somani
@ 2014-04-26  7:08 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2014-04-26  7:08 UTC (permalink / raw)
  To: Sohail Somani; +Cc: 17334-done

> Date: Wed, 23 Apr 2014 23:58:57 -0400
> From: Sohail Somani <sohail@taggedtype.net>
> 
> There is a "bug" in cmdproxy.exe which should never happen, but does
> anyway. In make_absolute, there is the following code:
> 
>    strncpy(dir, path, p - path);
>    dir[p - path] = '\0';
> 
> If p-path > sizeof(dir), a buffer overrun occurs.
> 
> I came across this problem because I accidentally used ':' as a
> separator when constructing the PATH variable in Emacs.

Thanks, this is now fixed for Emacs 24.4 (revision 117021 on the
emacs-24 branch).





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-26  7:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-24  3:58 bug#17334: 24.3; Crash in cmdproxy.exe Sohail Somani
2014-04-26  7:08 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).