From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#57499: Documentation bug in the docstring of set-face-attribute? Date: Wed, 31 Aug 2022 19:33:53 +0000 Message-ID: <534c9018d2c911550778@heytings.org> References: <534c9018d2adffda3e53@heytings.org> <831qswu0p4.fsf@gnu.org> <534c9018d2f372cd7462@heytings.org> <83tu5ssi35.fsf@gnu.org> <534c9018d222586a161c@heytings.org> <83r10wsgu8.fsf@gnu.org> <534c9018d2952b7a6bd0@heytings.org> <83pmggs89x.fsf@gnu.org> <534c9018d2597d4fd752@heytings.org> <83fshcrzth.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20424"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57499@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 31 22:08:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTU0w-00052Y-2Q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 Aug 2022 22:08:42 +0200 Original-Received: from localhost ([::1]:49016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTU0u-0000XJ-S4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 Aug 2022 16:08:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTTUN-0005pQ-6Y for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2022 15:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTTUM-0005kC-TJ for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2022 15:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oTTUM-0006Cc-OF for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2022 15:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Aug 2022 19:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57499 X-GNU-PR-Package: emacs Original-Received: via spool by 57499-submit@debbugs.gnu.org id=B57499.166197444423733 (code B ref 57499); Wed, 31 Aug 2022 19:35:02 +0000 Original-Received: (at 57499) by debbugs.gnu.org; 31 Aug 2022 19:34:04 +0000 Original-Received: from localhost ([127.0.0.1]:40509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTTTJ-00069w-A8 for submit@debbugs.gnu.org; Wed, 31 Aug 2022 15:34:04 -0400 Original-Received: from heytings.org ([95.142.160.155]:49254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTTTG-00069k-Lo for 57499@debbugs.gnu.org; Wed, 31 Aug 2022 15:33:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1661974433; bh=tT9XCEkkyitqyjR4pOVlEYqB7SDFyYUoN2Xgg+ORpUs=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=l3IrI6QnAFnSJOLAROcqFtjnkztbGzlw7+ohMzC/ocgygwqxZDhVMexEPrIwhjVDD e9Cn5kzFLAwM4lkmwyI1FC6ExJ6C9oZ9uXhjIMgjR1ytm5c2K6SzbigiP1Jpw1C/Bd GfrFYMFWzaGcdrz+ALrFRCS4BetiKwRHG6Ds5Yb4A06X508Vqr6/gxwiAL6tEtiAob rWBs2ea+Pxfdh1JIVQ42XnMElS/c7GI+GcAOU3ogodfj4CWLMdNu2XYMYyc3gvcbuD yx0iA448USWvu7Rs0mgI7PYpz9j+Nq0YDDNoMDPU7BHT1VKDWyJ9+Gqe8WCc0MhnJG 7ASz+MyRN0qOw== In-Reply-To: <83fshcrzth.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241220 Archived-At: > > Set attributes of FACE on FRAME from ARGS. > > This function overrides the face attributes specified by FACE's face > spec. It is mostly intended for internal use only. > > If FRAME is a frame, set the attributes only for that frame. If FRAME > is nil, set the attributes for all existing frames, as well as the > default for new frames. If FRAME is t, change the default for new > frames only. > > ARGS must come in pairs ATTRIBUTE VALUE. ATTRIBUTE must be a valid face > attribute name and VALUE must be a value that is valid for ATTRIBUTE, as > described below for each attribute. > > All attributes can also be set to the special value `unspecified'; this > can be used to reset the value of ATTRIBUTE in a way that overrides any > value defined by the face's spec in `defface'. > This is better indeed, but I'd add "by using the symbol 'unspecified for VALUE" after "the special value `unspecified'". Or perhaps use "the special VALUE `unspecified' with the explicit symbol 'unspecified". > > (Of course, after making such a change, we will again need to answer > questions how come using value of nil and FRAME = nil doesn't reset the > attribute, something that the current doc string avoids. Oh well.) > I'm not sure I understand what you mean. If the docstring says one should use the symbol 'unspecified, it should be clear to everyone that nil shouldn't be used, no? What am I missing?