From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#17168: 24.3.50; Segfault at mark_object Date: Mon, 07 Apr 2014 12:06:36 -0700 Message-ID: <5342F73C.5020404@dancol.org> References: <87y4zop44m.fsf@yahoo.fr> <83bnwjbh8v.fsf@gnu.org> <533C75A6.60900@dancol.org> <533D06E6.2060001@yandex.ru> <533D07EF.1040502@yandex.ru> <533D13E2.3060300@dancol.org> <533D251E.3030108@dancol.org> <533D6A19.8050504@yandex.ru> <533D9099.3000104@dancol.org> <533D9F2C.7030500@yandex.ru> <533D9FBB.2050803@dancol.org> <533DB4F0.20706@dancol.org> <534085B1.9070307@dancol.org> <534176F3.9090205@dancol.org> <5341B573.1010605@dancol.org> <5341C928.6040308@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q0IkkJ69NLfSn9vgIJfxuQcLPKwUpNa7w" X-Trace: ger.gmane.org 1396897649 23431 80.91.229.3 (7 Apr 2014 19:07:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Apr 2014 19:07:29 +0000 (UTC) Cc: Dmitry Antipov , 17168-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 07 21:07:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WXEt6-0004HS-5i for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Apr 2014 21:07:20 +0200 Original-Received: from localhost ([::1]:36246 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXEt5-0005Ro-Kp for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Apr 2014 15:07:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXEsu-0005CV-Ta for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 15:07:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXEsp-0006ML-Kf for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 15:07:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXEsp-0006LK-4q for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 15:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WXEso-0001nZ-FC for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 15:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Apr 2014 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17168 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 17168-done@debbugs.gnu.org id=D17168.13968976066889 (code D ref 17168); Mon, 07 Apr 2014 19:07:02 +0000 Original-Received: (at 17168-done) by debbugs.gnu.org; 7 Apr 2014 19:06:46 +0000 Original-Received: from localhost ([127.0.0.1]:39894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXEsX-0001n2-Ly for submit@debbugs.gnu.org; Mon, 07 Apr 2014 15:06:46 -0400 Original-Received: from dancol.org ([96.126.100.184]:52359) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXEsT-0001ms-Ku for 17168-done@debbugs.gnu.org; Mon, 07 Apr 2014 15:06:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=dI+MbGOv7fam/GuDJJkRzfc0MC0pL256M6nLj2DwJsA=; b=IvjP8dALxcfnYUs8ESxzbzLRLhEwYXOtTRvMbf06Yq0R71+FA5PJAr0mweFHRjVE8pRGyVWuhWG4pJMZ6Ekp15cQkvrn5juOMRC0yY3tvYZ5iLemcYc+38x1ye5rJLBvZHuhlVMhAF4pIYl5KLB8sdLqDKe3Qy2VOvmESdnWrmJOmX7PVJ7q5KzWwalfqraSae35dvTZWz5ovfJIPheLhop5jGsevBhMp78SS6ThHuYWB4/ftsvFAsyR2JIsoruCfeJwHWyEVhlcCPJHuvkR+38YBfoSAOj+rK/aXi4R6quas1ZJ32G4LGBi4G1btSLAwfGJLaSSQNWLAKoOi7QXpg==; Original-Received: from [2601:8:b200:551::2b1] by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1WXEsR-0004c9-38; Mon, 07 Apr 2014 12:06:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 In-Reply-To: X-Enigmail-Version: 1.6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87860 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q0IkkJ69NLfSn9vgIJfxuQcLPKwUpNa7w Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 04/07/2014 09:28 AM, Stefan Monnier wrote: >> Anyway, I'd like to get a fix into emacs-24 soon so we can make sure >> we've fixed the GC bug. >=20 > I installed a fix into emacs-24, which lets all symbols be uninterned. >=20 >> Are you vetoing the general approach used in this patch? >=20 > No: I think disallowing unintern is a good idea, but not for emacs-24. Thanks. I'll install my change in trunk. How should we prevent your change merging into trunk? > Indeed, as it turns out, the only non-pure objects referenced from pure= > space are symbols and distinguishing uninterned from interned reduces > the number of such "pinned" objects from about 10K to about 250. >=20 > Rather than scan all symbols to find the pinned ones, the code > I installed into emacs-24 keeps a pointer to the first symbol_block > that contains a pinned symbol. This way we only scan about 15K symbols= > at the beginning of every GC cycle to mark those 10K pinned symbols. > Compared to keeping a vector of 10K object, this seems like > a good tradeoff. It's unfortunate that we still have to mark Vobarray even though we're separately marking most of the symbols it contains, but I suppose it doesn't matter all that much: because we've already marked most of the symbols in the interned symbol chains, we'll short-circuit in mark_object anyway. --Q0IkkJ69NLfSn9vgIJfxuQcLPKwUpNa7w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTQvc8AAoJEMAaIROpHW7I8NoQAJ+elsXYeG1NlJIoULy1lVbu uQKmbi7Csmz5jSsrZZBWNqtvPKN6qmpD62TB2GU5hEf18+yWkaFnj3IDpUNsy7q5 VGzSTPCg5VQ6ruejWrGSwHdwuQscTz9wP4n64giVTHjUSaGJWCD+cIgrJeAsXaf3 po2W1sjvoa3I962M7LREZ3Ek6kQUh3UJHbtl2I6JM8bWW/2qL8wt93d8HjNjPoV+ 5N3zCVR3Vstj0NmUf5AiFvlYisQP1JnEWw/ziPFaKzPAiMpxT+vYOHKiBpObMWQl dOJbwJm3X61ci4kO+QQieQOg8D/6XZRUx/gF7FQHv2sNv8CNY7p7puMc6E0oVIAC s6t7Fn330klEuoAOw7UMo7z6MsFMyavDxAjNVP+0hS15PUm3OziXbG3AYoJ42HiV GtPc+c25rv6d0NOY8s7WNw10lCdHy7/0CDG9ZwRgkYzEvjnLoYZOeoD8VGHutXSm 6eqxCmutGDgcfuip3FUSTUtWXeI+VR2T0/cHXUNfIi1I09677P0WvwnBjeaqsIUl 0Z+mNAjRtljD1y8JmwLYjJiXPzbXiH81Z7DAQJe8VGHaAIslyXmG5wc0YeZwKveR n+Uh+beewg/yVhUGI5iih7CxH/d+T1Pq16uukwitfgKWcYxJv8GGOVaCCGXmD0Yg NjJ65rWByAAqg4D9+IN3 =2mA3 -----END PGP SIGNATURE----- --Q0IkkJ69NLfSn9vgIJfxuQcLPKwUpNa7w--