From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#17168: 24.3.50; Segfault at mark_object Date: Sun, 06 Apr 2014 11:10:38 -0700 Message-ID: <5341989E.7050509@dancol.org> References: <87y4zop44m.fsf@yahoo.fr> <533C3AF5.6070502@yandex.ru> <533C6905.9060309@dancol.org> <83bnwjbh8v.fsf@gnu.org> <533C75A6.60900@dancol.org> <533D06E6.2060001@yandex.ru> <533D07EF.1040502@yandex.ru> <533D13E2.3060300@dancol.org> <533D251E.3030108@dancol.org> <533D6A19.8050504@yandex.ru> <533D9099.3000104@dancol.org> <533D9F2C.7030500@yandex.ru> <533D9FBB.2050803@dancol.org> <533DB4F0.20706@dancol.org> <534085B1.9070307@dancol.org> <5340E09D.9020709@yandex.ru> <5340E1F1.1050909@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BMW5axVSggsSvTHQpMG6d7I7e4vMgsQ5U" X-Trace: ger.gmane.org 1396807884 28452 80.91.229.3 (6 Apr 2014 18:11:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Apr 2014 18:11:24 +0000 (UTC) Cc: dmantipov@yandex.ru, 17168@debbugs.gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 06 20:11:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WWrXJ-0003ND-3p for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Apr 2014 20:11:17 +0200 Original-Received: from localhost ([::1]:58878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWrXI-0004SX-JT for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Apr 2014 14:11:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWrXA-0004SQ-Ct for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 14:11:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWrX5-00009o-30 for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 14:11:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWrX4-00009i-Vr for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 14:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WWrX4-0007Up-4M for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 14:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Apr 2014 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17168 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 17168-submit@debbugs.gnu.org id=B17168.139680784628788 (code B ref 17168); Sun, 06 Apr 2014 18:11:02 +0000 Original-Received: (at 17168) by debbugs.gnu.org; 6 Apr 2014 18:10:46 +0000 Original-Received: from localhost ([127.0.0.1]:38319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWrWn-0007UD-Nv for submit@debbugs.gnu.org; Sun, 06 Apr 2014 14:10:46 -0400 Original-Received: from dancol.org ([96.126.100.184]:45645) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWrWk-0007U1-Qd for 17168@debbugs.gnu.org; Sun, 06 Apr 2014 14:10:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=Qk4oq+ClfBuAdla1Lt6tj3Z8YFA4y2momqrM2at8SzE=; b=d88kJiZZzbTmclFPJbRbc5fDZHZ8CZr4jWb2xMOfGwqyJISU/LwndW71YjqHBXz3UKgG5eQhKB/BL9PJU1tiNC0admxh0AbBoEp7CXzUjbR0zZWOR1JZv6vzFKS4uPe84p7f1IZ6SQHa4fqmA8JTfCnKBSuplgZYiFugHFLpEfs+AvHAGkSumuQYZZbq+GhD3E5SIPnOAcsa/jCzXMZIWM9L3OCY6Mvbgj8Dha7tlZeQFSXEedQuuZOOm/wN1E/dA3Z6ij/PEH+f14KZJ7SRQX2E3rLSrte0UUQWbPpXn7UtYO43OVT+kZAJ3tQKQpWud4/krN/svEgoO2Lh4ajtQQ==; Original-Received: from [2601:8:b200:551::2b1] by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1WWrWh-0005sD-MX; Sun, 06 Apr 2014 11:10:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 In-Reply-To: X-Enigmail-Version: 1.6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87820 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BMW5axVSggsSvTHQpMG6d7I7e4vMgsQ5U Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 04/06/2014 11:00 AM, Richard Stallman wrote: > You accumulate a list of uninterned symbols whose names are pure. Why > make this into a hash table=20 To eliminate duplicates, of which there would otherwise be many. > and then a vector? =20 Because that's the best structure to fit in pure storage: the set of needed symbols never changes, so why *not* turn it into a vector? > A list should suffice. No, it really doesn't. > Or maybe some (or even all) uninterned symbols with pure string names > should be freed like all other symbols when not pointed to.=20 And how do you tell whether they're pointed to without marking the pointing objects? If you try to mark objects in pure storage, you defeat the whole point. This change is *exactly* what you need to decide whether something points to a given symbol. > check whether the name is pure. Absolutely not: that's what got us into this mess in the first place. The purify of a symbol's name should have no bearing on how we treat that symbol. What matters is whether pure storage refers to an object; the some of these objects are symbols with pure names is irrelevant. Please, stop talking about the problem in terms of "symbols whose names are pure". Can everyone please stop bikeshedding this? Please read and review the actual patch instead of suggesting non-solutions. The actual approach is the simplest general approach that will preserve existing performance characteristics. The only viable equally simple approach is simply removing pure storage, and if pure storage works (it amounts to a primitive kind of generational GC), we might as well keep it. --BMW5axVSggsSvTHQpMG6d7I7e4vMgsQ5U Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTQZieAAoJEMAaIROpHW7ISyUP/2x9+PUXcOOkj1sIgFMwJDW+ NLtRaikPVWNJI7Y1+urAZoIf7yd0dHNuUTEMUue29a5myM10H9Ug9Joy6Z9q5gN9 nDrcJ+ueN+0o5IojazZC4QbhI3/ZU8GPqOWAZ534nEb9+WLMaKSwXUYj+v6XO1nB lxtfXNmt3ngn07CkQh7TOqxcxGCRDXEXrilUB0v7E6CNWsWnH9yEhxGExEL54G8o hHplRHc6vpE9pkCDZU7yn/Flk2y8alPboNDgjvBVehopkslz58KcwuQhUP5Loi56 s+vRRPTwfWCroIGlzIJ93ZD4d2EsM2CHJFXvZykkgay/gOUM9+v4+mSPpH7uB4O4 unhnw4kD3AAGJ21bwKgd/iqI/xyn3/4Pu5HuPLRFBI8ZF0rcGwcadklg9SnGG3DY C11aixw0lY8XqicBdxhd+OYwVibGyMvcfDVz1S0i94lj1Wbs9eXe1SlmEGDM4i+T WMje96ihSDOwZ0VRKxxnZac1/oQjoKVnhBZJ7ERELbP2SazrzBGZIZY85oMgg90X pyOhFDMmj56WkKeQ+c/TbdsjRk6mHKMASB2of2bffJFPBb5N1KB8dr5lPI1+i6uV 4nISmbo9ZCFLc2Tbzl0zEdoGzU4rK5wNx4w3zsgQpUZrIOKnAcBGX5RLo8e4RcGw nmnO8ixRQLqz2kPrMlLS =Bjq3 -----END PGP SIGNATURE----- --BMW5axVSggsSvTHQpMG6d7I7e4vMgsQ5U--