From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#17168: 24.3.50; Segfault at mark_object Date: Sun, 06 Apr 2014 08:46:59 -0700 Message-ID: <534176F3.9090205@dancol.org> References: <87y4zop44m.fsf@yahoo.fr> <533C3AF5.6070502@yandex.ru> <533C6905.9060309@dancol.org> <83bnwjbh8v.fsf@gnu.org> <533C75A6.60900@dancol.org> <533D06E6.2060001@yandex.ru> <533D07EF.1040502@yandex.ru> <533D13E2.3060300@dancol.org> <533D251E.3030108@dancol.org> <533D6A19.8050504@yandex.ru> <533D9099.3000104@dancol.org> <533D9F2C.7030500@yandex.ru> <533D9FBB.2050803@dancol.org> <533DB4F0.20706@dancol.org> <534085B1.9070307@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a4thcDol7nCJnAdIAxwGofuAhaQXcDHrR" X-Trace: ger.gmane.org 1396799304 16051 80.91.229.3 (6 Apr 2014 15:48:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Apr 2014 15:48:24 +0000 (UTC) Cc: Dmitry Antipov , 17168@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 06 17:48:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WWpIu-0003NS-Pu for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Apr 2014 17:48:17 +0200 Original-Received: from localhost ([::1]:58452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWpIu-00039j-Cy for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Apr 2014 11:48:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWpIl-00039b-P8 for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 11:48:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWpIg-0003Zy-Gg for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 11:48:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWpIg-0003Zt-8j for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 11:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WWpIf-0002TY-Qq for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 11:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Apr 2014 15:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17168 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 17168-submit@debbugs.gnu.org id=B17168.13967992279428 (code B ref 17168); Sun, 06 Apr 2014 15:48:01 +0000 Original-Received: (at 17168) by debbugs.gnu.org; 6 Apr 2014 15:47:07 +0000 Original-Received: from localhost ([127.0.0.1]:38223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWpHn-0002Rz-1V for submit@debbugs.gnu.org; Sun, 06 Apr 2014 11:47:07 -0400 Original-Received: from dancol.org ([96.126.100.184]:44998) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWpHk-0002Rq-7q for 17168@debbugs.gnu.org; Sun, 06 Apr 2014 11:47:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=VFW+AyH/aL9TiTPcAaVV4RzDUU0BSEpkriayv9E5Cdw=; b=Wph63hKzE1erdeS6VoaCtO6ZQHmcTJV6duTM3siJiw5TBTIv8MD4plqEb7XKCpc2zrp3kTezphEgCuSCrmxAd64KWad/CG5jPs+N3xBIWSHQDrSxXcTYfpqCuPM6Lov9YXaIIPQ269leYXcUlsrSjO/MGurMYYQyJwjKXsd2qMhKUgbUyL7brzx2uW8JzsfG+Rz5OFUdHkOt5dizsuTOT/2CfAxJPRbfLla3dhDKZY7zYrlnsy0T6RkPzLh4Ur1O4Aqh3T3HHk6tFsWkT871NVyOTDAEF9Kc2ad7wKT9JK5Jtx655XV50mcY/cW3ls9i8dWieQZLTTXTVUemU5SyDw==; Original-Received: from [2601:8:b200:551::2b1] by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1WWpHh-0005Iz-Gg; Sun, 06 Apr 2014 08:47:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 In-Reply-To: X-Enigmail-Version: 1.6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87805 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --a4thcDol7nCJnAdIAxwGofuAhaQXcDHrR Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 04/06/2014 05:36 AM, Stefan Monnier wrote: >> This scheme works and passes Dmitry's test, but the resulting >> Vpure_reachable vector has over 8,000 items. Most of these items are >> ordinary interned symbols. >=20 > What objects are there besides symbols in Vpure_reachable? Just symbols for me. > If we can reduce Vpure_reachable to only contain symbols, then we can > replace it with a `pinned' bit in the Lisp_Symbol struct and then walk > the list of symbols during mark, marking all those symbols with the > `pinned' bit. The pinned bit approach is exactly what I implemented, except that we walk obarray, like we already do, instead of all symbols. Your approach would require that we check for non-symbols in purecopy and reject them, and it'd have a bigger performance impact, since we'd then need to walk the entire symbol list essentially twice. I'd strongly prefer the fully general approach in my patch. It isn't *that* complicated. --a4thcDol7nCJnAdIAxwGofuAhaQXcDHrR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTQXbzAAoJEMAaIROpHW7IfuAP/25MskUBoyNNJ91h94AmuTYG BbQh2ny+GhYmLJJN0ejQwL09G6qFSyqgFa5bvS+NC0UdHzLsx9Z7jy4B0YSR5KOD iNQqs2NEjKlO2z3nAkcEblvGnKecFLlAAN8UnJbD2iBtzjKImGTt5NgmTzKdHLi1 21eWtH+hisEnA9Gb9V64l4zXTplfqvIyRi3d8mRNR/t5wmvOoXqD566PNIJ58GTH ospd6fVl1pLnm7WAnSR0egNjHARVMkdOOnKF7Odkr0SdIQ32W6k+0CuAc8eNM1ap jwOJ7sZU5g9zFM3Sb7YGv7v6Gj5dAEDks/YZHjTGWlynJ9MA2EdlXWFV9z7Sb5CG T4Ni1YfD0SdrlsiOE0lr5GTgn7IlINP25x1YDV76/pR4rrpaIFqYm+0U1kP9leLN 4rqhx1PCyQgVnQn6D2ncoidJ6VmtYj1Bk3ewVptubZlqIzOCYFXXMhqP9SMceiNx Dl76kKCnJcNW5uY1HA9qjsa7NfX9p16hqJUhU54oYm1bnTWVqJwOoqhhiRp5ZlLo LUQF8Ro2VZotfoL+TekDbF+oKec3dWJwtEED+i47bogF7DHRW5bydKlRFIExhW/Z 1SJk+B5Wbe+XLdlUpv67vbUREE63w8SZvpNi8Pkte01UU1tSF6E0LVlMN8jIRBNg nw+riAVu7QgJpFzw27zO =rqC0 -----END PGP SIGNATURE----- --a4thcDol7nCJnAdIAxwGofuAhaQXcDHrR--