From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#17187: 24.3.50.1 open-dribble-file stores pw Date: Sat, 05 Apr 2014 16:14:19 -0700 Message-ID: <53408E4B.9060605@dancol.org> References: <533EED70.9090709@easy-emacs.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hiSa4j7newOwqDQCmTw2W07R4jmRweu2S" X-Trace: ger.gmane.org 1396739726 12925 80.91.229.3 (5 Apr 2014 23:15:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Apr 2014 23:15:26 +0000 (UTC) Cc: 17187@debbugs.gnu.org To: Glenn Morris , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 06 01:15:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WWZnx-0008Ht-1O for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Apr 2014 01:15:17 +0200 Original-Received: from localhost ([::1]:56112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWZnw-0008Vl-JP for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Apr 2014 19:15:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWZno-0008JS-GM for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 19:15:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWZnj-0002zG-9S for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 19:15:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWZnj-0002yf-6j for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 19:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WWZni-00032T-G2 for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 19:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Apr 2014 23:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17187 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17187-submit@debbugs.gnu.org id=B17187.139673966611617 (code B ref 17187); Sat, 05 Apr 2014 23:15:02 +0000 Original-Received: (at 17187) by debbugs.gnu.org; 5 Apr 2014 23:14:26 +0000 Original-Received: from localhost ([127.0.0.1]:37164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWZn7-00031I-Vz for submit@debbugs.gnu.org; Sat, 05 Apr 2014 19:14:26 -0400 Original-Received: from dancol.org ([96.126.100.184]:39608) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWZn4-000319-D0 for 17187@debbugs.gnu.org; Sat, 05 Apr 2014 19:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=6OsXvMcoxhSqftuFIhpK/Z81n9PLn+7/jFMC5YpfwxU=; b=kd0rmHxEBi1svtv56cB+oWvZRa4ICuLPnfZa0nNFrQaVUOt3tpBz9NOdll/aRuP0U1KByfqJebZQpVpeExl56juwpLzCG2fZDAMd2NS8MXK6azDYD8/lsRK9ObR/vmXi8Mldpm5fT/8qH5PamXYSO2ox4QqOTW9yBeHLfLDXwXilW41zUVEPtqg/FUBH83uZElnT4chJ9VgmS0FgBuHd3LKdAAGlYdjwJ1abjM1zwHVbqvY0b5CoTawR2SBVT0UvHu/5A2xBGqZmOkxtuwDWE4ejYW81kPB5gMcZeZjKyttqqsR0ic79ivPrgFvqIKtb7Koqc2/7KEjldlFJ+XThnQ==; Original-Received: from [2601:8:b200:551::2b1] by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1WWZn2-0001CL-9a; Sat, 05 Apr 2014 16:14:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 In-Reply-To: X-Enigmail-Version: 1.6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87785 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hiSa4j7newOwqDQCmTw2W07R4jmRweu2S Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 04/05/2014 04:01 PM, Glenn Morris wrote: > *************** > *** 10085,10092 **** > } > if (!NILP (file)) > { > file =3D Fexpand_file_name (file, Qnil); > ! dribble =3D emacs_fopen (SSDATA (file), "w"); > if (dribble =3D=3D 0) > report_file_error ("Opening dribble", file); > } > --- 10086,10100 ---- > } > if (!NILP (file)) > { > + int fd; > file =3D Fexpand_file_name (file, Qnil); > ! if (! NILP (Ffile_exists_p (file))) > ! { > ! if (chmod (SSDATA (file), 0600) < 0) > ! report_file_error ("Doing chmod", file); > ! } > ! fd =3D emacs_open (SSDATA (file), O_WRONLY | O_CREAT | O_TRUNC,= 0600); > ! dribble =3D fd < 0 ? 0 : fdopen (fd, "w"); > if (dribble =3D=3D 0) That's racy. What about using fchmod and falling back to post-open chmod for systems that don't have fchmod? --hiSa4j7newOwqDQCmTw2W07R4jmRweu2S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTQI5LAAoJEMAaIROpHW7IlTIP/0SXjfl2wV0ljPvSMYxU2d9F WPJafH0riQdZsm4HLxTAM2J/bvTrtRHcJaqxtaMjWNmGAZgPrKYy7BWrvjJHVHw8 COGIOIEVaUuuhjYe6hk73AEh5DEPmwuDgjVk7C1BIZMwFqP8ebcmDab2zqy61BUM MirOg3PM457su+9aLogiBOjO+hPwQ/+72yfgOQWi+6CWf9Q1HIsO3aVOeH3+ZXTl m01cdpLZK8bUUz+hlE1rs29lBGHWwDL8MKjI6p+W9Ax8d8dinztsXi2RpBQVMXTG M/eDLMGXJDogEKlLdcseGXqqCHFJJ24228QYlVL7vOPu9H16EmsvnDi13/NC7p1N eJNSRlmynXUlXTJZlBXExroMepzVqIrErIPmCNYnqIs7T2B4H52f2mOIdJZx08gP qeRXG2XTlDtrvjlWSSm1TuoO76OSYByTJMVXuLUR+US5UKqmMbvZLqKboZorvV71 HUeCbGt2RnPXIGtsdWveVqE3lHz6H8CPiIsemc2VpXxNMxchZKKAMQdV817R9S4h 2D77xDMBg4HW3yKPZJUQLLh6CMG9uiiu0Bv8fxg8ljhjRi437JVbTJzt73Vgf3Ae RJljpzdW//+rDHCQyk5d6cfpGb15suuAbrKt7iHhJKg5qhE9pLB0AOxI0BIoZVgx 55J5Xrfuv8ySbGFP4rPJ =RFot -----END PGP SIGNATURE----- --hiSa4j7newOwqDQCmTw2W07R4jmRweu2S--