From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.bugs Subject: bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled Date: Sat, 29 Mar 2014 18:52:45 +0100 Message-ID: <5337086D.2050708@swipnet.se> References: <801316EE-F452-4A27-8104-5BB4FA7BEE31@univie.ac.at> <5336BD71.6040105@swipnet.se> <83fvm1duy8.fsf@gnu.org> <5336C794.4000203@swipnet.se> <83bnwpdtrn.fsf@gnu.org> <5336F4BA.6070302@swipnet.se> <8338i1djbn.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1396115602 23812 80.91.229.3 (29 Mar 2014 17:53:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Mar 2014 17:53:22 +0000 (UTC) Cc: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 29 18:53:15 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WTxRT-0004mE-6e for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Mar 2014 18:53:15 +0100 Original-Received: from localhost ([::1]:40401 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTxRS-0001aa-SU for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Mar 2014 13:53:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTxRL-0001aG-1D for bug-gnu-emacs@gnu.org; Sat, 29 Mar 2014 13:53:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTxRG-0005o3-AT for bug-gnu-emacs@gnu.org; Sat, 29 Mar 2014 13:53:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTxRG-0005ny-6m for bug-gnu-emacs@gnu.org; Sat, 29 Mar 2014 13:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WTxRF-000156-Ri for bug-gnu-emacs@gnu.org; Sat, 29 Mar 2014 13:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Jan D." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Mar 2014 17:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16976-submit@debbugs.gnu.org id=B16976.13961155714137 (code B ref 16976); Sat, 29 Mar 2014 17:53:01 +0000 Original-Received: (at 16976) by debbugs.gnu.org; 29 Mar 2014 17:52:51 +0000 Original-Received: from localhost ([127.0.0.1]:56362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WTxR3-00014b-Pu for submit@debbugs.gnu.org; Sat, 29 Mar 2014 13:52:50 -0400 Original-Received: from mailfe09.tele2.se ([212.247.155.1]:45127 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WTxQz-00014J-Vy for 16976@debbugs.gnu.org; Sat, 29 Mar 2014 13:52:47 -0400 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe09.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 315390651; Sat, 29 Mar 2014 18:52:43 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 In-Reply-To: <8338i1djbn.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87535 Archived-At: Hello. Eli Zaretskii skrev 2014-03-29 18:07: >> Date: Sat, 29 Mar 2014 17:28:42 +0100 >> From: "Jan D." >> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org >> >> Eli Zaretskii skrev 2014-03-29 14:22: >>>> Date: Sat, 29 Mar 2014 14:16:04 +0100 >>>> From: Jan Djärv >>>> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org >>>> >>>> I made SET_FRAME_GARBAGED a no-op, it still does a double redraw. >>> >>> Do you see 2 consecutive calls to update_window_tree? >>> >> >> Well, it is difficult to tell as this function is called on mouse >> movement and on every key stroke and on every blink of the cursor. >> But turning off blink cursor, and testing with and without toolbar gives >> 3 calls. > > Maybe I'm missing something here, so let me take a step back. You > said earlier that you see the frame cleared and redrawn. I'm asking > if you can trace this clearing and redrawing to any of the calls to > update_frame or update_window_tree. > It seems the clearing is done because of an expose. If we don't have a toolbar, NS thinks the frame is up to date when the event loop is entered after the first redisplay is done. But if we have a toolbar NS thinks the frame is out of date and needs redrawing, thus sending an expose event (well, drawRect in NS speek) that does not happen without the toolbar. So the clearing is already done when Emacs code is entered. I don't know why we did not get this expose before, but much has happened, i.e. pixelwise resizing, event loop changes and more. Maybe the generic code changed, because update_frame_tool_bar is called four times when a new frame is created. NS does not have an "up-to-date" check on the toolbar, so it just recreates it. This may be the cause. Jan D.