From: "Jan D." <jan.h.d@swipnet.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
Subject: bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled
Date: Sat, 29 Mar 2014 18:52:45 +0100 [thread overview]
Message-ID: <5337086D.2050708@swipnet.se> (raw)
In-Reply-To: <8338i1djbn.fsf@gnu.org>
Hello.
Eli Zaretskii skrev 2014-03-29 18:07:
>> Date: Sat, 29 Mar 2014 17:28:42 +0100
>> From: "Jan D." <jan.h.d@swipnet.se>
>> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
>>
>> Eli Zaretskii skrev 2014-03-29 14:22:
>>>> Date: Sat, 29 Mar 2014 14:16:04 +0100
>>>> From: Jan Djärv <jan.h.d@swipnet.se>
>>>> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
>>>>
>>>> I made SET_FRAME_GARBAGED a no-op, it still does a double redraw.
>>>
>>> Do you see 2 consecutive calls to update_window_tree?
>>>
>>
>> Well, it is difficult to tell as this function is called on mouse
>> movement and on every key stroke and on every blink of the cursor.
>> But turning off blink cursor, and testing with and without toolbar gives
>> 3 calls.
>
> Maybe I'm missing something here, so let me take a step back. You
> said earlier that you see the frame cleared and redrawn. I'm asking
> if you can trace this clearing and redrawing to any of the calls to
> update_frame or update_window_tree.
>
It seems the clearing is done because of an expose.
If we don't have a toolbar, NS thinks the frame is up to date when the
event loop is entered after the first redisplay is done.
But if we have a toolbar NS thinks the frame is out of date and needs
redrawing, thus sending an expose event (well, drawRect in NS speek)
that does not happen without the toolbar. So the clearing is already
done when Emacs code is entered.
I don't know why we did not get this expose before, but much has
happened, i.e. pixelwise resizing, event loop changes and more.
Maybe the generic code changed, because update_frame_tool_bar is called
four times when a new frame is created. NS does not have an
"up-to-date" check on the toolbar, so it just recreates it. This may be
the cause.
Jan D.
next prev parent reply other threads:[~2014-03-29 17:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 19:12 bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled Konrad Podczeck
[not found] ` <5336BD71.6040105@swipnet.se>
2014-03-29 12:56 ` Eli Zaretskii
2014-03-29 13:16 ` Jan Djärv
2014-03-29 13:22 ` Eli Zaretskii
[not found] ` <7761f1b97fd0e679a65e8d5629419ded@univie.ac.at>
2014-03-29 15:08 ` Eli Zaretskii
2014-03-29 16:02 ` Konrad Podczeck
2014-03-29 16:05 ` Konrad Podczeck
2014-03-29 16:13 ` Eli Zaretskii
2014-03-29 16:58 ` Jan D.
2014-03-29 16:28 ` Jan D.
2014-03-29 17:07 ` Eli Zaretskii
2014-03-29 17:52 ` Jan D. [this message]
2014-03-29 19:42 ` Eli Zaretskii
2014-03-30 17:22 ` Jan D.
2014-03-31 2:14 ` Darren Hoo
2014-03-31 6:21 ` Jan D.
2014-03-31 17:39 ` Konrad Podczeck
2014-03-31 17:51 ` Glenn Morris
2014-04-02 10:10 ` Jan Djärv
2014-04-05 8:06 ` Jan D.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5337086D.2050708@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=16976@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=konrad.podczeck@univie.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).