From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Wed, 19 Dec 2018 02:48:58 +0200 Message-ID: <532bc1dc-1b44-dc3a-23f0-f96e6d586123@yandex.ru> References: <878t18j4is.fsf@mail.linkov.net> <83a7lobemr.fsf@gnu.org> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1545180494 15414 195.159.176.226 (19 Dec 2018 00:48:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Dec 2018 00:48:14 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Thunderbird/64.0 Cc: 33567@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 19 01:48:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZQ1u-0003pC-0A for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2018 01:48:06 +0100 Original-Received: from localhost ([::1]:57119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZQ40-0007x6-BC for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Dec 2018 19:50:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZQ3u-0007ww-0h for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 19:50:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZQ3o-00073e-Of for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 19:50:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49635) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZQ3m-0006y7-7J for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 19:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZQ3l-0006YT-VV for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 19:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2018 00:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154518054925118 (code B ref 33567); Wed, 19 Dec 2018 00:50:01 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 19 Dec 2018 00:49:09 +0000 Original-Received: from localhost ([127.0.0.1]:53893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZQ2v-0006X3-Gl for submit@debbugs.gnu.org; Tue, 18 Dec 2018 19:49:09 -0500 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:50611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZQ2t-0006Wo-IZ for 33567@debbugs.gnu.org; Tue, 18 Dec 2018 19:49:07 -0500 Original-Received: by mail-wm1-f46.google.com with SMTP id n190so4431473wmd.0 for <33567@debbugs.gnu.org>; Tue, 18 Dec 2018 16:49:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ODuJIZuYaAnHFpysmZg5CDCwcsM+43VxO2O6eO6Fwxo=; b=hsc84AIRFUt23U4CyPqMJ/qWrPr0nW42No3zZRqIbmz6th8AZjvV4Asiy4XnTMXe0g mY7CRaQAYz1eKfdhWsOC9e8NMMO7QAOBzBMLANOaJOygH2HRjXLo9lQAQsDtiWMq44Dw +layWIZnRO/V8kYKDj1mngXtNR7QOv8gVTq8sJogG5BeoS4jAPGphk/q4OV0iJ7491hP bZnOuhbG9fAIIq8d5hC5NH2pHS82sb08zDi9jFBcw1loEbvx8Zj+GchLVCUq4/Iv/6Wo 7rVTybPF5b9fIZf5esEZUaEgPjZkkTBs1+irgji5pGnlKo0BC1kiqAOh5YGykgFqftur uHXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ODuJIZuYaAnHFpysmZg5CDCwcsM+43VxO2O6eO6Fwxo=; b=YAmbKT/0iCoJYha2voHKGMwiNlDmY21w0HL5YfgL2AEO/0JE6XXr4Q4vFhV9VAJ7vh x2q5tynfqHCur2KFh5jE/JEByljleSjQWld6+zqv14cHTN1HqpaKsYCoAYgusteCgEX/ R6HHKlGOez/st+v9FgD9c0mqM6wpqrAKzpZpPgRCDTBTwxKekep3Ahehvoomh/10Wr+/ +/rAVUlnE5kupPd6zsVoSz0ZquqkfHjowpe8tMC0McNn8n+q7KKtmsG3VGuk3Hdebw9n Kl8lrjiAw3xnrLdTS1R+k7drnHzpAvdmuf57/7JAX97cBcY+3ahWiQGp9iXGZHvLBUBH zmoQ== X-Gm-Message-State: AA+aEWb9urrz8rdkqUZMdjik5ocIVyFwCyjbrzhuQW84oWbHVjKgIJRT Riy6kIHhhcwpHe0NNefFuNIDoOg/ X-Google-Smtp-Source: AFSGD/VpSPAEY8rz/KTskx1k+hMWZ3i3PURqxSW4MxDhk2ZWQNWfKzfvbTpRYGKxVYPeBr05JB/uXg== X-Received: by 2002:a1c:c008:: with SMTP id q8mr4608683wmf.99.1545180541359; Tue, 18 Dec 2018 16:49:01 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id c7sm7017734wre.64.2018.12.18.16.48.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Dec 2018 16:49:00 -0800 (PST) In-Reply-To: <87d0pyxtnc.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153588 Archived-At: On 19.12.2018 2:11, Juri Linkov wrote: > Does it help to remove foreground colors from diff-added and diff-removed? Yup. Except if I customize those and restart, I think the +'s and -'s on the left will become black as well, which is somewhat of a loss. So the colors might need to be moved to other definitions, e.g. diff-indicator-added. Further, I'm not sure if we should do the same to the look of the diff-mode buffers when diff-font-lock-syntax is nil. Just something to consider. Third, third-party code might rely on those faces looking as they do now. E.g. in diff-hl, diff-hl-insert inherits from diff-added, although this package likely won't be affected by this change (the faces define their own :foreground, for reasons lost to history). > Neither GitHub nor GitLab have foreground green/red colors, only background > green/red colors. Those are the interfaces that built up my expectations as well.