From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#16901: 24.3.50; emacs_backtrace.txt Date: Mon, 03 Mar 2014 18:20:09 -0500 Message-ID: <53150E29.7080504@cornell.edu> References: <831tylvkq2.fsf@gnu.org> <83lhwstu1k.fsf@gnu.org> <83ppm3rznz.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1393888817 14933 80.91.229.3 (3 Mar 2014 23:20:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Mar 2014 23:20:17 +0000 (UTC) Cc: 16901@debbugs.gnu.org, dmantipov@yandex.ru To: Eli Zaretskii , lekktu@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 04 00:20:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WKc9p-0001LE-8J for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Mar 2014 00:20:25 +0100 Original-Received: from localhost ([::1]:42072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKc9o-00085U-Qw for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Mar 2014 18:20:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKc9e-0007ph-OK for bug-gnu-emacs@gnu.org; Mon, 03 Mar 2014 18:20:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKc9U-00067y-5v for bug-gnu-emacs@gnu.org; Mon, 03 Mar 2014 18:20:14 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKc9U-00065d-3A for bug-gnu-emacs@gnu.org; Mon, 03 Mar 2014 18:20:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WKc9T-0000wy-8o for bug-gnu-emacs@gnu.org; Mon, 03 Mar 2014 18:20:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Mar 2014 23:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16901 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 16901-submit@debbugs.gnu.org id=B16901.13938887993636 (code B ref 16901); Mon, 03 Mar 2014 23:20:03 +0000 Original-Received: (at 16901) by debbugs.gnu.org; 3 Mar 2014 23:19:59 +0000 Original-Received: from localhost ([127.0.0.1]:49489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WKc9O-0000wZ-W2 for submit@debbugs.gnu.org; Mon, 03 Mar 2014 18:19:59 -0500 Original-Received: from limerock01.mail.cornell.edu ([128.84.12.99]:38853) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WKc9L-0000wP-Pp for 16901@debbugs.gnu.org; Mon, 03 Mar 2014 18:19:56 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s23NJsNe005343; Mon, 3 Mar 2014 18:19:55 -0500 Original-Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s23NJqAr001138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 3 Mar 2014 18:19:54 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 In-Reply-To: <83ppm3rznz.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86513 Archived-At: On 3/3/2014 11:54 AM, Eli Zaretskii wrote: > P.S. The bugs in gmalloc were so glaring that I'd appreciate if > someone could eyeball my changes, in case I grossly misunderstood the > code. When I see such bugs in such veteran code, I usually question > my own sanity. TIA. I may be misunderstanding the code too, but I don't think your fix to aligned_alloc is quite right. If adj == 0 in line 1596, then we've allocated much more memory than we needed, and the next call to malloc (line 1602) allocates even more. And if adj == 1 in line 1596, then we've allocated exactly as much memory as we needed, so there's no need to call malloc again in line 1602. Ken