From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command Date: Thu, 06 May 2021 13:50:48 +0000 Message-ID: <531453ddd615858f272b@heytings.org> References: <24706.50397.801563.461736@capuchin.co.uk> <8fdeca1f-7d34-c95a-0f2d-5550dea34512@gmx.at> <242e45b6-6dee-c85a-2ac8-67b2adeb93b5@gmx.at> <838s4w6mua.fsf@gnu.org> <83y2cv6773.fsf@gnu.org> <1a73bd6c69efd6282e57@heytings.org> <83bl9q676g.fsf@gnu.org> <1a73bd6c69e27aed1fbd@heytings.org> <83y2cu4p0g.fsf@gnu.org> <1a73bd6c6998b2e086fc@heytings.org> <83tuni4mwi.fsf@gnu.org> <1a73bd6c69c2cc8827d5@heytings.org> <83r1im4jct.fsf@gnu.org> <83tunh2xlv.fsf@gnu.org> <83zgx8e15p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13951"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47969@debbugs.gnu.org, robert@capuchin.co.uk To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 15:52:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leeQS-0003Wo-34 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 15:52:24 +0200 Original-Received: from localhost ([::1]:33022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leeQQ-0007FJ-Qb for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 09:52:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leeP8-0006Mr-Au for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 09:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leeP8-0007Cc-2D for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 09:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leeP8-0000rE-0L for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 09:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 13:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47969 X-GNU-PR-Package: emacs Original-Received: via spool by 47969-submit@debbugs.gnu.org id=B47969.16203090513285 (code B ref 47969); Thu, 06 May 2021 13:51:01 +0000 Original-Received: (at 47969) by debbugs.gnu.org; 6 May 2021 13:50:51 +0000 Original-Received: from localhost ([127.0.0.1]:37569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leeOx-0000qv-54 for submit@debbugs.gnu.org; Thu, 06 May 2021 09:50:51 -0400 Original-Received: from heytings.org ([95.142.160.155]:40284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leeOv-0000qp-W7 for 47969@debbugs.gnu.org; Thu, 06 May 2021 09:50:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620309048; bh=XEyQ2+D/g2FlQBT6O57RlirMJfkf+NinUMlXPy/lVqE=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=KuUJYQonhFawrBv+6MiKsKWfm/g10EHA6sJx+0/A2x48J6OVlSXvWK1IBRyqX60h5 JKiF2HwU22d8sniSIjxmpj57DvhzcfGvbw4YXAoiqvbEj2nDeGPerOHqIbBIyQ1E1Z AIzAJW6Nkae9V4hLjZgMhGCx1ZKSGtEWBYmiRTbNeM9myRYpdYhQEL+S83K4hODSh3 0S9GasvGdSMXaGHW9x9EKoMATBWPCRN9ZePBt8SmSROf19JhvwmEl4qfgJKMR4SSmg dCpqPZX2eSMXTSRXu8R++CFeiKUSyIryKrcqP4/njOvJ+NAlC6ECPyAIEOWiK8D2pJ A7ga2WcouZlYw== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205837 Archived-At: >> Stefan, any suggestions or comments? > > No, the thread looks pretty complete. > > I'll just point out that it's OK to revert the change made for Emacs-25, > but at one condition: we need to clearly label the `minibufferp` test > with a comment pointing to this discussion so that if the problem that > commit was intended to fix comes up again, we'll then have more context > to make a better decision. > I have one more comment: the code that was removed from handle-select-window by commit 3fdd3bb56c: ;; Don't switch if we're currently in the minibuffer. ;; This tries to work around problems where the ;; minibuffer gets unselected unexpectedly, and where ;; you then have to move your mouse all the way down to ;; the minibuffer to select it. (window-minibuffer-p) was added by that same commit in xterm.c: /* Don't switch if we're currently in the minibuffer. This tries to work around problems where the minibuffer gets unselected unexpectedly, and where you then have to move your mouse all the way down to the minibuffer to select it. */ && !MINI_WINDOW_P (XWINDOW (selected_window)) but, at least for the recipe of this bug, this code movement does not produce the expected effect. Note also that this condition is not present the corresponding code in nsterm.m and w32term.c.