From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#16897: 24.3.50; vc-print-root-log doesn't show the top commit if it's a merge commit Date: Sat, 01 Mar 2014 08:17:21 +0200 Message-ID: <53117B71.3040200@yandex.ru> References: <87eh2oqvzq.fsf@yandex.ru> <53109BD8.70401@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1393654695 10552 80.91.229.3 (1 Mar 2014 06:18:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Mar 2014 06:18:15 +0000 (UTC) Cc: 16897@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 01 07:18:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WJdFe-0002Wk-4p for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Mar 2014 07:18:22 +0100 Original-Received: from localhost ([::1]:54325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJdFd-0004JP-2F for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Mar 2014 01:18:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJdFS-0004IP-ET for bug-gnu-emacs@gnu.org; Sat, 01 Mar 2014 01:18:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJdFL-0005u4-4i for bug-gnu-emacs@gnu.org; Sat, 01 Mar 2014 01:18:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJdFK-0005ts-Vy for bug-gnu-emacs@gnu.org; Sat, 01 Mar 2014 01:18:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WJdFK-0004BQ-H9 for bug-gnu-emacs@gnu.org; Sat, 01 Mar 2014 01:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Mar 2014 06:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16897 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16897-submit@debbugs.gnu.org id=B16897.139365465116035 (code B ref 16897); Sat, 01 Mar 2014 06:18:02 +0000 Original-Received: (at 16897) by debbugs.gnu.org; 1 Mar 2014 06:17:31 +0000 Original-Received: from localhost ([127.0.0.1]:45182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJdEo-0004AY-R0 for submit@debbugs.gnu.org; Sat, 01 Mar 2014 01:17:31 -0500 Original-Received: from mail-ee0-f48.google.com ([74.125.83.48]:46995) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJdEk-0004AK-CO for 16897@debbugs.gnu.org; Sat, 01 Mar 2014 01:17:27 -0500 Original-Received: by mail-ee0-f48.google.com with SMTP id e51so1638733eek.35 for <16897@debbugs.gnu.org>; Fri, 28 Feb 2014 22:17:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=+4lSFVQmhLM1wuhVLwH0TkhS1dI6He2F9jK4/yntjIU=; b=EZ43uk1RELy6ZNp7mvfYgsaifyOa/IzyOHd7dayXJVXpfV9YJZritwcG7co7ozxxzN AxsFMIn2j7mymhvrE9Rh0JvmbuPq88dim71wxyd5CSUmJpGy5AR9gcz9cWVhOqJ/QCjn CA85Fxr7PvqVTx9FqwF0miUeip4NWZB/Wk3e/Se5GN/LlcDWyuQjxwpqDcDegGvyjsk8 Xpr0nHHH8QVHewvPi+BcOO9bmRIlRSmZB3sY647cQLfhrI7QAcqOVy71gSQf2VmgIPTz 3OgR6iJ3sViujj/68JYkEvM3n/gjjJ+PpD1NCDueEhfHyiQ3wAPYb13AbCGC40ReGMYs AeQA== X-Received: by 10.14.8.194 with SMTP id 42mr25976682eer.16.1393654645359; Fri, 28 Feb 2014 22:17:25 -0800 (PST) Original-Received: from [192.168.10.2] ([93.109.195.252]) by mx.google.com with ESMTPSA id l4sm19453965eeo.9.2014.02.28.22.17.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 28 Feb 2014 22:17:24 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86423 Archived-At: On 28.02.2014 19:24, Stefan Monnier wrote: >>> Yes, something like that is needed for other circumstances as well, >> Do you mean other uses of `vc-git-print-log'? > > No: other circumstances where we pass a list of files to Git. > IOW, maybe vc-git-command should support turning a (list > default-directory) into nil. This sort of assumes that default-directory is always the root dir. Which isn't true. Of course it seems that in practice, whenever file-or-list is the same as (list default-directory), the latter *is* the root dir. But that's a shaky assumption. I'm not sure I want to spend another process call to determine what the actual root dir is each time, so maybe we should limit the fix to `vc-git-print-log'. At least, until any other command is known to exhibit a similar bug.