From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#42966: 28.0.50; vc-dir: wrong backend Date: Sat, 17 Oct 2020 23:44:03 +0300 Message-ID: <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25259"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Sam Steingold , 42966@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 17 22:45:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTt4w-0006TJ-K5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Oct 2020 22:45:26 +0200 Original-Received: from localhost ([::1]:37790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTt4v-0001z9-Di for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Oct 2020 16:45:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTt4Y-0001yl-7g for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 16:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52329) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTt4X-0005uo-U7 for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 16:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTt4X-0006IK-Rs for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 16:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 20:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs Original-Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160296745224126 (code B ref 42966); Sat, 17 Oct 2020 20:45:01 +0000 Original-Received: (at 42966) by debbugs.gnu.org; 17 Oct 2020 20:44:12 +0000 Original-Received: from localhost ([127.0.0.1]:35642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTt3k-0006H4-M9 for submit@debbugs.gnu.org; Sat, 17 Oct 2020 16:44:12 -0400 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:56183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTt3j-0006Gr-2S for 42966@debbugs.gnu.org; Sat, 17 Oct 2020 16:44:11 -0400 Original-Received: by mail-wm1-f42.google.com with SMTP id a72so6655180wme.5 for <42966@debbugs.gnu.org>; Sat, 17 Oct 2020 13:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=p8VPAqrE6kKS8O+TkMjoz9S0JlrabcUmPbJtrE3e43U=; b=q7ZHUykYRuxGfe5IJBNYLXM+g02jRKyTQFONsvAvqx6Y83u+qyW4JSreqxYS0XCFYv CDLKQXV9CQ3EIrCv2WfYonTu9lBcykzBu+d7I8BRVJdPNYqq9jl1ybTcyjH3KWwo14ac lCFTiQTgURWpAuUnF6tOEm+Orxnfld5IaBDA2Qkm5TGWRa8BPKwYWcs4+E7N71N/1nWN YAg/5yc4LYj5sQFuTEaJfWyZU0Sqj3TuHXckQDYCDHVoOKNDBO66xhbv2B+1tVXU+aMJ yzkvFWc4nB50YMzZ1i/HwACfN9Wr4P6xXahUm0Dy2DABu9MokvoX5i1AfHQkOaLK27/Q wO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p8VPAqrE6kKS8O+TkMjoz9S0JlrabcUmPbJtrE3e43U=; b=gKWtBdsGbyybLwFjQCpJBFZkDXYXM3Y23kmHtXosfQ9+yVA3J7P4Uf2izkWjc3DJSM niKP4VpiJ9S//QfgXYtalRP0QIMUbcpM3TNz9+s8G40Fvmcd8FB5SQX9E5L6KlelNuMh 0JdStmcwi7+p6iKXA+5Bd7WeNCtTo2HEhLlL1mK9VKJP6DsxfaS7vbklXb5QDOGrdGDv /4FOEv1zAJRinbtCeXSKrAJdqLiW8RX9i6Ed4tbn+aeS6046Fo60ey4VQqAprxsY8JLN /5z5Hp08dQc+cFizEOErwQsp40GpmQDp7uy40VmNqwt/P4RveW7EWBFJ1gg+jtQzRyKj BW6Q== X-Gm-Message-State: AOAM530rjxE1bb9+rrWVaO8VD9D8pMmUH2RpxW5oey83j4y8Ki/ZsqVR 5X4o4sxPCTLXi1sQVxj3QHm9plqcbAtWOA== X-Google-Smtp-Source: ABdhPJzUiQTMIskM6T1QacYzu2X0h/HPeMZcraelwpFyPwVJyEmdcXOpP2xfTCg1SS/MlyzdMeNGmA== X-Received: by 2002:a7b:c112:: with SMTP id w18mr9681476wmi.62.1602967445231; Sat, 17 Oct 2020 13:44:05 -0700 (PDT) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id v8sm9149324wmb.20.2020.10.17.13.44.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Oct 2020 13:44:04 -0700 (PDT) In-Reply-To: <875z79z5mw.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190836 Archived-At: On 17.10.2020 10:13, Lars Ingebrigtsen wrote: > And here's the benching with the patch applied: > > (benchmark-run 1000 > (vc-responsible-backend "/tmp/git-dir/dir1/dir2/hg-dir/bar")) > => (0.375446369 10 0.07836344099999998) > > (benchmark-run 100 > (vc-responsible-backend "/ssh:stories:/tmp/git-dir/dir1/dir2/hg-dir/bar")) > => (3.485639896 110 1.00616348) > > Er... the local version is now faster? Is a throw expensive, somehow? > Probably not very significant. Is it possible that you didn't restart Emacs between the tests? vc-git-root (at least) does some caching, which muddies the waters. Or try this test, with both versions of code: (benchmark-run 1000 (progn (vc-file-clearprops FILE) (vc-responsible-backend FILE))) > But as expected, the tramp version is slower, because it does more > lookups remotely. But not hugely. By 23%? That's a bit more than I expected just by looking at vc-handled-backends, which has 9 elements. 1/9 => 11%. I don't have a strong opinion on the remote performance, but we might want to ask Michael. Looking at the code, it seems to have forced him to unfortunate measures in the past (such as adding said caching to vc-git-root).