From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sun, 8 Dec 2019 12:39:06 +0200 Message-ID: <52b437d6-cbee-cea9-71c8-2a39311e602c@yandex.ru> References: <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <83ftiasfdm.fsf@gnu.org> <83lfrulmva.fsf@gnu.org> <76a012f5-8cdd-75d5-322e-a453a612c655@yandex.ru> <83immxjs6q.fsf@gnu.org> <993b2f9c-6052-e791-3d3b-26d5fedd7d12@yandex.ru> <835ziuixke.fsf@gnu.org> <9c4768a5-ecce-68ce-c612-a001b2f6784d@yandex.ru> <8336dxh1ge.fsf@gnu.org> <6c68ceed-156c-a6f2-bf0f-21d7e9eb5692@yandex.ru> <831rthgy3u.fsf@gnu.org> <83o8wkfu63.fsf@gnu.org> <83r21gdnun.fsf@gnu.org> <839f1185-fc0c-0e8b-29fd-5431fb71ab2e@yandex.ru> <83o8wkdk3n.fsf@gnu.org> <45fcbf16-c9b4-ca15-7fa2-e7ea2137218c@yandex.ru> <83immreblb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="259497"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 37774@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 08 11:40:36 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idtzQ-0015Pn-1c for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Dec 2019 11:40:36 +0100 Original-Received: from localhost ([::1]:57474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idtzO-0006UL-9X for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Dec 2019 05:40:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45934) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idtyx-0006UF-AO for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2019 05:40:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idtyu-0003cd-97 for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2019 05:40:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44530) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idtys-0003bX-6G for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2019 05:40:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idtys-0006g5-2F for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2019 05:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2019 10:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157580156225612 (code B ref 37774); Sun, 08 Dec 2019 10:40:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 8 Dec 2019 10:39:22 +0000 Original-Received: from localhost ([127.0.0.1]:50502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idtyE-0006f2-C5 for submit@debbugs.gnu.org; Sun, 08 Dec 2019 05:39:22 -0500 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:35620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idtyC-0006ep-5P for 37774@debbugs.gnu.org; Sun, 08 Dec 2019 05:39:20 -0500 Original-Received: by mail-wm1-f44.google.com with SMTP id c20so10322926wmb.0 for <37774@debbugs.gnu.org>; Sun, 08 Dec 2019 02:39:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xGiRq1OIrw/77szrfae6foY0iurdFFAdcnOAlO9tg9E=; b=NL+5O8peA125+ADbzaVYMH5fwFEHXM9qzF/s6wWZ3D8FdZUFm8ushBeR1TD/ZAxqOV GuwJihNYP0X3dUYMODtiCaDjala5D4bbMfLkZIRphcoqISM2CITVEZDT7DffH0/SziqH lC1a2h5cxcAnP7cAMzmPjp0nmJzfzDuzh3j29RugTN9ul4l9dJIB0nM/7CzYtAc6ZmnC U/TzEidcmPsoFAiEWcVgu6Q2OSBH7mF84CznfkkASZ8wYssFUuMxDmAmNvqBboaSRNsi LjahhDtTzMacZ8+WZjQmHyotM84VWRc5La8ps38a5adkOk/t6J7n1euR4o88CSjuVAvr r5gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xGiRq1OIrw/77szrfae6foY0iurdFFAdcnOAlO9tg9E=; b=cwQXaGMDAtBgvp1PSk6o3GpEgAu2rhIKF4jjIHo8wBCSnqDuxy7ZtIHJad6tFw2+vA H/tMjkBDpX7xergst9C24d7qK1E9Wl7Xy2umdNRYdUKEhcAVz3dsIqCiZcF2O0ttS4A8 zHmlRsSwClF8KQmcL0qD1gPf2U4P91HEZr8v+z/EIITS7ZIyCV0hxd9rN14/g365QgnR FkqVDDxmkjIuYhQeJKmZ86zNLBet4SkInMf8XC0t+EDdbb/AC3kLfTsiWnOsfMdwFKS6 LjUTggadLWXXgEo4EqpX+mi0vgOSA9vO/4bnXScb2rHLClVF6ZYydPfZJsjs+9QBknM0 bRhA== X-Gm-Message-State: APjAAAWEE7vrS0bvWBDLKsQmpmbsjjjr6fACO7OeqpXQ/i8UgbaUL8wS ODo0m/Zwp4bVj4qTP/Z/gRetaiWP X-Google-Smtp-Source: APXvYqzRtvfNPrCLgv+UWC7LV+TXs+qeZ81VVoeb7iPEsIbR4v35PPuBpd//yOglqQYvXMLa7z1wKg== X-Received: by 2002:a7b:cc13:: with SMTP id f19mr20202690wmh.81.1575801553978; Sun, 08 Dec 2019 02:39:13 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id l6sm9580502wme.42.2019.12.08.02.39.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Dec 2019 02:39:13 -0800 (PST) In-Reply-To: <83immreblb.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173052 Archived-At: On 08.12.2019 5:32, Eli Zaretskii wrote: >>> Our goal is to allow themes "inherit" the :extend attribute without >>> having to specify it in their face specs, unlike with other >>> attributes. That's the only goal; >> >> But that's exactly what it does. > > It does, but the implementation is too general, and might affect other > use cases. Other use cases of what? face-spec-respec is about applying theme and default faces specs. >>> we don't want :extend to behave >>> differently from other face attributes in any other context. >> >> What other contexts do you have in mind? > > Any context other than a theme defining a face. > >> What *shouldn't* it do? > > What we do with any other face attribute. Either I don't understand you here, or the patch obviously satisfies that criterion. >>> If you are saying that we cannot make this change apply only to face >>> definitions by themes, >> >> What other face definitions are there? There's defface, of course, which >> we treat differently. And there are theme definitions (both third-party >> and "user theme"). > > All the other situations where face-spec-recalc is called. You listed > at least some of them up-thread. As I've explained, the other callers are all part of the system that makes sure theme specs (and defaults specs, of course) are applied correctly in various situations. >>> then it means we don't really understand what >>> we could break here, and then I don't think I want this change in >>> Emacs 27. Sorry, it's too risky. >> >> What about the existing risk of breaking every theme out there by doing >> nothing? > > If we don't have a safe solution, we will have to live with that risk, > unfortunately. We haven't even started the pretest yet. If there are bugs in this patch (unlikely, but always possible), we have time for people to see and report them. >>> But I don't >>> consider myself an expert on these matters, so if you say we cannot >>> differentiate between general face definition and what themes do, so >>> be it.) >> >> What's a "general face definition"? > > Everything except theme definition of faces. Please give an example.