bug#16659: ns-use-native-fullscreen breaks fullscreen functionality on maverick secondary monitor when old spaces behaviour is selected, plus slow transition

bug#16659: ns-use-native-fullscreen breaks fullscreen functionality on maverick secondary monitor when old spaces behaviour is selected, plus slow transition

[Luigi Rocca]

I am using the following emacs build, from http://emacsformacosx.com/
on an updated Mavericks installation: "GNU Emacs 24.3.50.1 (x86_64-apple-darwin, NS apple-appkit-1038.36) of 2014-01-27 on bob.porkrind.org"

I'm disabling the native fullscreen functionality in my conf file (setq ns-use-native-fullscreen nil) and I have the OSX option "Displays have separate spaces" disabled.

While avoiding the native fullscreen does two very welcome things (the fullscreen window remains on the current space and the other monitor, if attached, is not greyed out) there are two problems:

1) Going fullscreen works only on the primary laptop monitor (I'm using a macbook pro) but not on the secondary monitor on the display port. When the emacs frame is on the secondary monitor, "M-x toggle-frame-fullscreen" has the following results:
- An animation of a small black rectangle goes out of the screen (headed to the lower right part of the screen - please note the secondary monitor is on the upper left wrt the primary one, don't know if this is related or not).
- A brief macosx error sound is played.
- The screen is now empty and emacs is nowhere to be seen, neither primary nor secondary monitor.
- The only way to get the emacs frame back is blindly calling toggle-frame-fullscreen again - the frame then returns to its previous position.

2) Even on the working primary monitor there is still a very slow scaling transition to fullscreen (and back). I find slow animations in Maverick to be annoying and nausea-inducing. Users that are disabling native fullscreen functionality are probably trying to disable the slow transition too (most other open source apps that give the user the option to disable the native fullscreen functionality, such as VLC and iterm2, do exactly this and avoid the slow animation entirely). It seems reasonable to either disable the animation when native fullscreen is disabled or add and additional option to disable it and/or control how fast it is (if I've missed one I'm sorry, please point it out to me).

I've tested one of the several unofficial osx emacs versions that were fullscreen-patched in the past (https://github.com/xajler/emacs24-macosx-lion-fullscreen) and it works as intended on both counts: it goes fullscreen on both monitors and without any animation whatsoever.

If there's anything I can do to help, test etc, please do tell me. I am confortable with building software from source and it is not a problem for me to checkout and build the latest sources if necessary.

Many many thanks for all the amazing work that the emacs developers have done in the past and are still doing on this amazing editor. Keep up the good work!

Cheers,
Luigi Rocca

bug#16659: ns-use-native-fullscreen breaks fullscreen functionality on maverick secondary monitor when old spaces behaviour is selected, plus slow transition

[Jan D.]

Hello.

I have checked in a fix for 1) as it is a bug.
2) will have to wait as we are in a feature freeze.

	Jan D.

Luigi Rocca skrev 2014-02-05 18:42:
> I am using the following emacs build, from
> http://emacsformacosx.com/ on an updated Mavericks installation: "GNU
> Emacs 24.3.50.1 (x86_64-apple-darwin, NS apple-appkit-1038.36) of
> 2014-01-27 on bob.porkrind.org"
>
> I'm disabling the native fullscreen functionality in my conf file
> (setq ns-use-native-fullscreen nil) and I have the OSX option
> "Displays have separate spaces" disabled.
>
> While avoiding the native fullscreen does two very welcome things
> (the fullscreen window remains on the current space and the other
> monitor, if attached, is not greyed out) there are two problems:
>
> 1) Going fullscreen works only on the primary laptop monitor (I'm
> using a macbook pro) but not on the secondary monitor on the display
> port. When the emacs frame is on the secondary monitor, "M-x
> toggle-frame-fullscreen" has the following results: - An animation of
> a small black rectangle goes out of the screen (headed to the lower
> right part of the screen - please note the secondary monitor is on
> the upper left wrt the primary one, don't know if this is related or
> not). - A brief macosx error sound is played. - The screen is now
> empty and emacs is nowhere to be seen, neither primary nor secondary
> monitor. - The only way to get the emacs frame back is blindly
> calling toggle-frame-fullscreen again - the frame then returns to its
> previous position.
>
> 2) Even on the working primary monitor there is still a very slow
> scaling transition to fullscreen (and back). I find slow animations
> in Maverick to be annoying and nausea-inducing. Users that are
> disabling native fullscreen functionality are probably trying to
> disable the slow transition too (most other open source apps that
> give the user the option to disable the native fullscreen
> functionality, such as VLC and iterm2, do exactly this and avoid the
> slow animation entirely). It seems reasonable to either disable the
> animation when native fullscreen is disabled or add and additional
> option to disable it and/or control how fast it is (if I've missed
> one I'm sorry, please point it out to me).
>
> I've tested one of the several unofficial osx emacs versions that
> were fullscreen-patched in the past
> (https://github.com/xajler/emacs24-macosx-lion-fullscreen) and it
> works as intended on both counts: it goes fullscreen on both monitors
> and without any animation whatsoever.
>
> If there's anything I can do to help, test etc, please do tell me. I
> am confortable with building software from source and it is not a
> problem for me to checkout and build the latest sources if
> necessary.
>
> Many many thanks for all the amazing work that the emacs developers
> have done in the past and are still doing on this amazing editor.
> Keep up the good work!
>
> Cheers, Luigi Rocca
>
>
>

bug#16659: ns-use-native-fullscreen breaks fullscreen functionality on maverick secondary monitor when old spaces behaviour is selected, plus slow transition

[Luigi Rocca]

On 2/6/14, 9:00 AM, Jan D. wrote:> Hello.
> 
> I have checked in a fix for 1) as it is a bug.

I've just downloaded a nightly build and it works also for me now. Thanks a lot.

Just one minor annoyance: on my secondary display the fullscreen animation is wrong - instead of being a scaling transition from the current window position to the whole display (as it happens on my primary display) it always seems to start from outside the display, left side, no matter where the emacs windows actually is. Oddly, the transition from fullscreen (which should the same played backwards) back to the original window is right on both displays.

I personally don't care - I find that animation to be ugly and slow even when it's right, and the fact that emacs goes fullscreen on both displays is enough for me. I mention it because it's still a bug, although minor and I can imagine that someone would want to fix it. If it's needed, I can provide a link to a small screencast showing the problem, let me know in case.

I would love to see it fixed it by getting rid of the animation altogether (which could even be simpler than track down why it's skewed, maybe?), but that's only a personal preference of mine... ;-)


> 2) will have to wait as we are in a feature freeze.
> 

Fair enough.

Bye,
Luigi

bug#16659: ns-use-native-fullscreen breaks fullscreen functionality on maverick secondary monitor when old spaces behaviour is selected, plus slow transition

[Jan Djärv]

Hello.

You can customize ns-use-fullscreen-animation now in the trunk.
Default is animation off on the assumtion that users of non-native fullscreen don't want animation.

	Jan D.

9 feb 2014 kl. 00:48 skrev Luigi Rocca <rocca@disi.unige.it>:

> On 2/6/14, 9:00 AM, Jan D. wrote:> Hello.
>> 
>> I have checked in a fix for 1) as it is a bug.
> 
> I've just downloaded a nightly build and it works also for me now. Thanks a lot.
> 
> Just one minor annoyance: on my secondary display the fullscreen animation is wrong - instead of being a scaling transition from the current window position to the whole display (as it happens on my primary display) it always seems to start from outside the display, left side, no matter where the emacs windows actually is. Oddly, the transition from fullscreen (which should the same played backwards) back to the original window is right on both displays.
> 
> I personally don't care - I find that animation to be ugly and slow even when it's right, and the fact that emacs goes fullscreen on both displays is enough for me. I mention it because it's still a bug, although minor and I can imagine that someone would want to fix it. If it's needed, I can provide a link to a small screencast showing the problem, let me know in case.
> 
> I would love to see it fixed it by getting rid of the animation altogether (which could even be simpler than track down why it's skewed, maybe?), but that's only a personal preference of mine... ;-)
> 
> 
>> 2) will have to wait as we are in a feature freeze.
>> 
> 
> Fair enough.
> 
> Bye,
> Luigi

bug#16659: ns-use-native-fullscreen breaks fullscreen functionality on maverick secondary monitor when old spaces behaviour is selected, plus slow transition

[Jan Djärv]

Closing.