From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#16013: 24.3.50; Rows in height is interpreted as pixels. Date: Tue, 14 Jan 2014 19:10:24 +0100 Message-ID: <52D57D90.3070306@gmx.at> References: <5579FC36-5F75-4679-87F6-048C5B7326F6@swipnet.se> <5299FD88.2090600@gmx.at> <529A33F4.5030606@swipnet.se> <529B0519.3010902@gmx.at> <529B1C71.9020707@gmx.at> <529CCE48.9090404@gmx.at> <529D8F3E.30400@gmx.at> <93EF122E-7EFC-4ACF-A216-E83981DD511A@swipnet.se> <529E2441.8030808@gmx.at> <9E083836-7DF3-4AC3-8711-A0E4757C9691@swipnet.se> <01BCA22D-62F2-4F04-B14C-85452A9D1201@swipnet.se> <52D14EA5.9060900@gmx.at> <52D18361.5050308@swipnet.se> <52D2663A.3020201@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1389723076 8367 80.91.229.3 (14 Jan 2014 18:11:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jan 2014 18:11:16 +0000 (UTC) Cc: "16013@debbugs.gnu.org" <16013@debbugs.gnu.org> To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 14 19:11:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W38SP-00062p-PA for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Jan 2014 19:11:22 +0100 Original-Received: from localhost ([::1]:49926 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W38SP-0005rR-AJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Jan 2014 13:11:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W38SE-0005g1-B7 for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 13:11:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W38S6-0005J7-Ty for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 13:11:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36630) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W38S6-0005Ir-Qu for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 13:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W38S5-00009T-N4 for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 13:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jan 2014 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16013 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16013-submit@debbugs.gnu.org id=B16013.1389723044536 (code B ref 16013); Tue, 14 Jan 2014 18:11:01 +0000 Original-Received: (at 16013) by debbugs.gnu.org; 14 Jan 2014 18:10:44 +0000 Original-Received: from localhost ([127.0.0.1]:50649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W38Rl-00008V-0J for submit@debbugs.gnu.org; Tue, 14 Jan 2014 13:10:41 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:61729) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W38Rg-00008F-6K for 16013@debbugs.gnu.org; Tue, 14 Jan 2014 13:10:37 -0500 Original-Received: from [62.47.49.220] ([62.47.49.220]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0M5IdH-1V9LxU0pP5-00zXhm for <16013@debbugs.gnu.org>; Tue, 14 Jan 2014 19:10:35 +0100 In-Reply-To: X-Provags-ID: V03:K0:CdhTCW6ZNJ5EtF8oPAz4qul9iULqKjfVr3Yc3uDPkU8HgOZUC1a xQelS+XjvKJAt+Uh3M+/TErojD+q26pMbOcUOZ6g+AnjV6mPfbJT3B4EO15y+r5sCBkaMys oyNiuh0XEKTQDcyzOjFn3iO6zm8ZiVHD3gTr1FeYebCSfvFCMKAw5a5XtaltWOq3cWQPJ8M cX/fmeV+mfnZhslsEiC3g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83490 Archived-At: > GNUStep has some bugs w.r.t. the tool bar, so the values for GNUStep is as good as it gets. As for the rest the main problem is this part in x_figure_window_size: /* This used to be done _before_ calling x_figure_window_size, but since the height is reset here, this was really a no-op. I assume that moving it here does what Gerd intended (although he no longer can remember what that was... ++KFS, 2003-03-25. */ /* Add the tool-bar height to the initial frame height so that the user gets a text display area of the size he specified with -g or via .Xdefaults. Later changes of the tool-bar height don't change the frame size. This is done so that users can create tall Emacs frames without having to guess how tall the tool-bar will get. */ if (toolbar_p && FRAME_TOOL_BAR_HEIGHT (f)) { int margin, relief, bar_height; relief = (tool_bar_button_relief >= 0 ? tool_bar_button_relief : DEFAULT_TOOL_BAR_BUTTON_RELIEF); if (RANGED_INTEGERP (1, Vtool_bar_button_margin, INT_MAX)) margin = XFASTINT (Vtool_bar_button_margin); else if (CONSP (Vtool_bar_button_margin) && RANGED_INTEGERP (1, XCDR (Vtool_bar_button_margin), INT_MAX)) margin = XFASTINT (XCDR (Vtool_bar_button_margin)); else margin = 0; /* PXW: We should be able to not round here. */ bar_height = DEFAULT_TOOL_BAR_IMAGE_HEIGHT + 2 * margin + 2 * relief; FRAME_LINES (f) += (bar_height + FRAME_LINE_HEIGHT (f) - 1) / FRAME_LINE_HEIGHT (f); } If I define it out, the sizes of the first and subsequent frames are equal on Lucid. IIUC x_figure_window_size is not called when changing fonts or default heights. martin