From: Daniel Colascione <dancol@dancol.org>
To: Drew Adams <drew.adams@oracle.com>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Andy Moreton <andrewjmoreton@gmail.com>
Cc: 16402@debbugs.gnu.org
Subject: bug#16402: 24.3.50; Document nadvice.el stuff in Elisp manual before Emacs 24.4
Date: Fri, 10 Jan 2014 13:21:07 -0800 [thread overview]
Message-ID: <52D06443.2020700@dancol.org> (raw)
In-Reply-To: <4e0a82f8-0a1b-4325-ba66-dc5c61ae53b4@default>
On 01/10/2014 07:15 AM, Drew Adams wrote:
>>> A rationale to explain why the existing advice package needs
>>> changing would also be helpful.
>>
>> Here are some of the reasons:
>
> Excellent. Very glad to see design rationale documented like this.
> Seriously. (Please keep it up.)
Agreed. nadvice sounds like a good implementation change. The advice
*interface*, however, isn't going away, so I'm hesitant to recommend the
nadvice interface as well. Users will be confused about which to use.
(Yes, we can tell users that advice is deprecated, but then a very large
amount of working elisp code users see is "deprecated". What message
does that send?)
There's one part where I'm not sure I agree though.
>> - advice.el is much too large to be preloaded,
>> so for example debug.el refrained from using it.
So what if it's large? Isn't it *because* a commonly-used package is
large that we want to preload it? This way, we pay up-front for the cost
of loading that package instead of making users load it on each start.
next prev parent reply other threads:[~2014-01-10 21:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 6:06 bug#16402: 24.3.50; Document nadvice.el stuff in Elisp manual before Emacs 24.4 Drew Adams
2014-01-09 6:21 ` Glenn Morris
2014-01-09 16:01 ` Stefan Monnier
2014-01-10 2:29 ` Andy Moreton
2014-01-10 3:28 ` Leo Liu
2014-01-10 3:39 ` Daniel Colascione
2014-01-10 4:18 ` Drew Adams
2014-01-10 4:19 ` Leo Liu
2014-01-10 14:42 ` Stefan Monnier
2014-01-10 15:15 ` Drew Adams
2014-01-10 21:21 ` Daniel Colascione [this message]
2014-01-10 21:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D06443.2020700@dancol.org \
--to=dancol@dancol.org \
--cc=16402@debbugs.gnu.org \
--cc=andrewjmoreton@gmail.com \
--cc=drew.adams@oracle.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).