From: Daniel Colascione <dancol@dancol.org>
To: Drew Adams <drew.adams@oracle.com>, 16251@debbugs.gnu.org
Subject: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now
Date: Wed, 25 Dec 2013 00:30:07 -0800 [thread overview]
Message-ID: <52BA978F.4010804@dancol.org> (raw)
In-Reply-To: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default>
On 12/24/2013 09:58 PM, Drew Adams wrote:
> [The build noted below is the one this bug report is for. But I'm
> sending this using an older build than the one noted below, because of
> another new bug, which prevents using `report-emacs-bug']
>
>
> Just a preliminary heads up for now. Hope to add more info later, when
> I get some time.
>
> I downloaded this build, and when `icomplete-mode' is on, with my setup
> it takes several seconds to gather the list of file candidates in my
> usual directory. With a build from two days ago, this does not happen.
> And if I turn off icomplete mode it also does not happen.
>
> It seems that something was changed in the icomplete mode code recently
> that breaks at least my file-finding code.
>
> With emacs -Q I do not notice the problem (well, maybe a slight delay).
> I see that C-x C-f now shows completions immediately, without my typing
> any prefix. That is not true in the build from 2 days ago.
Mea culpa: I committed a change that caused icomplete to try to show
completions right away by default. As Jambunathan mentions, setting
icomplete-show-matches-on-no-input to nil should restore the old
behavior. The old behavior isn't optimal, though, and icomplete isn't a
replacement for iswitchb without the feature I added.
Maybe we can change icomplete-show-matches-on-no-input to a command list
--- this way, we could show completions early for buffer switching, but
not for finding files.
Why is finding the list of files so slow for you? Don't you experience
the same performance problem after typing a character and forcing
completions to show up? We call the completion function inside
while-no-input, so we should abort the "several seconds" of work as soon
as you start typing.
next prev parent reply other threads:[~2013-12-25 8:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 5:58 bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now Drew Adams
2013-12-25 6:18 ` Jambunathan K
2013-12-25 17:17 ` Drew Adams
2013-12-25 8:30 ` Daniel Colascione [this message]
2013-12-25 17:23 ` Drew Adams
2013-12-25 18:02 ` Eli Zaretskii
2013-12-27 12:59 ` Stefan Monnier
2013-12-28 0:55 ` Drew Adams
2013-12-28 8:51 ` Eli Zaretskii
[not found] <<497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default>
[not found] ` <<jwv4n5uv4fz.fsf-monnier+emacsbugs@gnu.org>
[not found] ` <<818df3a7-a5fa-4871-86e1-0bd5d8e4a5fc@default>
[not found] ` <<83y5352wae.fsf@gnu.org>
2013-12-28 16:01 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BA978F.4010804@dancol.org \
--to=dancol@dancol.org \
--cc=16251@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).