* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
@ 2013-12-11 16:59 Drew Adams
2013-12-11 17:55 ` martin rudalics
0 siblings, 1 reply; 29+ messages in thread
From: Drew Adams @ 2013-12-11 16:59 UTC (permalink / raw)
To: 16115
Subject line says it all. The doc string speaks of SIDE, as if there
were a SIDE argument. There is none.
In GNU Emacs 24.3.50.2 (i686-pc-mingw32)
of 2013-11-28 on LEG570
Bzr revision: 115271 rgm@gnu.org-20131128203155-qjc1xsp19z2k64b2
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-11 16:59 bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg Drew Adams
@ 2013-12-11 17:55 ` martin rudalics
2013-12-11 18:57 ` Drew Adams
2013-12-11 23:54 ` Juri Linkov
0 siblings, 2 replies; 29+ messages in thread
From: martin rudalics @ 2013-12-11 17:55 UTC (permalink / raw)
To: Drew Adams; +Cc: 16115
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
> Subject line says it all. The doc string speaks of SIDE, as if there
> were a SIDE argument. There is none.
Thanks. Should be fixed now.
I couldn't resist to attach a file where you can see how this function
can be used.
martin
[-- Attachment #2: frame-tabs.el --]
[-- Type: application/emacs-lisp, Size: 13541 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-11 17:55 ` martin rudalics
@ 2013-12-11 18:57 ` Drew Adams
2013-12-11 19:01 ` Drew Adams
2013-12-12 10:14 ` martin rudalics
2013-12-11 23:54 ` Juri Linkov
1 sibling, 2 replies; 29+ messages in thread
From: Drew Adams @ 2013-12-11 18:57 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> > Subject line says it all. The doc string speaks of SIDE, as if there
> > were a SIDE argument. There is none.
>
> Thanks. Should be fixed now.
That was quick. Thanks.
> I couldn't resist to attach a file where you can see how this function
> can be used.
Looks interesting. When I loaded it I got this message:
Wrong type argument: listp, :inherit
This is one offender:
(defface frame-tabs-higlight-tab
'((t :inherit frame-tabs-item-tab
:foreground "white"
:background "green3"))
"Face for highlighting frame tabs item."
:version "24.4"
:group 'frame-tabs)
But if I try `C-M-x' on that twice, the first time gives the error and
the second defines it OK. Likewise for the other face defs.
Haven't tried to dig into it further - no time now.
(BTW, spelling typos: "higlight" -> "highlight".)
Wrt the function (and how I discovered its doc), I just used it in an
answer to a StackOverflow question. Dunno whether my answer is
appropriate or a good use of the function. Probably there is a simpler
and better answer.
http://stackoverflow.com/a/20525430/729907
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-11 18:57 ` Drew Adams
@ 2013-12-11 19:01 ` Drew Adams
2013-12-12 10:14 ` martin rudalics
1 sibling, 0 replies; 29+ messages in thread
From: Drew Adams @ 2013-12-11 19:01 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> When I loaded it I got this message:
> Wrong type argument: listp, :inherit
Nevermind that; sorry. I was using an old Emacs version.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-11 17:55 ` martin rudalics
2013-12-11 18:57 ` Drew Adams
@ 2013-12-11 23:54 ` Juri Linkov
2013-12-12 10:15 ` martin rudalics
1 sibling, 1 reply; 29+ messages in thread
From: Juri Linkov @ 2013-12-11 23:54 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> I couldn't resist to attach a file where you can see how this function
> can be used.
>
> ;;; frame-tabs.el --- Frame based tabs windows
Fantastic! Do you intend to install this for the next release
or it needs more work? One problem I noticed immediately:
after clicking on the tab it keeps the side window selected.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-11 18:57 ` Drew Adams
2013-12-11 19:01 ` Drew Adams
@ 2013-12-12 10:14 ` martin rudalics
2013-12-12 16:18 ` Drew Adams
1 sibling, 1 reply; 29+ messages in thread
From: martin rudalics @ 2013-12-12 10:14 UTC (permalink / raw)
To: Drew Adams; +Cc: 16115
> Wrt the function (and how I discovered its doc), I just used it in an
> answer to a StackOverflow question. Dunno whether my answer is
> appropriate or a good use of the function. Probably there is a simpler
> and better answer.
`display-buffer-below-selected' or something similar might be the
answer. Side windows serve a completely different purpose.
martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-11 23:54 ` Juri Linkov
@ 2013-12-12 10:15 ` martin rudalics
2013-12-12 18:25 ` Stefan Monnier
2013-12-13 1:18 ` Juri Linkov
0 siblings, 2 replies; 29+ messages in thread
From: martin rudalics @ 2013-12-12 10:15 UTC (permalink / raw)
To: Juri Linkov; +Cc: 16115
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
> Do you intend to install this for the next release
> or it needs more work?
It's merely meant as a proof of concept whether and how persistent
windows work. It would be a great thing if you (or someone else) filled
in the gory details. What's needed here is a good feeling for how tabs
are typically used in other applications (I do use tab mix plus on
Firefox but my settings are probably far too exotic) and how to
implement them within the framework of side windows.
> One problem I noticed immediately:
> after clicking on the tab it keeps the side window selected.
Yes. `switch-to-buffer' doesn't seem to be the right answer for this.
BTW, you should set `window-resize-pixelwise' to non-nil in order to
better fit tabs buffers to their contents. Since I also wrote some code
for window-based tabs I simply attach it here.
martin
[-- Attachment #2: win-tabs.el --]
[-- Type: application/emacs-lisp, Size: 12058 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-12 10:14 ` martin rudalics
@ 2013-12-12 16:18 ` Drew Adams
2013-12-12 18:09 ` martin rudalics
0 siblings, 1 reply; 29+ messages in thread
From: Drew Adams @ 2013-12-12 16:18 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> > Wrt the function (and how I discovered its doc), I just used it in an
> > answer to a StackOverflow question. Dunno whether my answer is
> > appropriate or a good use of the function. Probably there is a simpler
> > and better answer.
>
> `display-buffer-below-selected' or something similar might be the
> answer. Side windows serve a completely different purpose.
Sorry, I don't understand. The requester wanted the buffer to pop up on
the right, not below. And AFAICT the code I proposed does that. Can
you elaborate?
What is the right way to pop to a buffer in a window to the right? IOW,
the request was to get the effect of `C-x 3' but with the chosen buffer,
not the same buffer, in the new window on the right.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-12 16:18 ` Drew Adams
@ 2013-12-12 18:09 ` martin rudalics
2013-12-12 19:50 ` Drew Adams
2013-12-13 21:54 ` Juri Linkov
0 siblings, 2 replies; 29+ messages in thread
From: martin rudalics @ 2013-12-12 18:09 UTC (permalink / raw)
To: Drew Adams; +Cc: 16115
>> `display-buffer-below-selected' or something similar might be the
>> answer. Side windows serve a completely different purpose.
>
> Sorry, I don't understand. The requester wanted the buffer to pop up on
> the right, not below. And AFAICT the code I proposed does that. Can
> you elaborate?
If it makes a "side window", the effect is that the new window will be
permanent unless explicitly deleted. Does the requester want that?
> What is the right way to pop to a buffer in a window to the right? IOW,
> the request was to get the effect of `C-x 3' but with the chosen buffer,
> not the same buffer, in the new window on the right.
If the frame is wide enough, `display-buffer-below-selected' will
display it on the right of the selected window, otherwise below. This
can be tuned via `split-height-/width-threshold'.
martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-12 10:15 ` martin rudalics
@ 2013-12-12 18:25 ` Stefan Monnier
2013-12-13 10:13 ` martin rudalics
2013-12-13 1:18 ` Juri Linkov
1 sibling, 1 reply; 29+ messages in thread
From: Stefan Monnier @ 2013-12-12 18:25 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> It's merely meant as a proof of concept whether and how persistent
> windows work. It would be a great thing if you (or someone else) filled
> in the gory details. What's needed here is a good feeling for how tabs
> are typically used in other applications (I do use tab mix plus on
> Firefox but my settings are probably far too exotic) and how to
> implement them within the framework of side windows.
You could add them to GNU ELPA, to try and attract users (which then
hopefully turn into developers to fix the shortcomings).
Stefan
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-12 18:09 ` martin rudalics
@ 2013-12-12 19:50 ` Drew Adams
2013-12-14 11:22 ` martin rudalics
2013-12-13 21:54 ` Juri Linkov
1 sibling, 1 reply; 29+ messages in thread
From: Drew Adams @ 2013-12-12 19:50 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> >> `display-buffer-below-selected' or something similar might be the
> >> answer. Side windows serve a completely different purpose.
> >
> > Sorry, I don't understand. The requester wanted the buffer to pop up on
> > the right, not below. And AFAICT the code I proposed does that. Can
> > you elaborate?
>
> If it makes a "side window", the effect is that the new window will be
> permanent unless explicitly deleted. Does the requester want that?
Dunno. I don't even know what a "permanent" window is. When you do
`C-x 3' is the new window permanent?
> > What is the right way to pop to a buffer in a window to the right? IOW,
> > the request was to get the effect of `C-x 3' but with the chosen buffer,
> > not the same buffer, in the new window on the right.
>
> If the frame is wide enough, `display-buffer-below-selected' will
> display it on the right of the selected window, otherwise below. This
> can be tuned via `split-height-/width-threshold'.
Apparently the OP would like the behavior to be similar to what `C-x 3'
does. Is that what `display-buffer-below-selected' always does? Perhaps
you'd like to post an answer to him directly on StackOverflow.
Of if not, I can transfer any answer you provide here to him there.
But I would just be an uninformed middleman, as I'm no authority on
`display-buffer-below-selected' or `split-height-/width-threshold',
to put it mildly.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-12 10:15 ` martin rudalics
2013-12-12 18:25 ` Stefan Monnier
@ 2013-12-13 1:18 ` Juri Linkov
2013-12-13 10:13 ` martin rudalics
1 sibling, 1 reply; 29+ messages in thread
From: Juri Linkov @ 2013-12-13 1:18 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> What's needed here is a good feeling for how tabs are typically used
> in other applications (I do use tab mix plus on Firefox but my
> settings are probably far too exotic) and how to implement them within
> the framework of side windows.
Having the user interface that displays frame tabs in side windows, it
would be trivial to use it for switching between window configurations.
As for window tabs, there is no general application for them, so window
tabs are rather package-specific, e.g. Gnus could use them to display
opened groups attached to summary buffers in window tabs, etc.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-13 1:18 ` Juri Linkov
@ 2013-12-13 10:13 ` martin rudalics
0 siblings, 0 replies; 29+ messages in thread
From: martin rudalics @ 2013-12-13 10:13 UTC (permalink / raw)
To: Juri Linkov; +Cc: 16115
> Having the user interface that displays frame tabs in side windows, it
> would be trivial to use it for switching between window configurations.
> As for window tabs, there is no general application for them, so window
> tabs are rather package-specific, e.g. Gnus could use them to display
> opened groups attached to summary buffers in window tabs, etc.
If you are interested, peruse my code any way you like. In the near
future I won't have much time to spend on it.
martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-12 18:25 ` Stefan Monnier
@ 2013-12-13 10:13 ` martin rudalics
2013-12-13 10:56 ` Eli Zaretskii
0 siblings, 1 reply; 29+ messages in thread
From: martin rudalics @ 2013-12-13 10:13 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 16115
> You could add them to GNU ELPA, to try and attract users (which then
> hopefully turn into developers to fix the shortcomings).
IIUC I would have to install Git first here. Are there any
guides for doing this with Emacs on Windows?
martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-13 10:13 ` martin rudalics
@ 2013-12-13 10:56 ` Eli Zaretskii
2013-12-14 11:23 ` martin rudalics
0 siblings, 1 reply; 29+ messages in thread
From: Eli Zaretskii @ 2013-12-13 10:56 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> Date: Fri, 13 Dec 2013 11:13:40 +0100
> From: martin rudalics <rudalics@gmx.at>
> Cc: 16115@debbugs.gnu.org
>
> Are there any guides for [installing Git] with Emacs on Windows?
Depends on whether you want to use VC or external packages.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-12 18:09 ` martin rudalics
2013-12-12 19:50 ` Drew Adams
@ 2013-12-13 21:54 ` Juri Linkov
2013-12-14 11:23 ` martin rudalics
2013-12-14 17:16 ` martin rudalics
1 sibling, 2 replies; 29+ messages in thread
From: Juri Linkov @ 2013-12-13 21:54 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> If the frame is wide enough, `display-buffer-below-selected' will
> display it on the right of the selected window, otherwise below. This
> can be tuned via `split-height-/width-threshold'.
Shouldn't `display-buffer-below-selected' display the buffer below,
and not on the right? I.e. like you recently added the let-binding
`(split-width-threshold)' to `display-buffer-at-bottom',
it would also make sense to do the same by moving the let-binding
`(split-height-threshold 0)' to `display-buffer-below-selected'.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-12 19:50 ` Drew Adams
@ 2013-12-14 11:22 ` martin rudalics
0 siblings, 0 replies; 29+ messages in thread
From: martin rudalics @ 2013-12-14 11:22 UTC (permalink / raw)
To: Drew Adams; +Cc: 16115
> Apparently the OP would like the behavior to be similar to what `C-x 3'
> does. Is that what `display-buffer-below-selected' always does? Perhaps
> you'd like to post an answer to him directly on StackOverflow.
>
> Of if not, I can transfer any answer you provide here to him there.
> But I would just be an uninformed middleman, as I'm no authority on
> `display-buffer-below-selected' or `split-height-/width-threshold',
> to put it mildly.
The OP should post a request on this list so we can talk things over.
martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-13 21:54 ` Juri Linkov
@ 2013-12-14 11:23 ` martin rudalics
2013-12-14 16:20 ` Drew Adams
2013-12-14 17:16 ` martin rudalics
1 sibling, 1 reply; 29+ messages in thread
From: martin rudalics @ 2013-12-14 11:23 UTC (permalink / raw)
To: Juri Linkov; +Cc: 16115
> Shouldn't `display-buffer-below-selected' display the buffer below,
> and not on the right? I.e. like you recently added the let-binding
> `(split-width-threshold)' to `display-buffer-at-bottom',
> it would also make sense to do the same by moving the let-binding
> `(split-height-threshold 0)' to `display-buffer-below-selected'.
Just that now we apparently have a request for displaying the buffer at
the right ...
martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-13 10:56 ` Eli Zaretskii
@ 2013-12-14 11:23 ` martin rudalics
2013-12-14 12:09 ` Eli Zaretskii
0 siblings, 1 reply; 29+ messages in thread
From: martin rudalics @ 2013-12-14 11:23 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 16115
>> Are there any guides for [installing Git] with Emacs on Windows?
>
> Depends on whether you want to use VC or external packages.
IIUC I have to install Git first. What would be different after I have
done that? What does VC stand for in this regard and which are the
external packages I would need?
martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-14 11:23 ` martin rudalics
@ 2013-12-14 12:09 ` Eli Zaretskii
2013-12-14 13:45 ` martin rudalics
0 siblings, 1 reply; 29+ messages in thread
From: Eli Zaretskii @ 2013-12-14 12:09 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> Date: Sat, 14 Dec 2013 12:23:29 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: monnier@IRO.UMontreal.CA, 16115@debbugs.gnu.org
>
> >> Are there any guides for [installing Git] with Emacs on Windows?
> >
> > Depends on whether you want to use VC or external packages.
>
> IIUC I have to install Git first.
Well, of course. I didn't think you needed a guide for that. There's
only one such package for Windows anyway.
> What would be different after I have done that?
You need to configure it to work with Emacs, or configure Emacs to
work with Git, because you must run Git via MSYS Bash, unlike what you
probably do with other programs you invoke from Emacs on Windows.
> What does VC stand for in this regard
The usual VC stuff from Emacs is what I meant.
> and which are the external packages I would need?
If you are fine with what Emacs has in lisp/vc/, then none. (Well,
perhaps grab my port of git-merge-changelog.) Otherwise, there are a
few Git front ends floating around, and I'm sure their respective
enthusiasts here will speak up shortly.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-14 12:09 ` Eli Zaretskii
@ 2013-12-14 13:45 ` martin rudalics
2013-12-14 14:06 ` Eli Zaretskii
0 siblings, 1 reply; 29+ messages in thread
From: martin rudalics @ 2013-12-14 13:45 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 16115
> There's
> only one such package for Windows anyway.
Does Git work with PuTTY just like bzr does?
>> What would be different after I have done that?
>
> You need to configure it to work with Emacs, or configure Emacs to
> work with Git, because you must run Git via MSYS Bash, unlike what you
> probably do with other programs you invoke from Emacs on Windows.
Arrgh.
>> What does VC stand for in this regard
>
> The usual VC stuff from Emacs is what I meant.
Which I don't use, currently. I want to run the few commands I need
from the same shell I run bzr.
>> and which are the external packages I would need?
>
> If you are fine with what Emacs has in lisp/vc/, then none. (Well,
> perhaps grab my port of git-merge-changelog.) Otherwise, there are a
> few Git front ends floating around, and I'm sure their respective
> enthusiasts here will speak up shortly.
OK.
Thanks, martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-14 13:45 ` martin rudalics
@ 2013-12-14 14:06 ` Eli Zaretskii
0 siblings, 0 replies; 29+ messages in thread
From: Eli Zaretskii @ 2013-12-14 14:06 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> Date: Sat, 14 Dec 2013 14:45:35 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: monnier@IRO.UMontreal.CA, 16115@debbugs.gnu.org
>
> > There's
> > only one such package for Windows anyway.
>
> Does Git work with PuTTY just like bzr does?
It can work with PuTTY or with OpenSSH that comes with it. I set it
up for PuTTY, FWIW, because I like the Pageant thing better than
ssh-agent, and because Pageant is always running on my system anyway.
(Btw, bzr doesn't need PuTTY, it has its own internal implementation
of the SSH protocol.)
> >> What does VC stand for in this regard
> >
> > The usual VC stuff from Emacs is what I meant.
>
> Which I don't use, currently. I want to run the few commands I need
> from the same shell I run bzr.
Fine, then just set GIT_EDITOR to point to emacsclient.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-14 11:23 ` martin rudalics
@ 2013-12-14 16:20 ` Drew Adams
2013-12-14 17:17 ` martin rudalics
0 siblings, 1 reply; 29+ messages in thread
From: Drew Adams @ 2013-12-14 16:20 UTC (permalink / raw)
To: martin rudalics, Juri Linkov; +Cc: 16115
> > Shouldn't `display-buffer-below-selected' display the buffer below,
> > and not on the right? I.e. like you recently added the let-binding
> > `(split-width-threshold)' to `display-buffer-at-bottom',
> > it would also make sense to do the same by moving the let-binding
> > `(split-height-threshold 0)' to `display-buffer-below-selected'.
>
> Just that now we apparently have a request for displaying the buffer at
> the right ...
No, we do not. To be clear -
On StackOverflow someone asked how to do that; that's all. The request
was to get pretty much the effect of `C-x 3 C-x o C-x b some-buffer',
essentially popping to a buffer in a window on the right.
I don't do that kind of thing often, so I looked in the doc for a
possible answer. I thought I recalled seeing info about how to do
things like this in the various long threads about the new fine-tuning
possibilities of `display-buffer', so I figured there was likely a
simple way to do this, or at least some way.
I came across `display-buffer-in-side-window', and both its name and
its doc seemed to correspond to the request. I quickly wrote a command
that used that function, and that command seemed (still seems) to DTRT.
I sent a minor bug report, mentioning only that there is no SIDE
parameter (which parameter is incorrectly mentioned in the doc string).
Nothing more. There was no request for a function to pop to a buffer
at the right.
What you might consider, if you like, is to make clear in the doc, if
it is not already so (and I couldn't find it), what is available to do
what the OP requested, IOW, what is the right way, if there is a way,
to pop to a buffer at the right.
And you might want to make clear in the `display-buffer-in-side-window'
doc that it is not for this - and why not: what it is really for, since
its name and current doc misled at least me in this regard.
If you do not want to do that, fine. THIS bug report is only about
asking that SIDE be removed from the doc string, which I think Martin
has already done. As far as I am concerned, if that is done then this
bug is fixed.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-13 21:54 ` Juri Linkov
2013-12-14 11:23 ` martin rudalics
@ 2013-12-14 17:16 ` martin rudalics
2013-12-15 19:56 ` Juri Linkov
1 sibling, 1 reply; 29+ messages in thread
From: martin rudalics @ 2013-12-14 17:16 UTC (permalink / raw)
To: Juri Linkov; +Cc: 16115
> Shouldn't `display-buffer-below-selected' display the buffer below,
> and not on the right? I.e. like you recently added the let-binding
> `(split-width-threshold)' to `display-buffer-at-bottom',
> it would also make sense to do the same by moving the let-binding
> `(split-height-threshold 0)' to `display-buffer-below-selected'.
I bound `split-width-threshold' to nil as in `display-buffer-at-bottom'.
The value of `split-height-threshold' should be left to the user here,
IMO. But if you insist that binding it to zero is better, I certainly
won't object.
martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-14 16:20 ` Drew Adams
@ 2013-12-14 17:17 ` martin rudalics
0 siblings, 0 replies; 29+ messages in thread
From: martin rudalics @ 2013-12-14 17:17 UTC (permalink / raw)
To: Drew Adams; +Cc: 16115-done
>> Just that now we apparently have a request for displaying the buffer at
>> the right ...
>
> No, we do not. To be clear -
OK. Closing this bug.
Thanks again, martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-14 17:16 ` martin rudalics
@ 2013-12-15 19:56 ` Juri Linkov
2013-12-16 10:10 ` martin rudalics
0 siblings, 1 reply; 29+ messages in thread
From: Juri Linkov @ 2013-12-15 19:56 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
> I bound `split-width-threshold' to nil as in `display-buffer-at-bottom'.
Thanks.
> The value of `split-height-threshold' should be left to the user here,
> IMO. But if you insist that binding it to zero is better, I certainly
> won't object.
If every call to `display-buffer-below-selected' has to be accompanied with
`(let ((split-height-threshold 0)) ...)' to do what the function name suggests
then it makes sense to move it to `display-buffer-below-selected'.
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-15 19:56 ` Juri Linkov
@ 2013-12-16 10:10 ` martin rudalics
2013-12-16 20:19 ` Juri Linkov
0 siblings, 1 reply; 29+ messages in thread
From: martin rudalics @ 2013-12-16 10:10 UTC (permalink / raw)
To: Juri Linkov; +Cc: 16115
> If every call to `display-buffer-below-selected' has to be accompanied with
> `(let ((split-height-threshold 0)) ...)' to do what the function name suggests
> then it makes sense to move it to `display-buffer-below-selected'.
Moved there in revision 115543.
Thanks, martin
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-16 10:10 ` martin rudalics
@ 2013-12-16 20:19 ` Juri Linkov
2013-12-17 17:31 ` martin rudalics
0 siblings, 1 reply; 29+ messages in thread
From: Juri Linkov @ 2013-12-16 20:19 UTC (permalink / raw)
To: martin rudalics; +Cc: 16115
>> If every call to `display-buffer-below-selected' has to be accompanied with
>> `(let ((split-height-threshold 0)) ...)' to do what the function name suggests
>> then it makes sense to move it to `display-buffer-below-selected'.
>
> Moved there in revision 115543.
Thanks. Could now (split-height-threshold 0) be removed from all
existing calls of `display-buffer-below-selected'?
^ permalink raw reply [flat|nested] 29+ messages in thread
* bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg
2013-12-16 20:19 ` Juri Linkov
@ 2013-12-17 17:31 ` martin rudalics
0 siblings, 0 replies; 29+ messages in thread
From: martin rudalics @ 2013-12-17 17:31 UTC (permalink / raw)
To: Juri Linkov; +Cc: 16115
> Thanks. Could now (split-height-threshold 0) be removed from all
> existing calls of `display-buffer-below-selected'?
Done in revision 115569 on trunk.
martin
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2013-12-17 17:31 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-11 16:59 bug#16115: 24.3.50; doc string of `display-buffer-in-side-window' - there is no SIDE arg Drew Adams
2013-12-11 17:55 ` martin rudalics
2013-12-11 18:57 ` Drew Adams
2013-12-11 19:01 ` Drew Adams
2013-12-12 10:14 ` martin rudalics
2013-12-12 16:18 ` Drew Adams
2013-12-12 18:09 ` martin rudalics
2013-12-12 19:50 ` Drew Adams
2013-12-14 11:22 ` martin rudalics
2013-12-13 21:54 ` Juri Linkov
2013-12-14 11:23 ` martin rudalics
2013-12-14 16:20 ` Drew Adams
2013-12-14 17:17 ` martin rudalics
2013-12-14 17:16 ` martin rudalics
2013-12-15 19:56 ` Juri Linkov
2013-12-16 10:10 ` martin rudalics
2013-12-16 20:19 ` Juri Linkov
2013-12-17 17:31 ` martin rudalics
2013-12-11 23:54 ` Juri Linkov
2013-12-12 10:15 ` martin rudalics
2013-12-12 18:25 ` Stefan Monnier
2013-12-13 10:13 ` martin rudalics
2013-12-13 10:56 ` Eli Zaretskii
2013-12-14 11:23 ` martin rudalics
2013-12-14 12:09 ` Eli Zaretskii
2013-12-14 13:45 ` martin rudalics
2013-12-14 14:06 ` Eli Zaretskii
2013-12-13 1:18 ` Juri Linkov
2013-12-13 10:13 ` martin rudalics
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).