From: martin rudalics <rudalics@gmx.at>
To: Drew Adams <drew.adams@oracle.com>
Cc: 16028@debbugs.gnu.org
Subject: bug#16028: 24.3.50; Latest build completely breaks my thumnail frames code
Date: Thu, 12 Dec 2013 19:10:15 +0100 [thread overview]
Message-ID: <52A9FC07.7040304@gmx.at> (raw)
In-Reply-To: <039ebe72-12f8-49df-ae49-f1b7c56302e5@default>
> Why should asking to change the scroll-bar width constitute a request to
> also change the pixel size of the frame?
Because that's what x_set_scroll_bar_width in frame.c does.
Unfortunately so, IMHO.
> Or did you mean only that
> changing the scroll-bar width will change the frame width slightly?
> The latter I could probably live with.
When x_set_scroll_bar_width asks to change the frame size, it has to
provide the new size in some way. In your particular case, it uses that
of _before_ the font change since Windows did not propagate the new
values back to us.
>> Now before my changes, (2) asked the window manager to change the pixel
>> size of the frame based on its line/column sizes multiplied by the
>> default font sizes. After my changes, (2) asks to change the pixel size
>> of the frame directly from the previously calculated pixel sizes.
>> However, since on Windows (1) does not record the change of the pixel
>> size caused by setting the font size, the request in (2) will be based
>> on the pixel size of the frame before (1) was issued.
>
> Good to understand. Thx. Not sure what that means in terms of trying
> to get my code to work properly with your new code (as well as with
> prior Emacs code). Concrete suggestions welcome.
I'm afraid there's not much you can do here.
>> I don't know how to fix this properly. IIUC Emacs cannot wait until
>> Windows passes the new sizes back to it in (1) just as it does on other
>> systems. The sit-for I proposed earlier could work around this. If
>> OTOH I restore the calculation for (2) to use the line/column values,
>> people who want to change the scrollbar width exactly by pixels are
>> lost.
>
> Are they necessarily lost, or is there some other way to accommodate both?
>
> BTW, as far as you can tell, is it just the scroll bar that is the problem
> (wrt my code)?
Hopefully, scrollbars on Windows are the only problem for you.
martin
next prev parent reply other threads:[~2013-12-12 18:10 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<8dee88e8-6b12-4822-9586-e013328f2ddc@default>
[not found] ` <<529CCE7F.3070400@gmx.at>
[not found] ` <<52A08780.9020405@gmx.at>
[not found] ` <<3df21358-48ca-4150-9f0e-aa2dbf78cbcb@default>
[not found] ` <<360e0ca4-7e4a-4f11-8157-c8f69e4ce913@default>
[not found] ` <<52A188D8.60608@gmx.at>
[not found] ` <<83txem1i7m.fsf@gnu.org>
2013-12-06 14:43 ` bug#16028: 24.3.50; Latest build completely breaks my thumnail frames code Drew Adams
2013-12-06 14:56 ` martin rudalics
2013-12-06 15:29 ` Drew Adams
2013-12-06 16:20 ` martin rudalics
2013-12-06 16:43 ` Drew Adams
2013-12-06 17:22 ` martin rudalics
2013-12-06 19:04 ` Drew Adams
2013-12-07 9:46 ` martin rudalics
2013-12-07 20:34 ` Drew Adams
2013-12-08 9:57 ` martin rudalics
2013-12-08 17:31 ` Drew Adams
2013-12-08 17:54 ` martin rudalics
2013-12-09 17:14 ` Eli Zaretskii
2013-12-09 18:37 ` martin rudalics
2013-12-10 3:53 ` Eli Zaretskii
2013-12-10 7:52 ` martin rudalics
2013-12-10 14:51 ` Drew Adams
2013-12-10 10:31 ` martin rudalics
2013-12-10 10:49 ` martin rudalics
2013-12-10 14:50 ` Drew Adams
2013-12-10 15:36 ` martin rudalics
2013-12-12 4:27 ` Drew Adams
2013-12-12 10:17 ` martin rudalics
2013-12-12 16:29 ` Drew Adams
2013-12-12 18:10 ` martin rudalics [this message]
2013-12-12 19:55 ` Drew Adams
2013-12-13 10:13 ` martin rudalics
2013-12-13 10:52 ` Eli Zaretskii
2013-12-13 16:00 ` Drew Adams
2013-12-13 17:24 ` martin rudalics
2013-12-13 18:05 ` Drew Adams
2013-12-13 18:23 ` martin rudalics
2013-12-12 16:38 ` Eli Zaretskii
2013-12-12 18:10 ` martin rudalics
2013-12-12 18:47 ` Eli Zaretskii
2013-12-13 10:12 ` martin rudalics
2013-12-13 10:51 ` Eli Zaretskii
2013-12-14 11:22 ` martin rudalics
2013-12-14 12:04 ` Eli Zaretskii
2013-12-14 13:45 ` martin rudalics
2013-12-14 14:09 ` Eli Zaretskii
2013-12-14 17:17 ` martin rudalics
2013-12-14 17:19 ` Eli Zaretskii
2013-12-14 17:23 ` martin rudalics
2013-12-16 10:12 ` martin rudalics
2013-12-16 15:06 ` Drew Adams
2013-12-15 0:43 ` Drew Adams
2014-02-10 4:07 ` Lars Ingebrigtsen
2014-02-10 4:29 ` Drew Adams
2013-12-10 15:31 ` martin rudalics
2013-12-10 16:41 ` Eli Zaretskii
2013-12-10 16:51 ` martin rudalics
2013-12-10 18:04 ` Eli Zaretskii
2013-12-10 18:57 ` martin rudalics
2013-12-06 18:22 ` Eli Zaretskii
2013-12-06 18:57 ` martin rudalics
2013-12-06 19:15 ` Eli Zaretskii
2013-12-07 9:46 ` martin rudalics
2013-12-07 11:15 ` Eli Zaretskii
2013-12-07 12:25 ` martin rudalics
2013-12-06 21:32 ` Stefan Monnier
2013-12-02 15:51 Drew Adams
2013-12-02 15:58 ` Drew Adams
2013-12-02 18:16 ` martin rudalics
2013-12-02 19:06 ` Drew Adams
2013-12-05 14:02 ` martin rudalics
2013-12-05 16:33 ` Drew Adams
2013-12-06 5:23 ` Drew Adams
2013-12-06 8:20 ` martin rudalics
2013-12-06 8:45 ` Eli Zaretskii
2013-12-06 14:32 ` martin rudalics
2013-12-06 14:13 ` Drew Adams
2013-12-06 14:32 ` martin rudalics
2013-12-06 14:44 ` Drew Adams
2013-12-06 0:11 ` Juanma Barranquero
2013-12-06 0:18 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9FC07.7040304@gmx.at \
--to=rudalics@gmx.at \
--cc=16028@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).