From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#16013: 24.3.50; Rows in height is interpreted as pixels. Date: Wed, 04 Dec 2013 19:06:26 +0100 Message-ID: <529F6F22.4020803@gmx.at> References: <5579FC36-5F75-4679-87F6-048C5B7326F6@swipnet.se> <5299FD88.2090600@gmx.at> <529A33F4.5030606@swipnet.se> <529B0519.3010902@gmx.at> <529B1C71.9020707@gmx.at> <529CCE48.9090404@gmx.at> <529D8F3E.30400@gmx.at> <93EF122E-7EFC-4ACF-A216-E83981DD511A@swipnet.se> <529E2441.8030808@gmx.at> <9E083836-7DF3-4AC3-8711-A0E4757C9691@swipnet.se> <01BCA22D-62F2-4F04-B14C-85452A9D1201@swipnet.se> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070803040809040404060501" X-Trace: ger.gmane.org 1386180439 18187 80.91.229.3 (4 Dec 2013 18:07:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Dec 2013 18:07:19 +0000 (UTC) Cc: "16013@debbugs.gnu.org" <16013@debbugs.gnu.org> To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 04 19:07:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VoGr5-0005S0-7C for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Dec 2013 19:07:23 +0100 Original-Received: from localhost ([::1]:49695 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoGr4-0008HI-NP for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Dec 2013 13:07:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoGqu-0008Fd-G3 for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 13:07:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoGqk-00061u-Ni for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 13:07:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoGqk-00061p-K6 for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 13:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VoGqk-00050r-E0 for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 13:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Dec 2013 18:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16013 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16013-submit@debbugs.gnu.org id=B16013.138618039919211 (code B ref 16013); Wed, 04 Dec 2013 18:07:02 +0000 Original-Received: (at 16013) by debbugs.gnu.org; 4 Dec 2013 18:06:39 +0000 Original-Received: from localhost ([127.0.0.1]:58297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VoGqM-0004zm-Rs for submit@debbugs.gnu.org; Wed, 04 Dec 2013 13:06:39 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:57337) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VoGqK-0004zc-OQ for 16013@debbugs.gnu.org; Wed, 04 Dec 2013 13:06:37 -0500 Original-Received: from [62.47.56.60] ([62.47.56.60]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LjquD-1VCj6A3yFF-00bsTN for <16013@debbugs.gnu.org>; Wed, 04 Dec 2013 19:06:36 +0100 In-Reply-To: <01BCA22D-62F2-4F04-B14C-85452A9D1201@swipnet.se> X-Provags-ID: V03:K0:4jglNkzR+gadiY9KoK7/jVPKAue7m93+dStruudZYPCLET9GmFi VypYajAZuiedF9TY88avxfL8F3RIuOFnQuMfsYQIeVJWL2bq0r/lPlR3Pi7ccYbbe9tquSr qLVhrj6cjL7b4LXRi6e6PxGgkp3f/yz8/rOPnZwSaiESMMkGTG6iAkCg4q0lAe8hazpqTvT NTS256ifCMWN25HVypESA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81384 Archived-At: This is a multi-part message in MIME format. --------------070803040809040404060501 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > Lucid/Motif: 46 rows, 74 columns on initial frame, > 50 rows, 80 columns on subsequent frames. I don't know which libraries are needed to build with Lucid. I installed open motif libraries but the build script doesn't appreciate them. So I can't test these here. At least the "subsequent frames" look correct. > No toolkit: 45 rows, 68 columns on initial frame, > 47 rows, 75 columns on subsequent frames. This can be fixed here using the attached patch. But with a frame width of 60 the echo area should resize but disappears on the initial frame. I don't yet know why. > Gtk+3 and 2: 49 rows, 80 columns on initial frame. > 49 rows, 80 columns on subsequent frames. martin --------------070803040809040404060501 Content-Type: text/plain; name="x_set_frame_size.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="x_set_frame_size.diff" === modified file 'src/xterm.c' --- src/xterm.c 2013-12-03 11:33:13 +0000 +++ src/xterm.c 2013-12-04 16:37:35 +0000 @@ -8552,12 +8552,15 @@ compute_fringe_widths (f, 0); - pixelwidth = - (pixelwise ? width : FRAME_TEXT_COLS_TO_PIXEL_WIDTH (f, width)) - + FRAME_TOOLBAR_WIDTH (f); - pixelheight = - (pixelwise ? height : FRAME_TEXT_LINES_TO_PIXEL_HEIGHT (f, height)) - + FRAME_MENUBAR_HEIGHT (f) + FRAME_TOOLBAR_HEIGHT (f); + pixelwidth = ((pixelwise + ? FRAME_TEXT_TO_PIXEL_WIDTH (f, width) + : FRAME_TEXT_COLS_TO_PIXEL_WIDTH (f, width)) + + FRAME_TOOLBAR_WIDTH (f)); + pixelheight = ((pixelwise + ? FRAME_TEXT_TO_PIXEL_HEIGHT (f, height) + : FRAME_TEXT_LINES_TO_PIXEL_HEIGHT (f, height)) + + FRAME_MENUBAR_HEIGHT (f) + + FRAME_TOOLBAR_HEIGHT (f)); if (change_gravity) f->win_gravity = NorthWestGravity; x_wm_set_size_hint (f, (long) 0, 0); @@ -8593,8 +8596,6 @@ else { change_frame_size (f, width, height, 0, 1, 0, 1); - FRAME_PIXEL_WIDTH (f) = pixelwidth; - FRAME_PIXEL_HEIGHT (f) = pixelheight; x_sync (f); } } --------------070803040809040404060501--