From: martin rudalics <rudalics@gmx.at>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: "16013@debbugs.gnu.org" <16013@debbugs.gnu.org>
Subject: bug#16013: 24.3.50; Rows in height is interpreted as pixels.
Date: Wed, 04 Dec 2013 19:06:26 +0100 [thread overview]
Message-ID: <529F6F22.4020803@gmx.at> (raw)
In-Reply-To: <01BCA22D-62F2-4F04-B14C-85452A9D1201@swipnet.se>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
> Lucid/Motif: 46 rows, 74 columns on initial frame,
> 50 rows, 80 columns on subsequent frames.
I don't know which libraries are needed to build with Lucid. I
installed open motif libraries but the build script doesn't appreciate
them. So I can't test these here. At least the "subsequent frames"
look correct.
> No toolkit: 45 rows, 68 columns on initial frame,
> 47 rows, 75 columns on subsequent frames.
This can be fixed here using the attached patch. But with a frame width
of 60 the echo area should resize but disappears on the initial frame.
I don't yet know why.
> Gtk+3 and 2: 49 rows, 80 columns on initial frame.
> 49 rows, 80 columns on subsequent frames.
martin
[-- Attachment #2: x_set_frame_size.diff --]
[-- Type: text/plain, Size: 1099 bytes --]
=== modified file 'src/xterm.c'
--- src/xterm.c 2013-12-03 11:33:13 +0000
+++ src/xterm.c 2013-12-04 16:37:35 +0000
@@ -8552,12 +8552,15 @@
compute_fringe_widths (f, 0);
- pixelwidth =
- (pixelwise ? width : FRAME_TEXT_COLS_TO_PIXEL_WIDTH (f, width))
- + FRAME_TOOLBAR_WIDTH (f);
- pixelheight =
- (pixelwise ? height : FRAME_TEXT_LINES_TO_PIXEL_HEIGHT (f, height))
- + FRAME_MENUBAR_HEIGHT (f) + FRAME_TOOLBAR_HEIGHT (f);
+ pixelwidth = ((pixelwise
+ ? FRAME_TEXT_TO_PIXEL_WIDTH (f, width)
+ : FRAME_TEXT_COLS_TO_PIXEL_WIDTH (f, width))
+ + FRAME_TOOLBAR_WIDTH (f));
+ pixelheight = ((pixelwise
+ ? FRAME_TEXT_TO_PIXEL_HEIGHT (f, height)
+ : FRAME_TEXT_LINES_TO_PIXEL_HEIGHT (f, height))
+ + FRAME_MENUBAR_HEIGHT (f)
+ + FRAME_TOOLBAR_HEIGHT (f));
if (change_gravity) f->win_gravity = NorthWestGravity;
x_wm_set_size_hint (f, (long) 0, 0);
@@ -8593,8 +8596,6 @@
else
{
change_frame_size (f, width, height, 0, 1, 0, 1);
- FRAME_PIXEL_WIDTH (f) = pixelwidth;
- FRAME_PIXEL_HEIGHT (f) = pixelheight;
x_sync (f);
}
}
next prev parent reply other threads:[~2013-12-04 18:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 13:08 bug#16013: 24.3.50; Rows in height is interpreted as pixels Jan Djärv
2013-11-30 15:00 ` martin rudalics
2013-11-30 18:52 ` Jan Djärv
2013-12-01 9:44 ` martin rudalics
2013-12-01 10:01 ` Jan Djärv
2013-12-01 11:24 ` martin rudalics
2013-12-01 12:02 ` Jan Djärv
2013-12-02 18:15 ` martin rudalics
2013-12-02 22:03 ` Stephen Berman
2013-12-03 7:56 ` martin rudalics
2013-12-03 9:13 ` Stephen Berman
2013-12-03 18:34 ` martin rudalics
2013-12-03 20:02 ` Stephen Berman
2013-12-03 7:53 ` Jan Djärv
2013-12-03 7:58 ` martin rudalics
2013-12-03 16:30 ` Jan Djärv
2013-12-03 18:34 ` martin rudalics
2013-12-03 19:30 ` Jan Djärv
2013-12-03 19:45 ` Jan Djärv
2013-12-04 18:06 ` martin rudalics [this message]
2013-12-07 17:53 ` Jan Djärv
2013-12-07 18:09 ` martin rudalics
2013-12-09 18:26 ` martin rudalics
2014-01-11 14:01 ` martin rudalics
2014-01-11 17:46 ` Jan Djärv
2014-01-12 9:54 ` martin rudalics
2014-01-12 11:13 ` Jan Djärv
2014-01-12 11:46 ` martin rudalics
2014-01-12 20:25 ` Stefan Monnier
2014-01-12 22:21 ` Jan Djärv
2014-01-14 17:30 ` Jan Djärv
2014-01-14 18:10 ` martin rudalics
2014-01-16 10:03 ` martin rudalics
2014-01-16 10:14 ` martin rudalics
2014-01-18 11:30 ` Jan Djärv
2014-01-18 12:07 ` martin rudalics
2014-01-29 10:14 ` martin rudalics
2020-09-09 13:07 ` Lars Ingebrigtsen
2020-09-09 14:46 ` Eli Zaretskii
2020-09-10 12:40 ` Lars Ingebrigtsen
2013-12-04 18:06 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529F6F22.4020803@gmx.at \
--to=rudalics@gmx.at \
--cc=16013@debbugs.gnu.org \
--cc=jan.h.d@swipnet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).