bug#16033: 24.3.50; window--reseize-this-window, args-out-of-range

bug#16033: 24.3.50; window--reseize-this-window, args-out-of-range

[Yagnesh Raghava Yakkala]

Latest build from emacs
trunk(yamaoka@jpl.org-20131203045417-2co55ww8uqmoh5cb) I get the
following backtrace.

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (args-out-of-range -19 0 2147483001)
  set-window-new-pixel(#<window 3 on *scratch*> -19 t)
  window--resize-this-window(#<window 3 on *scratch*> -19 nil nil t before 646)
  window--resize-root-window-vertically(#<window 3 on *scratch*> -19 t)
  message("Searching for `%s'...." "{emacs/ | README.org | be | be-functions | be.conf | gdb-emacs | gdb.bt | post-build-hook | .gitignore} [No match]")
  ido-make-merged-file-list("{emacs/ | README.org | be | be-functions | be.conf | gdb-emacs | gdb.bt | post-build-hook | .gitignore} [No match]" t nil)
  ido-read-internal(file "Find file: " ido-file-history nil confirm-after-completion nil)
  ido-file-internal(raise-frame)
  ido-find-file()
  call-interactively(ido-find-file nil nil)
  command-execute(ido-find-file)
  --8<---------------cut here---------------end--------------->8---


To reproduce:
emacs -Q
M-x ido-mode
M-x toggle-debug-on-error
C-x C-f

In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
 of 2013-12-03 on sealion
Windowing system distributor `The X.Org Foundation', version 11.0.11103000
System Description:	Ubuntu 12.04.3 LTS

Configured using:
 `configure --prefix=/home/yagnesh/local/emacs-3689076 --enable-checking
 --without-compress-info 'CFLAGS=-g -O0''

Important settings:
  value of $LC_MONETARY: en_IN.UTF-8
  value of $LC_NUMERIC: en_IN.UTF-8
  value of $LC_TIME: en_IN.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Debugger

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x e l - <backspace> <backspace> <backspace> i d o 
- m o <tab> <return> M-x t o g g l <tab> d e <tab> 
e r <tab> <return> C-x C-f C-x o C-x o C-x o C-a C-SPC 
M-> M-w M-x r e p <tab> o <tab> r <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Ido mode enabled
Debug on Error enabled globally
Entering debugger...
window--resize-this-window: Args out of range: -19, 0, 2147483001
Searching for `{emacs/ | README.org | be | be-functions | be.conf | gdb-emacs | gdb.bt | post-build-hook | .gitignore} [No match]'....
Entering debugger...
Mark set
Making completion list... [2 times]

Load-path shadows:
Error during checking
Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils help-mode easymenu debug cus-start cus-load ido
time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode prog-mode register page menu-bar
rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind gfilenotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty emacs)

-- 
ఎందరో మహానుభావులు అందరికి వందనములు.
YYR

bug#16033: 24.3.50; window--reseize-this-window, args-out-of-range

[Eli Zaretskii]

> From: Yagnesh Raghava Yakkala <hi@yagnesh.org>
> Date: Tue, 03 Dec 2013 15:26:51 +0900
> 
> 
> Latest build from emacs
> trunk(yamaoka@jpl.org-20131203045417-2co55ww8uqmoh5cb) I get the
> following backtrace.
> 
> --8<---------------cut here---------------start------------->8---
> Debugger entered--Lisp error: (args-out-of-range -19 0 2147483001)
>   set-window-new-pixel(#<window 3 on *scratch*> -19 t)
>   window--resize-this-window(#<window 3 on *scratch*> -19 nil nil t before 646)

Paul, it's because of your commit:

  revno: 115359
  committer: Paul Eggert <eggert@cs.ucla.edu>
  branch nick: trunk
  timestamp: Tue 2013-12-03 02:27:10 +0000
  message:
    Minor integer overflow fixes.

    * window.c (Fset_window_new_pixel, grow_mini_window):
    * xdisp.c (Fwindow_text_pixel_size):
    Avoid undefined behavior on signed integer overflow.
    * xfns.c (x_set_mouse_color):
    Check that drag shape fits in 'unsigned', since that's what X wants.

The modified test at the beginning of Fset_window_new_pixel doesn't
DTRT when SIZE is negative (which it legitimately can be when ADD is
non-nil).

bug#16033: 24.3.50; window--reseize-this-window, args-out-of-range

[martin rudalics]

> The modified test at the beginning of Fset_window_new_pixel doesn't
> DTRT when SIZE is negative (which it legitimately can be when ADD is
> non-nil).

I checked in a fix.  Please have a look.

Thanks, martin

bug#16033: 24.3.50; window--reseize-this-window, args-out-of-range

[Yagnesh Raghava Yakkala]

Hello Martin,

On Dec 03 2013, martin rudalics <rudalics@gmx.at> wrote:

>> The modified test at the beginning of Fset_window_new_pixel doesn't
>> DTRT when SIZE is negative (which it legitimately can be when ADD is
>> non-nil).
>
> I checked in a fix.  Please have a look.

Thanks, I rebuilt now and its working fine now. 

Please close the bug.
-- 
ఎందరో మహానుభావులు అందరికి వందనములు.
YYR

bug#16033: 24.3.50; window--reseize-this-window, args-out-of-range

[martin rudalics]

> Thanks, I rebuilt now and its working fine now. 
> 
> Please close the bug.

Done.

Thanks for the report, martin

bug#16033: 24.3.50; window--reseize-this-window, args-out-of-range

[Paul Eggert]

On 12/02/2013 11:56 PM, martin rudalics wrote:
> I checked in a fix.  Please have a look. 

Thanks for the quick fix!  I installed what I hope is
an improved version, in trunk bzr 115366.  My assumption
is that new_pixel must be nonnegative (even though the
increment to new_pixel is allowed to be negative);
if this is wrong please let me know.

bug#16033: 24.3.50; window--reseize-this-window, args-out-of-range

[martin rudalics]

 > Thanks for the quick fix!

I just mimicked what you did for positive values.

 > I installed what I hope is
 > an improved version, in trunk bzr 115366.  My assumption
 > is that new_pixel must be nonnegative (even though the
 > increment to new_pixel is allowed to be negative);
 > if this is wrong please let me know.

Your assumption is correct.

martin