From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#15912: Improve API of recently-added bool vector functions. Date: Mon, 18 Nov 2013 11:44:56 -0800 Organization: UCLA Computer Science Department Message-ID: <528A6E38.6020502@cs.ucla.edu> References: <528880AA.2020401@cs.ucla.edu> <5288A35C.8090704@dancol.org> <5289245C.3050806@cs.ucla.edu> <528926D9.3090205@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1384803979 15809 80.91.229.3 (18 Nov 2013 19:46:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Nov 2013 19:46:19 +0000 (UTC) To: dancol@dancol.org, 15912@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 18 20:46:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ViUm6-0000fG-TO for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Nov 2013 20:46:23 +0100 Original-Received: from localhost ([::1]:45620 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViUm6-00024S-HM for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Nov 2013 14:46:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViUlw-0001tX-00 for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 14:46:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViUlm-0001bA-If for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 14:46:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViUlm-0001b4-FJ for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 14:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ViUlm-0003Jn-24 for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 14:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Nov 2013 19:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15912 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Daniel Colascione , bug-emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.138480392812694 (code B ref -1); Mon, 18 Nov 2013 19:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Nov 2013 19:45:28 +0000 Original-Received: from localhost ([127.0.0.1]:60404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ViUlD-0003If-T0 for submit@debbugs.gnu.org; Mon, 18 Nov 2013 14:45:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56738) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ViUl9-0003IO-It for submit@debbugs.gnu.org; Mon, 18 Nov 2013 14:45:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViUkx-0001Uu-HP for submit@debbugs.gnu.org; Mon, 18 Nov 2013 14:45:18 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:47509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViUkx-0001Uq-Ed for submit@debbugs.gnu.org; Mon, 18 Nov 2013 14:45:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViUkr-00013Y-Ch for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 14:45:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViUkl-0001Bn-Hv for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 14:45:05 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:55399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViUkl-0001BY-9o for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 14:44:59 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 822A039E8116; Mon, 18 Nov 2013 11:44:58 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yM9Gv6WyupAf; Mon, 18 Nov 2013 11:44:57 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 9911F39E810E; Mon, 18 Nov 2013 11:44:56 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 In-Reply-To: <528926D9.3090205@dancol.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80739 Archived-At: On 11/17/2013 12:28 PM, Daniel Colascione wrote: > the revised patch is fine Thanks, installed as trunk bzr 15912. I noticed another problem. bool-vector-subset-p is backwards of what I'd normally expect, i.e., (bool-vector-subsetp A B) tests whether B is a subset of A, not whether A is a subset of B. Another thing: it might be more intuitive if this function returns a boolean. Also, this function isn't documented. One possibility is to remove the function if nobody's using it; another possibility would be the following patch. === modified file 'src/ChangeLog' --- src/ChangeLog 2013-11-18 19:31:05 +0000 +++ src/ChangeLog 2013-11-18 19:43:41 +0000 @@ -1,5 +1,10 @@ 2013-11-18 Paul Eggert + bool-vector-subsetp is now the normal direction and returns a boolean. + * data.c (bool_vector_binop_driver): When implementing subsetp, + test whether the first argument is a subset of the second one, + and return t or nil. Tune. + * data.c (bool_vector_binop_driver): Rename locals for sanity's sake. The old names predated the API change that put destination at end. === modified file 'src/data.c' --- src/data.c 2013-11-18 19:31:05 +0000 +++ src/data.c 2013-11-18 19:43:41 +0000 @@ -3060,6 +3060,12 @@ break; case bool_vector_subsetp: + eassert (bdata == destdata); + while (! (adata[i] & ~bdata[i])) + if (! (++i < nr_words)) + return Qt; + return Qnil; + case bool_vector_union: while (destdata[i] == (adata[i] | bdata[i])) if (! (++i < nr_words)) @@ -3088,9 +3094,6 @@ while (++i < nr_words); break; - case bool_vector_subsetp: - break; - case bool_vector_union: do destdata[i] = adata[i] | bdata[i]; @@ -3108,6 +3111,9 @@ destdata[i] = adata[i] &~ bdata[i]; while (++i < nr_words); break; + + default: + eassume (0); } return dest; @@ -3234,11 +3240,11 @@ DEFUN ("bool-vector-subsetp", Fbool_vector_subsetp, Sbool_vector_subsetp, 2, 2, 0, - doc: ) + doc: /* Return t if every t value in A is also t in B, nil otherwise. +A and B must be bool vectors of the same length. */) (Lisp_Object a, Lisp_Object b) { - /* Like bool_vector_union, but doesn't modify b. */ - return bool_vector_binop_driver (b, a, b, bool_vector_subsetp); + return bool_vector_binop_driver (a, b, b, bool_vector_subsetp); } DEFUN ("bool-vector-not", Fbool_vector_not,