From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ryan Newsgroups: gmane.emacs.bugs Subject: bug#3984: Date: Thu, 19 Sep 2013 21:23:23 -0700 Message-ID: <523BCDBB.3000202@thompsonclan.org> References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <5232D333.8030206@thompsonclan.org> <523359CD.2070904@thompsonclan.org> <5233670E.4030703@thompsonclan.org> <5237C9FF.1000809@thompsonclan.org> <52388FEB.6020007@thompsonclan.org> <523A37A4.5060505@thompsonclan.org> <523A49BE.3060109@thompsonclan.org> <523AB06B.9090606@thompsonclan.org> <523B4F4E.3060204@thompsonclan.org> <523B73CF.4080105@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1379651059 13074 80.91.229.3 (20 Sep 2013 04:24:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Sep 2013 04:24:19 +0000 (UTC) Cc: 3984@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 20 06:24:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VMsGT-0004sw-AV for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2013 06:24:21 +0200 Original-Received: from localhost ([::1]:54048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMsGS-000878-OM for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2013 00:24:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMsGI-000864-Iz for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 00:24:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMsGB-0007pZ-AK for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 00:24:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMsGB-0007pV-6i for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 00:24:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VMsGA-0007Sm-HF for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 00:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ryan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2013 04:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3984-submit@debbugs.gnu.org id=B3984.137965101928652 (code B ref 3984); Fri, 20 Sep 2013 04:24:02 +0000 Original-Received: (at 3984) by debbugs.gnu.org; 20 Sep 2013 04:23:39 +0000 Original-Received: from localhost ([127.0.0.1]:50494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMsFm-0007S3-AQ for submit@debbugs.gnu.org; Fri, 20 Sep 2013 00:23:38 -0400 Original-Received: from mail-pd0-f171.google.com ([209.85.192.171]:34633) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMsFj-0007Rq-CI for 3984@debbugs.gnu.org; Fri, 20 Sep 2013 00:23:35 -0400 Original-Received: by mail-pd0-f171.google.com with SMTP id g10so9219561pdj.2 for <3984@debbugs.gnu.org>; Thu, 19 Sep 2013 21:23:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=8cMy5Sdsg+kR4EtJBenSCZagj1TuLGwhOZRO8t78ClA=; b=kzz5S1TVU/b1jFGKYwtIs/U+2aVboE4Q99HOpr5pu6HQPLfNALicGgxIPQnNLjeUn9 MGmUqHrYwrPYqPg3PhRa/LizMmhhgoR12mp3qg9YZlfFx0uZi4ewzm605bYtxR/ooB1r tYYidCAwi60AKUToMDttBxx7OeDhQaUJMIoV90+nNidIi9esv/IZQSU5NPLCaGA3d8ai HV2XpBogVgs8i2QZ4OD+i5pw76h2dQIZf3o9Jv/p2siNs4uirel+nrEYERxdkQhjMIh5 HaI1Uim/5zRZfJpIUX5kgAnE9p1r3CVTthudWZWu/8lCpPB4srX5UJPzmDnwTte0qukj YgFQ== X-Gm-Message-State: ALoCoQl+PFbOfDDkIfb5AUr5GnnCTT91l2UGulrD7QapBNr0RwtB6bdv2xBdNQK0UZb3TxNfuJLt X-Received: by 10.66.218.226 with SMTP id pj2mr6576006pac.62.1379651009537; Thu, 19 Sep 2013 21:23:29 -0700 (PDT) Original-Received: from [192.168.10.2] (user-0c9ha1q.cable.mindspring.com. [24.152.168.58]) by mx.google.com with ESMTPSA id bb1sm12895780pbc.10.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Sep 2013 21:23:27 -0700 (PDT) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 In-Reply-To: <523B73CF.4080105@thompsonclan.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78597 Archived-At: After a little more consideration, I think I know what the bug is. The goal of "advice--called-interactively-skip" is to skip all the advice-related stack frames of the called function, not advice-related stack frames for advice on call-interactively. I also came up with an idea to address this issue: a second function added to called-interactively-p-functions that checks the current stack frame for equality to the unadvised form of call-interactively and if it finds it, skips past all the advice frames to the outermost call. This will make it so that advising call-interactively does not affect the return of called-interactively-p, but it will not fix the "innermost around advice" problem. I'm trying to code up a solution now. I'll eventually find my way through the twisty maze of fencepost errors. -Ryan