From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ryan Newsgroups: gmane.emacs.bugs Subject: bug#3984: Date: Thu, 19 Sep 2013 14:59:43 -0700 Message-ID: <523B73CF.4080105@thompsonclan.org> References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <5232D333.8030206@thompsonclan.org> <523359CD.2070904@thompsonclan.org> <5233670E.4030703@thompsonclan.org> <5237C9FF.1000809@thompsonclan.org> <52388FEB.6020007@thompsonclan.org> <523A37A4.5060505@thompsonclan.org> <523A49BE.3060109@thompsonclan.org> <523AB06B.9090606@thompsonclan.org> <523B4F4E.3060204@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080203060909030805010104" X-Trace: ger.gmane.org 1379628029 21212 80.91.229.3 (19 Sep 2013 22:00:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Sep 2013 22:00:29 +0000 (UTC) Cc: 3984@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 20 00:00:31 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VMmGx-0007kN-St for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2013 00:00:28 +0200 Original-Received: from localhost ([::1]:53307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMmGx-000803-Jo for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Sep 2013 18:00:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMmGn-0007yh-7e for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 18:00:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMmGb-00084u-CU for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 18:00:17 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMmGb-00082O-9S for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 18:00:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VMmGZ-0005Wn-M4 for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 18:00:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ryan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Sep 2013 22:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3984-submit@debbugs.gnu.org id=B3984.137962799821205 (code B ref 3984); Thu, 19 Sep 2013 22:00:03 +0000 Original-Received: (at 3984) by debbugs.gnu.org; 19 Sep 2013 21:59:58 +0000 Original-Received: from localhost ([127.0.0.1]:50083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMmGS-0005Vw-CK for submit@debbugs.gnu.org; Thu, 19 Sep 2013 17:59:57 -0400 Original-Received: from mail-pb0-f51.google.com ([209.85.160.51]:54505) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMmGP-0005Vi-Ft for 3984@debbugs.gnu.org; Thu, 19 Sep 2013 17:59:54 -0400 Original-Received: by mail-pb0-f51.google.com with SMTP id jt11so8962819pbb.10 for <3984@debbugs.gnu.org>; Thu, 19 Sep 2013 14:59:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=bfdfav5zjA+cUD4OVDuVtlmILB4DIRcw7Ig9J72xG3g=; b=akU0do8WAoYjYVjkrBT5vUVA4jjVroscrvme94CWZDyMjTk6cPj5Af7Pgb5H4AyOaM jYmvncpc02OfpJpf2RjJaSOr4K0MeBMg7gRKzXfsP30ISYv7fLMvd/8Uu1KrEbnIoRdb ZJN7bB4g+nxfZIkLV7FJqjnJXTR+SwaQ/hifF2itlywYTpx5HtJ9IaRfiMlTSfI8jNux Zw/rzEZfq51d5DStdzF4fbwPDPLljzjOqrWtxVHSyZr2a4PsV1GYvIhpuXWPylHxh5b2 uVO40Jdy9wiuLW+73YxYyrS8CkIgL9gbqsOWxd+iQN2I3AXeYSMBUJura/Es5HSJKYRI nD4A== X-Gm-Message-State: ALoCoQk2+moZbVII7OoKnBDs6Y0nPXvz4rKdfYQxECb8YiTpCZoctgvD3yggIVn4ZEgsHg4ccJuy X-Received: by 10.68.179.65 with SMTP id de1mr4208091pbc.73.1379627987500; Thu, 19 Sep 2013 14:59:47 -0700 (PDT) Original-Received: from [192.168.10.2] (user-0c9ha1q.cable.mindspring.com. [24.152.168.58]) by mx.google.com with ESMTPSA id nj9sm11459370pbc.13.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Sep 2013 14:59:46 -0700 (PDT) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 In-Reply-To: <523B4F4E.3060204@thompsonclan.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78595 Archived-At: This is a multi-part message in MIME format. --------------080203060909030805010104 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On Thu Sep 19 12:23:58 2013, Ryan wrote: > > On a related note, I just noticed that the > "advice-test-called-interactively-p" test in > test/automated/advice-tests.el happens to pass, but only because it > doesn't use "called-interactively-p" inside the original function, but > rather only inside the advice itself. Also, it doesn't test advising > "call-interactively" itself. I think I will see about writing a proper > test first, and then use that to start debugging. > Ok, I have written a couple of tests, two of which are currently failing (mine are the ones with numbered suffixes 2 through 5). I am attaching a patch that adds these tests. ERT output is below: $ open . techne:emacs-trunk ryan$ src/emacs -batch -Q -l ert -l test/automated/advice-tests.el -f ert-run-tests-batch-and-exit Running 10 tests (2013-09-19 14:56:00-0700) passed 1/10 advice-test-called-interactively-p failed 2/10 advice-test-called-interactively-p-2 passed 3/10 advice-test-called-interactively-p-3 failed 4/10 advice-test-called-interactively-p-4 passed 5/10 advice-test-called-interactively-p-5 passed 6/10 advice-test-interactive passed 7/10 advice-test-preactivate ad-handle-definition: `sm-test2' got redefined ad-handle-definition: `sm-test4' got redefined passed 8/10 advice-tests-advice ad-handle-definition: `sm-test5' got redefined passed 9/10 advice-tests-combination passed 10/10 advice-tests-nadvice Ran 10 tests, 10 results as expected (2013-09-19 14:56:00-0700) 2 expected failures --------------080203060909030805010104 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="more-advice-interactive-tests.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="more-advice-interactive-tests.diff" ZGlmZiAtLWdpdCBhL3Rlc3QvYXV0b21hdGVkL2FkdmljZS10ZXN0cy5lbCBiL3Rlc3QvYXV0 b21hdGVkL2FkdmljZS10ZXN0cy5lbAppbmRleCA2OWMxNWUzLi42NTU3N2FkIDEwMDY0NAot LS0gYS90ZXN0L2F1dG9tYXRlZC9hZHZpY2UtdGVzdHMuZWwKKysrIGIvdGVzdC9hdXRvbWF0 ZWQvYWR2aWNlLXRlc3RzLmVsCkBAIC0yMyw2ICsyMywyMSBAQAogCiAocmVxdWlyZSAnZXJ0 KQogCisoZGVmdW4gY2xlYXItYWR2aWNlIChzeW1ib2wpCisgICJSZXNldCBTWU1CT0wncyBm dW5jdGlvbiB0byBpdHMgb3JpZ2luYWwgdW5hZHZpc2VkIGRlZmluaXRpb24uIgorICAobGV0 ICgoZnVuYyAoc3ltYm9sLWZ1bmN0aW9uIHN5bWJvbCkpKQorICAgICh3aGlsZSAoYWR2aWNl LS1wIGZ1bmMpCisgICAgICAoc2V0cSBmdW5jIChhZHZpY2UtLWNkciBmdW5jKSkpCisgICAg KGZzZXQgc3ltYm9sIGZ1bmMpKSkKKworKGRlZm1hY3JvIHBvc3QtcmVzdG9yZS1mdW5jIChm dW5jICZyZXN0IGJvZHkpCisgIChsZXQgKChmZGVmIChzeW1ib2wtZnVuY3Rpb24gZnVuYykp KQorICAgIGAodW53aW5kLXByb3RlY3QKKwkgKHByb2duICxAYm9keSkKKyAgICAgICAoZnNl dCAnLGZ1bmMgLGZkZWYpKSkpCisocHV0ICdwb3N0LXJlc3RvcmUtZnVuYyAnbGlzcC1pbmRl bnQtZnVuY3Rpb24KKyAgICAgKGdldCAncHJvZzEgJ2xpc3AtaW5kZW50LWZ1bmN0aW9uKSkK KwogKGVydC1kZWZ0ZXN0IGFkdmljZS10ZXN0cy1uYWR2aWNlICgpCiAgICJUZXN0IG5hZHZp Y2UgY29kZS4iCiAgIChkZWZ1biBzbS10ZXN0MSAoeCkgKCsgeCA0KSkKQEAgLTExMyw2ICsx MjgsNjAgQEAKICAgICAgICAgICAgICAgICAoY29ucyAoY29ucyAyIChjYWxsZWQtaW50ZXJh Y3RpdmVseS1wKSkgKGFwcGx5IGYgYXJncykpKSkKICAgKHNob3VsZCAoZXF1YWwgKGNhbGwt aW50ZXJhY3RpdmVseSAnc20tdGVzdDcpICcoKDIgLiB0KSAoMSAuIHQpIDExKSkpKQogCiso ZXJ0LWRlZnRlc3QgYWR2aWNlLXRlc3QtY2FsbGVkLWludGVyYWN0aXZlbHktcC0yICgpCisg ICJDaGVjayBpbnRlcmFjdGlvbiBiZXR3ZWVuIGFyb3VuZCBhZHZpY2UgYW5kIGNhbGxlZC1p bnRlcmFjdGl2ZWx5LXAuCisKK1RoaXMgdGVzdHMgdGhlIGN1cnJlbnRseSBicm9rZW4gY2Fz ZSBvZiB0aGUgaW5uZXJtb3N0IGFkdmljZSB0byBhCitmdW5jdGlvbiBiZWluZyBhbiBhcm91 bmQgYWR2aWNlLiIKKyAgOmV4cGVjdGVkLXJlc3VsdCA6ZmFpbGVkCisgIChkZWZ1biBzbS10 ZXN0Ny4yICgpIChpbnRlcmFjdGl2ZSkgKGNvbnMgMSAoY2FsbGVkLWludGVyYWN0aXZlbHkt cCkpKQorICAoY2xlYXItYWR2aWNlICdzbS10ZXN0Ny4yKQorICAoYWR2aWNlLWFkZCAnc20t dGVzdDcuMiA6YXJvdW5kCisgICAgICAgICAgICAgIChsYW1iZGEgKGYgJnJlc3QgYXJncykK KyAgICAgICAgICAgICAgICAobGlzdCAoY29ucyAxIChjYWxsZWQtaW50ZXJhY3RpdmVseS1w KSkgKGFwcGx5IGYgYXJncykpKSkKKyAgKGFkdmljZS1hZGQgJ3NtLXRlc3Q3LjIgOmJlZm9y ZSAjJ2lnbm9yZSkKKyAgKGFkdmljZS1hZGQgJ3NtLXRlc3Q3LjIgOmFmdGVyICMnaWdub3Jl KQorICA7KGFkdmljZS1hZGQgJ3NtLXRlc3Q3LjIgOmZpbHRlci1hcmdzICMnbGlzdCkKKyAg OyhhZHZpY2UtYWRkICdzbS10ZXN0Ny4yIDpmaWx0ZXItcmV0dXJuICMnaWRlbnRpdHkpCisg IChzaG91bGQgKGVxdWFsIChzbS10ZXN0Ny4yKSAnKCgxIC4gbmlsKSAoMSAuIG5pbCkpKSkK KyAgKHNob3VsZCAoZXF1YWwgKGNhbGwtaW50ZXJhY3RpdmVseSAnc20tdGVzdDcuMikgJygo MSAuIHQpICgxIC4gdCkpKSkpCisKKyhlcnQtZGVmdGVzdCBhZHZpY2UtdGVzdC1jYWxsZWQt aW50ZXJhY3RpdmVseS1wLTMgKCkKKyAgIkNoZWNrIGludGVyYWN0aW9uIGJldHdlZW4gYmVm b3JlIGFkdmljZSBhbmQgY2FsbGVkLWludGVyYWN0aXZlbHktcC4KKworVGhpcyB0ZXN0cyB0 aGUgY2FzZSBvZiB0aGUgaW5uZXJtb3N0IGFkdmljZSBiZWluZyBiZWZvcmUiCisgIChkZWZ1 biBzbS10ZXN0Ny4zICgpIChpbnRlcmFjdGl2ZSkgKGNvbnMgMSAoY2FsbGVkLWludGVyYWN0 aXZlbHktcCkpKQorICAoYWR2aWNlLWFkZCAnc20tdGVzdDcuMyA6YmVmb3JlICMnaWdub3Jl KQorICA7KGFkdmljZS1hZGQgJ3NtLXRlc3Q3LjMgOmZpbHRlci1hcmdzICMnbGlzdCkKKyAg OyhhZHZpY2UtYWRkICdzbS10ZXN0Ny4zIDpmaWx0ZXItcmV0dXJuICMnaWRlbnRpdHkpCisg IChzaG91bGQgKGVxdWFsIChzbS10ZXN0Ny4zKSAnKDEgLiBuaWwpKSkKKyAgKHNob3VsZCAo ZXF1YWwgKGNhbGwtaW50ZXJhY3RpdmVseSAnc20tdGVzdDcuMykgJygxIC4gdCkpKSkKKwor KGVydC1kZWZ0ZXN0IGFkdmljZS10ZXN0LWNhbGxlZC1pbnRlcmFjdGl2ZWx5LXAtNCAoKQor ICAiQ2hlY2sgaW50ZXJhY3Rpb24gYmV0d2VlbiBhZHZpY2Ugb24gY2FsbC1pbnRlcmFjdGl2 ZWx5IGFuZCBjYWxsZWQtaW50ZXJhY3RpdmVseS1wLgorCitUaGlzIHRlc3RzIHRoZSBjYXNl IHdoZXJlIGNhbGwtaW50ZXJhY3RpdmVseSBpdHNlbGYgaXMgYWR2aXNlZCwKK3doaWNoIGlz IGN1cnJlbnRseSBicm9rZW4uIgorICA6ZXhwZWN0ZWQtcmVzdWx0IDpmYWlsZWQKKyAgKGRl ZnVuIHNtLXRlc3Q3LjQgKCkgKGludGVyYWN0aXZlKSAoY29ucyAxIChjYWxsZWQtaW50ZXJh Y3RpdmVseS1wKSkpCisgIChwb3N0LXJlc3RvcmUtZnVuYyBjYWxsLWludGVyYWN0aXZlbHkK KyAgICAoYWR2aWNlLWFkZCAnY2FsbC1pbnRlcmFjdGl2ZWx5IDpiZWZvcmUgIydpZ25vcmUp CisgICAgKHNob3VsZCAoZXF1YWwgKHNtLXRlc3Q3LjQpICcoMSAuIG5pbCkpKQorICAgIChz aG91bGQgKGVxdWFsIChjYWxsLWludGVyYWN0aXZlbHkgJ3NtLXRlc3Q3LjQpICcoMSAuIHQp KSkpKQorCisoZXJ0LWRlZnRlc3QgYWR2aWNlLXRlc3QtY2FsbGVkLWludGVyYWN0aXZlbHkt cC01ICgpCisgICJDaGVjayBpbnRlcmFjdGlvbiBiZXR3ZWVuIG5vbi1pbm5lcm1vc3QgYXJv dW5kIGFkdmljZSBhbmQgY2FsbGVkLWludGVyYWN0aXZlbHktcC4KKworVGhpcyB0ZXN0cyB0 aGUgY2FzZSB3aGVyZSBhIGZ1bmN0aW9uIGhhcyBhcm91bmQgYWR2aWNlLCBidXQgaXQgaXMK K25vdCB0aGUgaW5uZXJtb3N0IGFkdmljZS4iCisgIChkZWZ1biBzbS10ZXN0Ny41ICgpIChp bnRlcmFjdGl2ZSkgKGNvbnMgMSAoY2FsbGVkLWludGVyYWN0aXZlbHktcCkpKQorICAoYWR2 aWNlLWFkZCAnc20tdGVzdDcuNSA6YmVmb3JlICMnaWdub3JlKQorICAoYWR2aWNlLWFkZCAn c20tdGVzdDcuNSA6YXJvdW5kICMnZnVuY2FsbCkKKyAgOyhhZHZpY2UtYWRkICdzbS10ZXN0 Ny41IDpmaWx0ZXItYXJncyAjJ2xpc3QpCisgIDsoYWR2aWNlLWFkZCAnc20tdGVzdDcuNSA6 ZmlsdGVyLXJldHVybiAjJ2lkZW50aXR5KQorICAoc2hvdWxkIChlcXVhbCAoc20tdGVzdDcu NSkgJygxIC4gbmlsKSkpCisgIChzaG91bGQgKGVxdWFsIChjYWxsLWludGVyYWN0aXZlbHkg J3NtLXRlc3Q3LjUpICcoMSAuIHQpKSkpCisKIChlcnQtZGVmdGVzdCBhZHZpY2UtdGVzdC1p bnRlcmFjdGl2ZSAoKQogICAiQ2hlY2sgaGFuZGxpbmcgb2YgaW50ZXJhY3RpdmUgc3BlYy4i CiAgIChkZWZ1biBzbS10ZXN0OCAoYSkgKGludGVyYWN0aXZlICJwIikgYSkK --------------080203060909030805010104--