From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ryan Newsgroups: gmane.emacs.bugs Subject: bug#3984: Date: Thu, 19 Sep 2013 12:23:58 -0700 Message-ID: <523B4F4E.3060204@thompsonclan.org> References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <5232D333.8030206@thompsonclan.org> <523359CD.2070904@thompsonclan.org> <5233670E.4030703@thompsonclan.org> <5237C9FF.1000809@thompsonclan.org> <52388FEB.6020007@thompsonclan.org> <523A37A4.5060505@thompsonclan.org> <523A49BE.3060109@thompsonclan.org> <523AB06B.9090606@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1379618722 13278 80.91.229.3 (19 Sep 2013 19:25:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Sep 2013 19:25:22 +0000 (UTC) Cc: 3984@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 19 21:25:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VMjqt-0002G7-6L for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Sep 2013 21:25:23 +0200 Original-Received: from localhost ([::1]:52772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMjqs-0002B8-PU for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Sep 2013 15:25:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMjqi-00026H-JL for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 15:25:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMjqa-0004SA-Rw for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 15:25:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMjqa-0004Ra-PR for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 15:25:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VMjqZ-0001jT-P2 for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 15:25:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ryan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Sep 2013 19:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3984-submit@debbugs.gnu.org id=B3984.13796186496570 (code B ref 3984); Thu, 19 Sep 2013 19:25:03 +0000 Original-Received: (at 3984) by debbugs.gnu.org; 19 Sep 2013 19:24:09 +0000 Original-Received: from localhost ([127.0.0.1]:49795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMjph-0001hu-9H for submit@debbugs.gnu.org; Thu, 19 Sep 2013 15:24:09 -0400 Original-Received: from mail-pd0-f177.google.com ([209.85.192.177]:55669) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMjpe-0001hO-HQ for 3984@debbugs.gnu.org; Thu, 19 Sep 2013 15:24:07 -0400 Original-Received: by mail-pd0-f177.google.com with SMTP id y10so8754711pdj.36 for <3984@debbugs.gnu.org>; Thu, 19 Sep 2013 12:24:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=8U0Sa8BBPSrqxRK7CTzY9K5Cq/m4V7G07ywLfwTsqI4=; b=f05ZTTvUYsgLw5KViLmtOc8ueWLkVwGbSpJ6ZNRbaDYYcyslaidNvft5vVwVwBXscr oa0xwaeqB97m2zfTHOwddazNAS8QF6MxKZzWvAokCDtmoa2EupEkFNgiL255CRfcb8Xf fDz9dYfx5gRIGddWh4xyuOQ0+T4SwQ2nf/X/Ed3ob7sLuOfTzwlhtxe2J0BxdA7tQNDu T2HourtaxGz8mLLoGZ8N8SLqPsnIdVvByIAuy9NvPLnw6T8rb3TBtRhp1coZAHDDDLpH wgh+wSAAQvZBoujGJ7vl1Ef6nRWrAtfm4tx7c+sK9DYvCJRkcuge0m5HCGjOky485g1m nurg== X-Gm-Message-State: ALoCoQk5xmYa/fBs/5j03JmAHLxKW/8Mgoxf+jyUFnm0+cMgYKdMaHec9m2x6lnulYdcxdD28URk X-Received: by 10.66.249.134 with SMTP id yu6mr4501101pac.37.1379618640744; Thu, 19 Sep 2013 12:24:00 -0700 (PDT) Original-Received: from [192.168.10.2] (user-0c9ha1q.cable.mindspring.com. [24.152.168.58]) by mx.google.com with ESMTPSA id sn4sm6385880pbc.37.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Sep 2013 12:23:59 -0700 (PDT) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 In-Reply-To: <523AB06B.9090606@thompsonclan.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78591 Archived-At: On a related note, I just noticed that the "advice-test-called-interactively-p" test in test/automated/advice-tests.el happens to pass, but only because it doesn't use "called-interactively-p" inside the original function, but rather only inside the advice itself. Also, it doesn't test advising "call-interactively" itself. I think I will see about writing a proper test first, and then use that to start debugging. On Thu Sep 19 01:06:03 2013, Ryan wrote: > Ok, I'll work on debugging my test case tomorrow. > > On Wed Sep 18 20:38:48 2013, Stefan Monnier wrote: >>> advice. This is what "advice--called-interactively-skip" does. >>> (Although >>> reading through it I don't see where the bug is that prevents it >>> recognizing >>> the before advice in my example.) >> >> Exactly. I think we need to fix this problem. It really should work. >> >>> If all advised functions are wrapped by a call to the above function >>> "wrap-function-in-indicator-lambda", >> >> All functions advised with a non-:around advice have such >> a "recognizable wrapper"; and that's indeed what >> advice--called-interactively-skip checks in >> >> (and (eq (nth 1 frame2) 'apply) >> (progn >> (funcall get-next-frame) >> (advice--p (indirect-function (nth 1 frame2))))) >> >> IOW the nadvice.el machinery is itself the recognizable wrapper. >> Not sure why this fails in your test case, tho. >> >> For :around advices, the machinery does not provide a recognizable >> wrapper, so we might want to add an ad-hoc wrapper like you suggest for >> those cases, tho maybe we can avoid the cost of such a wrapper, by >> keeping the so-advised inner-functions in a hash-table (so we can still >> recognize them, even tho they're not tagged directly in the backtrace). >> >> So, I think the first thing is to figure out why your test case fails. >> >> >> Stefan