From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend Date: Sun, 15 Sep 2013 17:53:04 +0300 Message-ID: <5235C9D0.4020105@yandex.ru> References: <8761u5rl5c.fsf@yandex.ru> <83zjrghnca.fsf@gnu.org> <5233B818.5050705@yandex.ru> <838uyzhlv5.fsf@gnu.org> <52341F9A.6030102@gmx.at> <837gejhj7v.fsf@gnu.org> <523430BB.2070902@gmx.at> <83y56zg13n.fsf@gnu.org> <52345FC1.3020305@yandex.ru> <83txhnfrer.fsf@gnu.org> <52352309.70507@yandex.ru> <83eh8qfvx4.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1379256860 8629 80.91.229.3 (15 Sep 2013 14:54:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Sep 2013 14:54:20 +0000 (UTC) Cc: 15365@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 15 16:54:22 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VLDiO-0005XR-OA for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Sep 2013 16:54:20 +0200 Original-Received: from localhost ([::1]:56965 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLDiO-0003er-Eo for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Sep 2013 10:54:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLDiE-0003ea-77 for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2013 10:54:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLDi6-0004HI-PP for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2013 10:54:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLDi6-0004HE-MB for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2013 10:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VLDi6-0003Cr-3U for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2013 10:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Sep 2013 14:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15365-submit@debbugs.gnu.org id=B15365.137925679612262 (code B ref 15365); Sun, 15 Sep 2013 14:54:01 +0000 Original-Received: (at 15365) by debbugs.gnu.org; 15 Sep 2013 14:53:16 +0000 Original-Received: from localhost ([127.0.0.1]:38662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VLDhL-0003Bh-He for submit@debbugs.gnu.org; Sun, 15 Sep 2013 10:53:15 -0400 Original-Received: from mail-ee0-f44.google.com ([74.125.83.44]:56300) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VLDhJ-0003BR-RV for 15365@debbugs.gnu.org; Sun, 15 Sep 2013 10:53:14 -0400 Original-Received: by mail-ee0-f44.google.com with SMTP id b47so1524530eek.31 for <15365@debbugs.gnu.org>; Sun, 15 Sep 2013 07:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=7/PGognd8OdUQtZKbnCMm8uWf2p1EUbVn2oDGQi3ges=; b=fl4ce32c7nFhnXrNltPjKEpvl2cOICOqPBt5fhym2b+nYFhJ0DJgFNqKZ6w9ZOmzY5 AVU6rM4NDMpF2jYR60DYGQ9hsonYop4ruOaQ+lzpx7QI0uXbBbS/mdsf/8IMQtVtPB80 GT6jeV/hhthCdNdUatokP58mhkjRWY6Eh9u/zCNo6f0iAZcGWHwfdMowjDicxl/dtB3Y szqZAw6cimZieqoP1dLoOUvc21VfqjAKDJK/EGOUFTfoPjRvnNj6z7/GKCVeaQgnrcVx BAuVLlicVTd0n7HVSy39aS85E8boXLH+wQcokdYiRthWMzvR/9IXVsmaRY1+d2UxFvRl dVsA== X-Received: by 10.14.115.133 with SMTP id e5mr35776983eeh.27.1379256787734; Sun, 15 Sep 2013 07:53:07 -0700 (PDT) Original-Received: from [192.168.10.2] (62-118-214.netrun.cytanet.com.cy. [62.228.118.214]) by mx.google.com with ESMTPSA id d8sm33432871eeh.8.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 15 Sep 2013 07:53:07 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 In-Reply-To: <83eh8qfvx4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78426 Archived-At: On 15.09.2013 09:20, Eli Zaretskii wrote: > Do the situations that triggered the bug involve font changes? Not to my knowledge, no. > In any case, that revision was about making redisplay optimizations > more aggressive, so it is small wonder that try_window_id, which is > part of those optimizations, is now called in situations where > previously it wasn't. IOW, it is quite possible that there's nothing > wrong with try_window_id being invoked in these situations. I see. >> (TIL that 'git bisect', unlike its Bazaar counterpart, supports >> filtering commits by files they touched. xdisp.c, in this example). > > The display engine is not limited to xdisp.c; dispnew.c and > dispextern.h are important parts of it, and sometimes window.c and the > display-specific back-ends (xterm.c and xfns.c for X and similarly for > w32 and NS) are also involved. I figured that most changes to the display engine would still touch xdisp.c, though maybe it was just a lucky guess. >> None of GitHub repositories are publicly writable, so there's zero >> danger of that. > > Thanks, I didn't know that. (Of course, I never had to use GitHub, > either.) I think it's the same with most of the project hostings. Such as Savannah, for example. > I know about "git push" vs "git commit". What I didn't know is what > exactly do the Emacs commands you used do, in git terms, and how does > that relate to commit and push and the myriad of their options. The > only thing that was clear to me was that a commit is required, because > that's what "C-x v v" does in a modified buffer. I know nothing about > "C-c C-e" in that context. `C-x v v` won't perform the commit until you press `C-c C-c`. `vc-git-log-edit-toggle-amend` works in a Log-Edit buffer. It just toggles the value of the "Amend" header and inserts the last commit's message, so that the user can edit it before committing. > And even if I knew that "push" is not involved, committing to a > repository that tracks upstream development (which is all I do with > git) would need some way to subsequently un-commit that, something I > don't know how to do with git. I didn't want to screw up my work on > GNU Make and Gawk, I'm sure you will understand. Sure. But just in case you're eventually going to make time to study Git, 'git reset' is the command you're looking for. And speaking of experimenting, you can just create a new local repository, not tied to any remotes, with 'git init'.