From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ryan Newsgroups: gmane.emacs.bugs Subject: bug#3984: Fix for #3984 Date: Fri, 13 Sep 2013 12:27:10 -0700 Message-ID: <5233670E.4030703@thompsonclan.org> References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <5232D333.8030206@thompsonclan.org> <523359CD.2070904@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1379100507 3223 80.91.229.3 (13 Sep 2013 19:28:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Sep 2013 19:28:27 +0000 (UTC) Cc: 3984@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 13 21:28:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VKZ2T-0005TP-SF for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Sep 2013 21:28:21 +0200 Original-Received: from localhost ([::1]:50842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKZ2T-0005ul-8G for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Sep 2013 15:28:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKZ2J-0005mq-3g for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2013 15:28:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKZ2B-0008Qs-QV for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2013 15:28:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKZ2B-0008Qo-N1 for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2013 15:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VKZ2B-00017c-Bl for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2013 15:28:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ryan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Sep 2013 19:28:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3984-submit@debbugs.gnu.org id=B3984.13791004434237 (code B ref 3984); Fri, 13 Sep 2013 19:28:03 +0000 Original-Received: (at 3984) by debbugs.gnu.org; 13 Sep 2013 19:27:23 +0000 Original-Received: from localhost ([127.0.0.1]:34497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKZ1W-00016H-Rn for submit@debbugs.gnu.org; Fri, 13 Sep 2013 15:27:23 -0400 Original-Received: from mail-pb0-f49.google.com ([209.85.160.49]:51596) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKZ1U-00015v-PY for 3984@debbugs.gnu.org; Fri, 13 Sep 2013 15:27:21 -0400 Original-Received: by mail-pb0-f49.google.com with SMTP id xb4so1610508pbc.8 for <3984@debbugs.gnu.org>; Fri, 13 Sep 2013 12:27:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=12vY34uazu8U81GDkdX2M0Apl3Lz6t5AsZQwZ+QD7/Q=; b=K31wHy1/+7KeECyJcVnd9/9e16SPanS2fUeAuhpTxThujK3JDlR6azgOp0bnaSxquj rgGVsq4wwrPlULcgKLIqWQ+04Iyw4o2b0bhSCKDIqg0Bne4Emnx9Boubpzl5MrWKdJBb ckfy7ZTqzbwggM08UJuqFyc48JjPIF62KM6I8H0eEphNEbf1A/RrWjsWrEobeAxyC+CZ 1iBwV0mKn/aiHXzh2Pn+a/X70m9w0ITwkTnnZ5XaTJ58YIprSfKtI2AntsCfxxetor2P 3gcLZopNu1sM2pTcwIol+vRQ2gRHxjP3OWEpNZ4+y8JsQGsMh2iv5BHVkh120y4W5pHa qxOQ== X-Gm-Message-State: ALoCoQkHImCJxpKrXa5pJHE/d+3eROwIa0GOnsg13mvwcHr2Jr+DrTwml1koA/UDizcD+GIptden X-Received: by 10.66.255.104 with SMTP id ap8mr17087513pad.53.1379100434488; Fri, 13 Sep 2013 12:27:14 -0700 (PDT) Original-Received: from [192.168.10.2] (user-0c9ha1q.cable.mindspring.com. [24.152.168.58]) by mx.google.com with ESMTPSA id gg10sm13471927pbc.46.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Sep 2013 12:27:13 -0700 (PDT) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 In-Reply-To: <523359CD.2070904@thompsonclan.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78367 Archived-At: On Fri Sep 13 11:30:37 2013, Ryan wrote: > Looking at the code in trunk, I see that there is a special hook for > functions to decide which stack frames to skip over when looking for > call-interactively. I still think they should relax the test for > equality to "equal indirect-functions" instead of exactly the symbol > call-interactively. Actually, I just noticed that in trunk, nadvice.el adds a function to "called-interactively-p-functions" to skip advice-related stack frames, but this works only for advice on the interactive function, not advice defined on call-interactively itself. Furthermore, from my limited testing it appears that the structure of the call stack for advised functions has changes significantly in trunk, making my code obsolete. The whole thing looks like a work in progress right now.