From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression Date: Fri, 02 Dec 2022 23:54:40 +0100 Message-ID: <52242BB9-FE06-4DEE-AF54-8456BD1F9F07@thornhill.no> References: <831qpklejb.fsf@gnu.org> <83mt88jul4.fsf@gnu.org> <0A18F996-F3BB-4A7D-A0BE-76C8374DE517@thornhill.no> <8335a0jofb.fsf@gnu.org> <7BE15945-C463-448A-8593-E3B5D0E374FB@thornhill.no> <871qpj1x2k.fsf@thornhill.no> <83fsdzin4e.fsf@gnu.org> <87v8mvzgmt.fsf@thornhill.no> <838rjrigmq.fsf@gnu.org> <87k03bz99r.fsf@thornhill.no> <835yeviats.fsf@gnu.org> <87v8mt7dnb.fsf@thornhill.no> <7ac55edd-3887-7e38-7d89-4902f0b61416@secure.kjonigsen.net> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38278"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59691@debbugs.gnu.org To: jostein@kjonigsen.net, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 23:56:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1Ex4-0009il-6o for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 23:56:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1Ewu-0003ql-Ad; Fri, 02 Dec 2022 17:56:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1Ews-0003qW-T1 for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 17:56:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1Ews-0002UF-KC for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 17:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1Ews-0002Pn-Fm for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 17:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 22:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59691 X-GNU-PR-Package: emacs Original-Received: via spool by 59691-submit@debbugs.gnu.org id=B59691.16700217519277 (code B ref 59691); Fri, 02 Dec 2022 22:56:02 +0000 Original-Received: (at 59691) by debbugs.gnu.org; 2 Dec 2022 22:55:51 +0000 Original-Received: from localhost ([127.0.0.1]:49347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1Ewg-0002PZ-Ty for submit@debbugs.gnu.org; Fri, 02 Dec 2022 17:55:51 -0500 Original-Received: from out-176.mta0.migadu.com ([91.218.175.176]:19358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1Ewb-0002PS-Vg for 59691@debbugs.gnu.org; Fri, 02 Dec 2022 17:55:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670021743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+PvG/xMGSu+d+43joy56dTsC+NJFHAAwBEnmWqG6QRY=; b=fiSp7nOKWkUIUE38ORR7c62Il57G028oOySl2uGjJSg0Q6fXz5R+BkeEeLoJkvd0W8cina L7fSpy2qokqwzwBNk5O7WPT4V28oLKYRXsQ3BoxXkd0nApPYLTEuybhTPt8jd5MGtWvdTy mVEhfmgkSAxuUHJ/mjc6wuqGbY7v4RNyE/7zEOzFTJmE8Z9siyD+xd5IYnRAqH+EkKH/TY yrR7VA70XOWp0LxVSEAmxQDOhJFzOLptUCaMvtUEZtZ7B7SKaEUoUDeT+4/sNvmeX6VMkn JuKkz8HOUkE2MPbmtx6QuxDsE7TsauAo66knbOrSDJ+QHve9e622vKMPoxHNFg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <7ac55edd-3887-7e38-7d89-4902f0b61416@secure.kjonigsen.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249792 Archived-At: On 2 December 2022 22:28:36 CET, "Jostein Kj=C3=B8nigsen" wrote: > >>> Cool=2E I applied the patch, thanks Theo! I changed typescript-ts-mode= =E2=80=94base-mode to typescript-ts-base-mode, since I don=E2=80=99t think = anyone has strong opinions about its naming, and typescript-ts-base-mode is= more consistent with other tree-sitter base modes=2E >>> Yuan >> Thanks! I believe this can be closed=2E What do you think, Jostein? >>=20 >> Theo > >Hey guys=2E > >Amazing work! Sorry for being somewhat slow wrt to testing=2E > >I had to rebuild some tree-sitter libraries, and the build-code in admin/= notes/tree-sitter/ seemingly didn't work out of the box for both plain type= script and tsx=2E Yadda, yadda, yadda=2E I've modified the scripts to also = build for typescript/tsx=2E Do you wan't me to send in a patch for that, Yu= an? > I've already sent a patch for that :) >Back to the point: Either way, I've tested both TS-code and TSX-code now,= and it seems to work much better=2E > Yay! >I still see some errors in TSX-code I can't recall seing in the old mode = (and I might report those issues, once I have time to collect more accurate= data on them), but for now I definitely think what we have here warrants m= arking this particular bug as closed=2E :) Great news! We'll get to the other stuff in due time :) Theo