unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: 15189@debbugs.gnu.org
Subject: bug#15189: 24.3.50; display-buffer does not work well with custom frames.
Date: Tue, 27 Aug 2013 08:47:19 +0200	[thread overview]
Message-ID: <521C4B77.80107@gmx.at> (raw)
In-Reply-To: <m2a9k41a5u.wl%esq@lawlist.com>

 > Using your suggestion of find-file-noselect works well with the initial example, and then just adding (switch-to-buffer (get-file-buffer buffer-filename)) to the tail end of the lawlist-display-buffer-function.

If you want to show a file-visiting buffer in the selected window, yes.
I'd rather add a rule that calls `display-buffer-same-window' and rewrite
the code

(when (lawlist-regexps-match-p ...)
   ...)
(when (lawlist-regexps-match-p ...)
   ...)

as

(cond
   ((lawlist-regexps-match-p ...)
    ...)
   ((lawlist-regexps-match-p ...)
    ...)
   (t
     (display-buffer-same-window ...)))

BTW you should also make code like

           (if (and
               (not (equal "MAIN" (frame-parameter frame 'name)))
               (not (equal "SYSTEM" (frame-parameter frame 'name)))
               (not (equal "ORG" (frame-parameter frame 'name)))
               (not (equal "WANDERLUST" (frame-parameter frame 'name)))
               (not (equal "MISCELLANEOUS" (frame-parameter frame 'name))) )

more readable by defining a variable like

(defvar my-regexp "^\\(?:MAIN\\|SYSTEM\\|ORG\\|WANDERLUST\\| MISCELLANEOUS\\)$"
   "My doc-string.")

and using
	    (not (string-match my-regexp (frame-parameter frame 'name)))

instead.

martin





  reply	other threads:[~2013-08-27  6:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26  0:50 bug#15189: 24.3.50; display-buffer does not work well with custom frames Keith David Bershatsky
2013-08-26 13:06 ` martin rudalics
     [not found]   ` <4066A3F6-AB96-43EE-B8F4-E3DF2F73CBD2@lawlist.com>
2013-08-26 15:01     ` martin rudalics
     [not found]     ` <521B6B84.5060106@gmx.at>
     [not found]       ` <742F02FA-4469-4BCA-94A5-D8A7A679B52B@lawlist.com>
2013-08-26 16:34         ` martin rudalics
2013-08-26 20:15 ` Keith David Bershatsky
2013-08-27  6:47   ` martin rudalics [this message]
2013-08-28  3:59     ` Kevin Rodgers
2013-08-28 16:35     ` Keith David Bershatsky
2013-08-29  0:21     ` Keith David Bershatsky
2013-08-27 22:30 ` Keith David Bershatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521C4B77.80107@gmx.at \
    --to=rudalics@gmx.at \
    --cc=15189@debbugs.gnu.org \
    --cc=esq@lawlist.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).