* bug#15185: 24.3; display-buffer-use-some-window calls get-largest-window incorrectly
@ 2013-08-25 18:41 stephe
2013-08-26 13:06 ` martin rudalics
0 siblings, 1 reply; 4+ messages in thread
From: stephe @ 2013-08-25 18:41 UTC (permalink / raw)
To: 15185
display-buffer-use-some-window has this line near line 5756:
(get-largest-window 0 not-this-window))))
this is missing a 'nil for the DEDICATED argument to
`get-largest-window'; it should be:
(get-largest-window 0 nil not-this-window))))
This causes the current window to be used even when not-this-window is t.
In GNU Emacs 24.3.1 (i686-pc-linux-gnu, GTK+ Version 2.24.10)
of 2013-08-21 on Shevek
Windowing system distributor `The Cygwin/X Project', version 11.0.11401000
System Description: Debian GNU/Linux 7.1 (wheezy)
--
-- Stephe
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#15185: 24.3; display-buffer-use-some-window calls get-largest-window incorrectly
2013-08-25 18:41 bug#15185: 24.3; display-buffer-use-some-window calls get-largest-window incorrectly stephe
@ 2013-08-26 13:06 ` martin rudalics
2013-08-27 12:04 ` Stephen Leake
0 siblings, 1 reply; 4+ messages in thread
From: martin rudalics @ 2013-08-26 13:06 UTC (permalink / raw)
To: stephe; +Cc: 15185
> display-buffer-use-some-window has this line near line 5756:
>
> (get-largest-window 0 not-this-window))))
>
> this is missing a 'nil for the DEDICATED argument to
> `get-largest-window'; it should be:
>
> (get-largest-window 0 nil not-this-window))))
>
> This causes the current window to be used even when not-this-window is t.
Can you commit it, please.
Thanks, martin
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#15185: 24.3; display-buffer-use-some-window calls get-largest-window incorrectly
2013-08-26 13:06 ` martin rudalics
@ 2013-08-27 12:04 ` Stephen Leake
2013-08-27 12:48 ` martin rudalics
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Leake @ 2013-08-27 12:04 UTC (permalink / raw)
To: martin rudalics; +Cc: 15185
martin rudalics <rudalics@gmx.at> writes:
>> display-buffer-use-some-window has this line near line 5756:
>>
>> (get-largest-window 0 not-this-window))))
>>
>> this is missing a 'nil for the DEDICATED argument to
>> `get-largest-window'; it should be:
>>
>> (get-largest-window 0 nil not-this-window))))
>>
>> This causes the current window to be used even when not-this-window is t.
>
> Can you commit it, please.
No, I don't have write privs.
--
-- Stephe
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#15185: 24.3; display-buffer-use-some-window calls get-largest-window incorrectly
2013-08-27 12:04 ` Stephen Leake
@ 2013-08-27 12:48 ` martin rudalics
0 siblings, 0 replies; 4+ messages in thread
From: martin rudalics @ 2013-08-27 12:48 UTC (permalink / raw)
To: 15185-done; +Cc: Stephen Leake
Installed as revision#114026 on trunk. Bug closed.
Thanks, martin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-27 12:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-25 18:41 bug#15185: 24.3; display-buffer-use-some-window calls get-largest-window incorrectly stephe
2013-08-26 13:06 ` martin rudalics
2013-08-27 12:04 ` Stephen Leake
2013-08-27 12:48 ` martin rudalics
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).