From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62333: 30.0.50; Issue with tree-sitter syntax tree during certain changes Date: Mon, 27 Mar 2023 11:43:40 -0700 Message-ID: <5213F025-B8CE-4405-92A7-2D38BE8A2776@gmail.com> References: <87fs9yur7r.fsf@gmail.com> <2fd8f2b8-d9c4-c825-a789-f2d42324859f@yandex.ru> <09539C5E-23DA-4B00-A3F6-873A41D6A2CE@gmail.com> <83h6uc549z.fsf@gnu.org> <665745A2-FDC8-45DE-BFF5-2F688FC85431@gmail.com> <491b788f-c3c3-4877-daa0-f515be9f3a17@yandex.ru> <83sfduelab.fsf@gnu.org> <8FC25A01-6934-43BB-899C-CA5926BEA3CF@gmail.com> <83jzz5c8ml.fsf@gnu.org> <83edpdc6sn.fsf@gnu.org> <1ca302bf-99dc-7f9e-8544-063064a1cb21@yandex.ru> <831qlcdisi.fsf@gnu.org> <398721ad-79b0-3f6d-97b3-4902d9bfbe39@yandex.ru> <83wn34c2qa.fsf@gnu.org> <3b3d82d1-f0f6-a768-a5db-8dc9386a5a34@yandex.ru> <83r0tcbz8g.fsf@gnu.org> <1967361679760225@umbzx4hqxrw5qxo7.sas.yp-c.yandex.net> <83mt40bxzd.fsf@gnu.org> <83jzz4bugh.fsf@gnu.org> <35322CB1-DF75-47C1-9B66-21260C437006@gmail.com> <83a600b0gk.fsf@gnu.org> <83edpa9v5r.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34857"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Wilhelm Kirschbaum , 62333@debbugs.gnu.org, Dmitry Gutov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 27 20:44:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgrpH-0008qi-Lf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Mar 2023 20:44:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgrp6-0007Q2-Ke; Mon, 27 Mar 2023 14:44:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgrp5-0007PT-5i for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 14:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgrp4-0000fh-Qa for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 14:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgrp4-0007pr-EN for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 14:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 18:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62333 X-GNU-PR-Package: emacs Original-Received: via spool by 62333-submit@debbugs.gnu.org id=B62333.167994264030104 (code B ref 62333); Mon, 27 Mar 2023 18:44:02 +0000 Original-Received: (at 62333) by debbugs.gnu.org; 27 Mar 2023 18:44:00 +0000 Original-Received: from localhost ([127.0.0.1]:48442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgrp2-0007pU-2w for submit@debbugs.gnu.org; Mon, 27 Mar 2023 14:44:00 -0400 Original-Received: from mail-pj1-f47.google.com ([209.85.216.47]:52019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgrp0-0007pI-GP for 62333@debbugs.gnu.org; Mon, 27 Mar 2023 14:43:58 -0400 Original-Received: by mail-pj1-f47.google.com with SMTP id j13so8565690pjd.1 for <62333@debbugs.gnu.org>; Mon, 27 Mar 2023 11:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679942632; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lRHnhDGWx3A7VJUBXV06Ercj3Ped9ZYNBrNuQ7otpQQ=; b=B0eCYXwgLrzyEZOF6kGj8gvUomkfClBNSlkf9EArdU6PkLa/bof/zzY9ACY8fwm2zn Ic+xMhHgOGJ5FrC0sJcWNWvlxnscGaRA/2QWVGLEbw8Er9CXi9ivMoAVomGBH7PmX4xj 2/wTghKVEylHpEArzoitY0ob4YomT12bW0SYnrP6wcScmRtXg8ccNwCVM98tD9tRBcxS rHD2TuK/2Y5NrjeOto01Grg4Bn71yAJoY1Zey4BKh37t/sy4yMK+hlu8o2gAdwNGA0J6 XlJH0jHaNR54RvCF6mr69DfpA26HfdiKMOVWET8Cl9gMVsFpNm129opmFMJ2FnWj1fjs t3cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679942632; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lRHnhDGWx3A7VJUBXV06Ercj3Ped9ZYNBrNuQ7otpQQ=; b=WFWHJETuEifgKVpKvc1kBYExVwAw14sW+7hrOvwFHQMA0BcsZduNI8Zgyyb1iPbzuO sztGEzIG1Vhd7JlWFZzzOvheC6ET9sJAsqO+rLZtlwUX+GE2a7lDEwas8F76/uRCnWEf 3aT8awElJRjlUmp6HFkBRHDku4mZE/ND8ZbxJ9eJJQ+jkhCfbpm2zwhmCg9v73L1tYRb jpm4nXVZpg2kLJl7uJUoDvzkeMWWS9CtPuBG+XSY3oVFnvBwmBInQcQmUrQc2zM5EHpX sewEUdoVgqTMdbms4XX/Ob4FcwCQp02i28FOL/lHbe44fA76z5kOJjWlfJUxJ+bI5Tv7 8pYg== X-Gm-Message-State: AAQBX9dMwh7u9WPNsguHybGbj8biyKHYSiMPuYld9gXHdzZ2u8Gqr3GU AXMpDD0MgBaRGhZK9u4I+0s= X-Google-Smtp-Source: AKy350bGtrdO8nAXIjZ6y/9+nrJn5kH+7RHG9Ms24GOGipvqAUFqQ93j64E8rbT/dyAIwnvbPa5uUw== X-Received: by 2002:a17:90b:3911:b0:23f:9d83:ad76 with SMTP id ob17-20020a17090b391100b0023f9d83ad76mr13727073pjb.23.1679942632451; Mon, 27 Mar 2023 11:43:52 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id b17-20020a631b51000000b004e28be19d1csm18392052pgm.32.2023.03.27.11.43.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Mar 2023 11:43:51 -0700 (PDT) In-Reply-To: <83edpa9v5r.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.400.51.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258768 Archived-At: > On Mar 27, 2023, at 6:32 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sun, 26 Mar 2023 15:57:55 -0700 >> Cc: Dmitry Gutov , >> Wilhelm Kirschbaum , >> 62333@debbugs.gnu.org >>=20 >>> We could leave this alone for now, but in that case let's at least = add >>> some FIXME comment in the relevant place(s), so that we could later >>> revisit this. >>=20 >> Dmitry=E2=80=99s idea sounds good, we can add a tree-sitter backend = for show-paren-data-function, and make the backend for = blink-matching-paren configurable, then add a backend for it that uses = show-paren-data-function, which in turn uses tree-sitter (or we add a = backend that uses tree-sitter directly). In either case, the tree-sitter = backend don=E2=80=99t need to use narrowing and we are good. >=20 > Is this suitable for the release branch? It sounds non-trivial, and > the problem is not very severe, to say the least. No, it=E2=80=99s intended for the master branch. Emacs-29 doesn=E2=80=99t = have the blink-matching-paren problem anyway, since it doesn=E2=80=99t = have treesit-forward-sexp.=20 Yuan=