From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 15094@debbugs.gnu.org
Subject: bug#15094: Fix for posix_memalign on Cygwin
Date: Thu, 15 Aug 2013 12:15:49 -0400 [thread overview]
Message-ID: <520CFEB5.1000206@cornell.edu> (raw)
In-Reply-To: <520CD0D6.6060200@cornell.edu>
On 8/15/2013 9:00 AM, Ken Brown wrote:
> On 8/15/2013 7:51 AM, Ken Brown wrote:
>> On 8/14/2013 10:46 PM, Eli Zaretskii wrote:
>>>> Date: Wed, 14 Aug 2013 15:52:53 -0400
>>>> From: Ken Brown <kbrown@cornell.edu>
>>>> CC: 15094@debbugs.gnu.org
>>>>
>>>> /* Cygwin allows applications to provide their own malloc. As of
>>>> cygwin-1.7.24, applications that provide their own malloc are also
>>>> allowed to provide their own posix_memalign (but not memalign). Calls
>>>> to memalign are handled by Cygwin's memalign, which always returns
>>>> ENOSYS if the application has defined its own malloc. So we have to
>>>> rename memalign in order to make sure that posix_memalign calls
>>>> Emacs's memalign rather than Cygwin's. */
>>>
>>> How does Cygwin memalign come into play, when Emacs provides its own?
>>
>> As I said in the comment, Cygwin does not let applications define their
>> own memalign. During linking, calls to memalign become calls to
>> Cygwin's memalign.
>
> Hold on...I think I'm missing something obvious. I have to recheck this.
Thanks for pressing me on this, Eli. I did of course miss the obvious
fact that posix_memalign in gmalloc.c will use memalign as defined in
the same file. I'll revert the change. I'll also use the opportunity
to update some comments elsewhere in the code.
Sorry for the noise.
Ken
next prev parent reply other threads:[~2013-08-15 16:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 16:22 bug#15094: Fix for posix_memalign on Cygwin Ken Brown
2013-08-14 19:11 ` Ken Brown
2013-08-14 19:29 ` Eli Zaretskii
2013-08-14 19:52 ` Ken Brown
2013-08-15 2:46 ` Eli Zaretskii
2013-08-15 11:51 ` Ken Brown
2013-08-15 13:00 ` Ken Brown
2013-08-15 16:15 ` Ken Brown [this message]
2013-08-15 16:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520CFEB5.1000206@cornell.edu \
--to=kbrown@cornell.edu \
--cc=15094@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).