unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: 16759@debbugs.gnu.org
Subject: bug#16759: CC Mode modes: mode hooks are called twice.
Date: Wed, 19 Feb 2014 12:29:24 -0500	[thread overview]
Message-ID: <51k3crxb7v.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <20140214220934.GA3645@acm.acm>

Alan Mackenzie wrote:

> The cause of this is that there is an invocation of run-mode-hooks
> generated by the macro define-derived-mode as well as an explicit call to
> run-mode-hooks which is not at the end of the mode function.

IIUC, this is because you want to run some C-mode stuff after the hooks.
A simple solution would be to add :after-hook to define-derived-mode.
You already did this for define-minor-mode.
It would be good for symmetry/consistency if nothing else, and seems
pre-approved:

http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00140.html

:)





  reply	other threads:[~2014-02-19 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14 22:09 bug#16759: CC Mode modes: mode hooks are called twice Alan Mackenzie
2014-02-19 17:29 ` Glenn Morris [this message]
2014-02-19 18:49   ` Stefan Monnier
     [not found]   ` <jwvha7vosnw.fsf-monnier+emacsbugs@gnu.org>
2014-02-19 19:03     ` Glenn Morris
2014-03-20 16:47   ` Stefan
     [not found] ` <mailman.15156.1392416485.10748.bug-gnu-emacs@gnu.org>
2016-05-09 18:31   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51k3crxb7v.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=16759@debbugs.gnu.org \
    --cc=acm@muc.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).