From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#14970: crash deleting frames Date: Sun, 28 Jul 2013 10:39:54 +0200 Message-ID: <51F4D8DA.9090806@gmx.at> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1375000881 12995 80.91.229.3 (28 Jul 2013 08:41:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Jul 2013 08:41:21 +0000 (UTC) Cc: 14970@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 10:41:22 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V3MXZ-0003K8-W6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2013 10:41:22 +0200 Original-Received: from localhost ([::1]:40947 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3MXZ-00005P-LK for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2013 04:41:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3MXP-0008PY-Af for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 04:41:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3MXI-0004uo-0l for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 04:41:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3MXH-0004uk-U1 for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 04:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V3MXH-0001PU-NI for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2013 04:41:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2013 08:41:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14970 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14970-submit@debbugs.gnu.org id=B14970.13750008135210 (code B ref 14970); Sun, 28 Jul 2013 08:41:03 +0000 Original-Received: (at 14970) by debbugs.gnu.org; 28 Jul 2013 08:40:13 +0000 Original-Received: from localhost ([127.0.0.1]:53985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3MWS-0001Lt-84 for submit@debbugs.gnu.org; Sun, 28 Jul 2013 04:40:12 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:52689) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3MWN-0001Kq-FX for 14970@debbugs.gnu.org; Sun, 28 Jul 2013 04:40:09 -0400 Original-Received: from [62.47.48.182] ([62.47.48.182]) by mail.gmx.com (mrgmx101) with ESMTPA (Nemesis) id 0MSZ6u-1Ubpjw0iBA-00RVVl for <14970@debbugs.gnu.org>; Sun, 28 Jul 2013 10:40:00 +0200 In-Reply-To: X-Provags-ID: V03:K0:fPTMnhp7DwHXizMQfSYwTW0DC1sOhTGWHbwZ7epaBzZtmldgflp 5WLdZsy63dH6MdkkYDYAq4z7QKww1FQatsCOUUVSz59aOe6O7HoZ+8WyIFopqUr97Lprkv7 VNbyT5oAC2KkMZ3SvQ+ZdCZpYC5LZ3oFXJR62vSDLi2Ru6MJs+uvUUv7YFdALxnG3YbbFwn 2tpMrGOl6JMpTk/L4nxXg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76720 Archived-At: > 3216 w = XWINDOW (FRAME_SELECTED_WINDOW (f)); My crystal ball tells me that Eli will check whether f is a live frame in between the following two statements of w32fns.c f = x_window_to_frame (dpyinfo, hwnd); w = XWINDOW (FRAME_SELECTED_WINDOW (f)); which should considerably reduce the danger that the frame has been recycled when accessing FRAME_SELECTED_WINDOW. I'm not sure whether it's worth the effort having FRAME_SELECTED_WINDOW check that its argument is a live frame. martin