From: martin rudalics <rudalics@gmx.at>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 14970@debbugs.gnu.org
Subject: bug#14970: crash deleting frames
Date: Sun, 28 Jul 2013 10:39:54 +0200 [thread overview]
Message-ID: <51F4D8DA.9090806@gmx.at> (raw)
In-Reply-To: <CAAeL0SR2FmAA5yw47RDzHFWMYp4yUKwE8aa5L-93jXJ=ZP=OJQ@mail.gmail.com>
> 3216 w = XWINDOW (FRAME_SELECTED_WINDOW (f));
My crystal ball tells me that Eli will check whether f is a live frame
in between the following two statements of w32fns.c
f = x_window_to_frame (dpyinfo, hwnd);
w = XWINDOW (FRAME_SELECTED_WINDOW (f));
which should considerably reduce the danger that the frame has been
recycled when accessing FRAME_SELECTED_WINDOW. I'm not sure whether
it's worth the effort having FRAME_SELECTED_WINDOW check that its
argument is a live frame.
martin
next prev parent reply other threads:[~2013-07-28 8:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 0:22 bug#14970: crash deleting frames Juanma Barranquero
2013-07-28 1:08 ` Juanma Barranquero
2013-07-28 8:39 ` martin rudalics [this message]
2013-07-28 15:28 ` Eli Zaretskii
2013-07-29 7:54 ` martin rudalics
2013-07-29 15:29 ` Eli Zaretskii
2013-07-29 17:03 ` martin rudalics
2013-07-28 15:25 ` Eli Zaretskii
2013-07-28 17:04 ` Juanma Barranquero
2013-07-28 17:28 ` Eli Zaretskii
2013-07-28 17:34 ` Juanma Barranquero
2013-07-28 17:37 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F4D8DA.9090806@gmx.at \
--to=rudalics@gmx.at \
--cc=14970@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).