unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Peter Rosin <peda@lysator.liu.se>
To: Andreas Schwab <schwab@suse.de>
Cc: 14830@debbugs.gnu.org
Subject: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions
Date: Tue, 09 Jul 2013 10:07:28 +0200	[thread overview]
Message-ID: <51DBC4C0.9090500@lysator.liu.se> (raw)
In-Reply-To: <mvmwqp0td6r.fsf@hawking.suse.de>

On 2013-07-09 09:17, Andreas Schwab wrote:
> Peter Rosin <peda@lysator.liu.se> writes:
> 
>> #include <windows.h>
>> #include <usp10.h>
>>
>> int
>> main ()
>> {
>>   PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);
> 
> You need to declare pHeader somewhere.

Big sigh. Thanks for catching...

Cheers,
Peter

diff --git a/ChangeLog b/ChangeLog
index 220cffb..3ba3093 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-07-09  Peter Rosin <peda@lysator.liu.se>  (tiny change>
+
+       * configure.ac (HAVE_W32): Avoid nested functions (the second
+       argument of AC_LANG_PROGRAM is already expanded inside a function).
+
 2013-07-08  Magnus Henoch <magnus.henoch@gmail.com> (tiny change)

        * configure.ac (HAVE_IMAGEMAGICK): Check on NS also (Bug#14798).
diff --git a/configure.ac b/configure.ac
index 3830ee3..bb140a8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1635,8 +1635,8 @@ if test "${opsys}" = "mingw32"; then
   AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
      #include <windows.h>
      #include <usp10.h>]],
-   [[void test(PIMAGE_NT_HEADERS pHeader)
-     {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]])],
+   [[PIMAGE_NT_HEADERS pHeader;
+     PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader)]])],
    [emacs_cv_w32api=yes
     HAVE_W32=yes],
    emacs_cv_w32api=no)
--
1.7.9







  reply	other threads:[~2013-07-09  8:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08 22:49 bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions Peter Rosin
2013-07-09  2:41 ` Eli Zaretskii
2013-07-09  6:27   ` Peter Rosin
2013-07-09  6:53     ` Peter Rosin
2013-07-09  7:17       ` Andreas Schwab
2013-07-09  8:07         ` Peter Rosin [this message]
2013-07-09 18:07           ` Eli Zaretskii
2013-07-09  6:56     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DBC4C0.9090500@lysator.liu.se \
    --to=peda@lysator.liu.se \
    --cc=14830@debbugs.gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).