* bug#66498: 30.0.50; Missing choice in ruby-insert-encoding-magic-comment @ 2023-10-12 13:15 Mauro Aranda 2023-10-12 13:19 ` Mauro Aranda 0 siblings, 1 reply; 3+ messages in thread From: Mauro Aranda @ 2023-10-12 13:15 UTC (permalink / raw) To: 66498 Docstring of ruby-insert-encoding-magic-comment says its value can be always-utf8, but its :type is just boolean. ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#66498: 30.0.50; Missing choice in ruby-insert-encoding-magic-comment 2023-10-12 13:15 bug#66498: 30.0.50; Missing choice in ruby-insert-encoding-magic-comment Mauro Aranda @ 2023-10-12 13:19 ` Mauro Aranda 2023-10-12 14:27 ` Dmitry Gutov 0 siblings, 1 reply; 3+ messages in thread From: Mauro Aranda @ 2023-10-12 13:19 UTC (permalink / raw) To: 66498 [-- Attachment #1: Type: text/plain, Size: 39 bytes --] tags 66498 patch quit Patch attached. [-- Attachment #2: 0001-Fix-a-defcustom-type.patch --] [-- Type: text/x-patch, Size: 1050 bytes --] From 213d8abe991e72a1f29e1018184427b287036f7f Mon Sep 17 00:00:00 2001 From: Mauro Aranda <maurooaranda@gmail.com> Date: Thu, 12 Oct 2023 10:17:57 -0300 Subject: [PATCH] Fix a defcustom :type * lisp/progmodes/ruby-mode.el (ruby-insert-encoding-magic-comment): Allow always-utf8. (Bug#66498) --- lisp/progmodes/ruby-mode.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/ruby-mode.el b/lisp/progmodes/ruby-mode.el index 9d80bbd72dd..5c34ddc562b 100644 --- a/lisp/progmodes/ruby-mode.el +++ b/lisp/progmodes/ruby-mode.el @@ -516,7 +516,9 @@ ruby-insert-encoding-magic-comment When set to `always-utf8' an utf-8 comment will always be added, even if it's not required." - :type 'boolean :group 'ruby) + :type '(choice (const :tag "Don't insert" nil) + (const :tag "Insert utf-8 comment always" always-utf8) + (const :tag "Insert only when required" t))) (defcustom ruby-encoding-magic-comment-style 'ruby "The style of the magic encoding comment to use." -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#66498: 30.0.50; Missing choice in ruby-insert-encoding-magic-comment 2023-10-12 13:19 ` Mauro Aranda @ 2023-10-12 14:27 ` Dmitry Gutov 0 siblings, 0 replies; 3+ messages in thread From: Dmitry Gutov @ 2023-10-12 14:27 UTC (permalink / raw) To: Mauro Aranda, 66498-done Version: 30.1 On 12/10/2023 16:19, Mauro Aranda wrote: > tags 66498 patch > quit > > > Patch attached. Pushed to master, thanks! ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-12 14:27 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-10-12 13:15 bug#66498: 30.0.50; Missing choice in ruby-insert-encoding-magic-comment Mauro Aranda 2023-10-12 13:19 ` Mauro Aranda 2023-10-12 14:27 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).