From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas =?UTF-8?Q?R=C3=B6hler?= Newsgroups: gmane.emacs.bugs Subject: bug#14303: 24.3; Bug in comment-search-backward Date: Thu, 16 May 2013 09:12:29 +0200 Message-ID: <519486DD.1040505@easy-emacs.de> References: <5193B43B.8070007@easy-emacs.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1368688271 27327 80.91.229.3 (16 May 2013 07:11:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 May 2013 07:11:11 +0000 (UTC) Cc: 14303@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 16 09:11:10 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UcsLD-0007r9-UC for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2013 09:11:08 +0200 Original-Received: from localhost ([::1]:53637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcsLD-0006iH-Ex for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2013 03:11:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcsL2-0006hO-GQ for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 03:10:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcsL0-0005qB-N3 for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 03:10:56 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcsL0-0005q2-EC for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 03:10:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UcsL8-0005VC-HI for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 03:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2013 07:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14303 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14303-submit@debbugs.gnu.org id=B14303.136868821721076 (code B ref 14303); Thu, 16 May 2013 07:11:02 +0000 Original-Received: (at 14303) by debbugs.gnu.org; 16 May 2013 07:10:17 +0000 Original-Received: from localhost ([127.0.0.1]:46946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcsKN-0005Tr-Pn for submit@debbugs.gnu.org; Thu, 16 May 2013 03:10:16 -0400 Original-Received: from moutng.kundenserver.de ([212.227.17.8]:61049) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcsKJ-0005TX-Ko for 14303@debbugs.gnu.org; Thu, 16 May 2013 03:10:13 -0400 Original-Received: from [192.168.178.21] (brln-4db9d5fe.pool.mediaWays.net [77.185.213.254]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0Lpxfr-1TysTc3ijP-00fcc6; Thu, 16 May 2013 09:09:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 In-Reply-To: X-Provags-ID: V02:K0:S6xwFQofpbI5QWMAOScWN7blYarah0Y8K05ZqWeCRog sKZKB/hmSQ8/YLCJ0Msr/3KoyCYEqYXkSN5BkCDIWealQJlOyW FtRmRpIM2r6nc+znQJ1Ohu8+tUejMrj+ugo2iq6J6KL1mX9/nH zZHnbXQjlQVD1HV6o/+VuKIRDe/ExB3OXKwpkzjAfOn++cdjX+ N15tt8a2BCLf/fmZl0yDm9sN2sjICsDew/tgZBx9q6QdA5G3PP UdSEsqkUcw+tYVmQDLPmBs1y3OoYdiPMQCfvSIoGvWp9w1dnnE Ec+V++B1eNRPwrZx+Fp1N4l+RzS7h9osw7XAugwiZTPbVq4Qef /dKviYlZVsT/AJkyn78HZ4wzxYJLOcrqe0Z6KjP2o X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74319 Archived-At: Am 16.05.2013 06:02, schrieb Leo Liu: > On 2013-05-16 00:13 +0800, Andreas Röhler wrote: >> syntax-ppss is reliable, while re-search-backward comment-start-skip >> might stop inside a string etc. >> >> backward-line, end-of-line >> if nt4 and nth8, goto char nth8 >> >> that's nearly all >> as done consider limit of search, sure. >> >> Watching with interest, >> >> Andreas > > I don't know what to make of this comment. Do you see a problem in the > patch? > Yes, same thing as with beg-of-defun discussed elsewhere. + (while (and (not found) (re-search-backward comment-start-skip limit t)) + (setq end (match-end 0)) + (or (nth 8 (syntax-ppss)) (setq found t))) This might find a comment-start inside a string. Rely at (syntax-ppss) if nt4 and nth8, goto char nth8 Cheers, Andreas > Thanks, > Leo >